From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#56742: 29.0.50; Python indendation problem after comment Date: Wed, 27 Jul 2022 12:27:09 +0900 Message-ID: References: <871qualdod.fsf@gmx.net> <87sfmo11gm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23271"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stephen Berman , 56742@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 27 05:28:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGXib-0005rH-2l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Jul 2022 05:28:17 +0200 Original-Received: from localhost ([::1]:44234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGXiZ-00082j-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Jul 2022 23:28:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGXiP-00080b-2H for bug-gnu-emacs@gnu.org; Tue, 26 Jul 2022 23:28:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGXiL-0003sX-MR for bug-gnu-emacs@gnu.org; Tue, 26 Jul 2022 23:28:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGXiL-0002J8-HH for bug-gnu-emacs@gnu.org; Tue, 26 Jul 2022 23:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jul 2022 03:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 56742-submit@debbugs.gnu.org id=B56742.16588924518823 (code B ref 56742); Wed, 27 Jul 2022 03:28:01 +0000 Original-Received: (at 56742) by debbugs.gnu.org; 27 Jul 2022 03:27:31 +0000 Original-Received: from localhost ([127.0.0.1]:54804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGXhr-0002IE-HV for submit@debbugs.gnu.org; Tue, 26 Jul 2022 23:27:31 -0400 Original-Received: from mail-ed1-f52.google.com ([209.85.208.52]:44696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGXhp-0002I0-Pw for 56742@debbugs.gnu.org; Tue, 26 Jul 2022 23:27:30 -0400 Original-Received: by mail-ed1-f52.google.com with SMTP id i13so10713444edj.11 for <56742@debbugs.gnu.org>; Tue, 26 Jul 2022 20:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=dP/fChOxhQbayycasAUkF88x/1UK7Taw3gCDE+viXKs=; b=b60o4eOF7XdLgLOHjwTwmVh1egfQWjX70MxW9lBjk9kGgH2Q0dH9/iIDjoqr9CCPGq qeWeHNaJo8gPdpucN2fvajkfThn4Py3OaoF8R2wHI0AvFcWpgtp3TCl6q0PZgdQlbR/y Cmp6rmwQldYOM2YTNAh1a0+zvzfEKke4661791XqJpBsiNDblKLXT/zpNShJuIOr80W4 3IagQWwlNRoknXpgWDRXns1mQc06EJvzdzduYnh6GQ+W2Dx3UAuTuxSbZICPOEhcaqiW WOoQ3lYVdSJ3ZGN9oeeMSG7dd3YJa0m4Xp+hjpM90IxliDX4qK/Q9libmzCw8PUL2qp/ Bi5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=dP/fChOxhQbayycasAUkF88x/1UK7Taw3gCDE+viXKs=; b=PXYYOTea+I+q4ArURAzN4kw0VR32oQnKjEp01fjyFqiTKHZnLj7RR4uwIizchB0gEy FpuVCiwr+J8o615hdJ/86yCvnMjDzIwgciPrJvXbag2WnWht+jE5FEXH2kh8tlHpCsyU H8wGHoB+sqzBjfzUum0dBH9+rrD/HbzArSLiEpdCccttfHfJ8/0FqESV9Vjaikr5bq0p B5u7pl/r0ehnrQczcqN2RIoupIL7QAwfzbf+1uvtzXGpWRIjI3SXKh400QrfQaL3VjRK 9BXRaG4KwXc7mzitYFToaCVCLOiR/wESlvtGUNM6ZqhsnDmuTiygImKQ1j1/+Y7Vr+t4 h1SQ== X-Gm-Message-State: AJIora8i1B+4vTpC7dVsWnqE884Zv+kda8EluIc79hWbnDH14Zg9hvwx Bym/iYZaM3Q6yrE63X374hrRfAQcR7ZeHTvXx3U= X-Google-Smtp-Source: AGRyM1vRMZ46dRibXuIN0U5VW1u+ozUUVUsZnX5mVcO1hFjRi1devs+qwd1C+SUZ35QSBVzRRbKsT9v2e4YuC+/Z338= X-Received: by 2002:a05:6402:1102:b0:43a:9cf7:68a3 with SMTP id u2-20020a056402110200b0043a9cf768a3mr21213905edv.68.1658892442665; Tue, 26 Jul 2022 20:27:22 -0700 (PDT) In-Reply-To: <87sfmo11gm.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237997 Archived-At: Hello Stephen and Lars, Lars Ingebrigtsen wrote: > > Stephen Berman writes: > > > The attached patch prevents the wrong dedenting, but I'm not familiar > > enough with the python.el code to be confident it's the correct fix. > > Perhaps Kobarity has some comments; added to the CCs. I'm not so familiar with this part of python.el, but it looks good to me. How about modifying the ERT to address this issue? diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index 3b10bde23b..3828d4d5aa 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -1108,6 +1108,7 @@ python-indent-dedenters-2 except Exception: if hide_details: logger.exception('Unhandled exception') + # comment else finally: data.free()