From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks Date: Tue, 16 Aug 2022 11:28:40 +0900 Message-ID: References: <87v8ruysep.fsf@secretsauce.net> <87zgh01cqm.fsf@gnus.org> <87sfmr5zi9.fsf@secretsauce.net> <87wnbt3vnq.fsf@secretsauce.net> <878rnyg40d.fsf@gmail.com> <87bkslpgp2.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Augusto Stoffel , 56635@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 16 04:29:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNmKM-0007BY-Jq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 04:29:10 +0200 Original-Received: from localhost ([::1]:51282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNmKL-0007og-DH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 22:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNmKE-0007oB-NI for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 22:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNmKE-00032I-Ef for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 22:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNmKE-0006fJ-2A for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 22:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Aug 2022 02:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56635-submit@debbugs.gnu.org id=B56635.166061694025614 (code B ref 56635); Tue, 16 Aug 2022 02:29:02 +0000 Original-Received: (at 56635) by debbugs.gnu.org; 16 Aug 2022 02:29:00 +0000 Original-Received: from localhost ([127.0.0.1]:44414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNmKC-0006f4-8a for submit@debbugs.gnu.org; Mon, 15 Aug 2022 22:29:00 -0400 Original-Received: from mail-ej1-f48.google.com ([209.85.218.48]:37814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNmKB-0006er-96 for 56635@debbugs.gnu.org; Mon, 15 Aug 2022 22:28:59 -0400 Original-Received: by mail-ej1-f48.google.com with SMTP id kb8so16532371ejc.4 for <56635@debbugs.gnu.org>; Mon, 15 Aug 2022 19:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=nfF3d/Sma9FXB0ZI/E8As+EnL7m91HdIacBhN+eLtH4=; b=Fr+/6vP8eHdXoxrqrK0uc2TNsukbAewvvO5DZSj4F2Z2EtvtDZerNsUnk9hZoQC8jx esIxBpzrnwFBhwp8vjiW3rvvK6T9mzcbOG6YTBvYBgOVcfs9J9/LoagsCJJqyNxiDp0Z WiM2znLtGfMB34YD44KoLPXVlegcmUbikAc3TgDJHiyoWBJGUkW1okEXa73xdZ1YYF6w qgdi0fbouY96T3EQb0CIwv0tHQV17Qc2UM3gzAoyREE4wBkv1wQdPrYsO5MGiMGcbncj 5TlScv5NansDCehqZVHYn3JGJSy0qjK/Rz0MaHYbJtwMMdaNp/drHT8HE6XrJVtqiUS0 SmBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=nfF3d/Sma9FXB0ZI/E8As+EnL7m91HdIacBhN+eLtH4=; b=A0qYRXA54wxnwUsOah/lRlYyzOnwQ8P0gA5wJuRxLFfFoESbuJZd97Qotm4nljIdnR CsYes9FTOtpiuaSvp4057rR2peDSHSHGQ3Sn//n+nU4/MtntQNt3Ace+o6v9rZ2+NNGp dVGhAtMRrZJ0O4Mzvffw+t8ZQAfq+LgajzsNA3CyxIK0sMRKlTXLqcdL12tRXT77+Arz z3BoMWw8V7H8VFhOXm5ACioIV9EuCGA1GomhiPavrzqDM5F7whnvTjITkvCvbIjAQUBc ztg9+v7FKcZLHX5f1Q4/VhT3eI01epl1W6xmqpPcIfivJsSZ6uDr0lQ4Rv2u7UPrzjAM PREg== X-Gm-Message-State: ACgBeo3in7+w4y/lUa3IkS7Aoa1vyG5gTFFM8Ur2YWYnHQkMof8wygYm +vJFXtbtOFeWg+XJiGQY9deT+1kpwq4By+hFVHQ= X-Google-Smtp-Source: AA6agR5ibU7lGd+DMzoXefqt329hhEhXNIgBvKTqJivxTwiD8d6dAO03AKDvZR3lZA9BAnIw+48FUdbMLJlcdHYVh4s= X-Received: by 2002:a17:906:9bc4:b0:730:957f:34b3 with SMTP id de4-20020a1709069bc400b00730957f34b3mr11911908ejc.231.1660616933326; Mon, 15 Aug 2022 19:28:53 -0700 (PDT) In-Reply-To: <87bkslpgp2.fsf@secretsauce.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239859 Archived-At: Dima Kogan wrote: > Thanks for working on this. I'll try it out in a bit. How do you usually > test it? You need the latest source code (master branch) to apply the patches. Here are how to test them: - patch -p1 < fix-56635-hideshow.patch - patch -p1 < fix-56635-python.patch - emacs -Q - M-x load-file "patched python.el" - M-x load-file "patched hideshow.el" - M-x find-file "Python file to test" - M-x hs-minor-mode If you want to load patched files in ~/.emacs, following settings should suffice: (load "/somewhere patched/python.el") (load "/somewhere patched/hideshow.el") As for ERTs, I'm testing them with the following command in the patched source code tree: src/emacs -batch -l ert -l lisp/progmodes/hideshow.el -l lisp/progmodes/python.el -l test/lisp/progmodes/python-tests.el -l test/lisp/progmodes/hideshow-tests.el --eval '(let ((python-tests-shell-interpreter "python3")) (ert-run-tests-batch-and-exit))' I'm looking forward to your feedback. Regards,