unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#24147: emacsclient should pass frame-parameters to tty frames
@ 2016-08-03 23:51 Michael Shields
  2016-08-06 10:06 ` Eli Zaretskii
  2019-06-25 11:58 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 7+ messages in thread
From: Michael Shields @ 2016-08-03 23:51 UTC (permalink / raw)
  To: 24147

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Currently, emacsclient's --frame-parameters argument is silently
ignored when creating frames on a tty.  This prevents emacsclient from
giving the new frame a name.

I've attached a patch that corrects this.

My employer, Google, has an existing contributor license agreement
that covers this change.

[-- Attachment #2: 0001-Pass-frame-parameters-to-server-create-tty-frame.patch --]
[-- Type: application/octet-stream, Size: 1955 bytes --]

From 52afa89b994d73275738e78baf0442b2cd995003 Mon Sep 17 00:00:00 2001
From: Michael Shields <shields@msrl.com>
Date: Wed, 3 Aug 2016 16:17:05 -0700
Subject: [PATCH 1/1] Pass frame-parameters to server-create-tty-frame

This is useful for, at least, naming frames:

  emacsclient -c -F '((name . "foo"))'

* lisp/server.el: Pass frame-parameters when creating frames, even on a
tty.
---
 lisp/server.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/server.el b/lisp/server.el
index e4cf431..9c4b53d 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -792,7 +792,7 @@ This handles splitting the command if it would be bigger than
       (setq prefix "-print-nonl "))
     (server-send-string proc (concat prefix qtext "\n"))))
 
-(defun server-create-tty-frame (tty type proc)
+(defun server-create-tty-frame (tty type proc parameters)
   (unless tty
     (error "Invalid terminal device"))
   (unless type
@@ -825,7 +825,8 @@ This handles splitting the command if it would be bigger than
                          ;; envvars, and then to change the
                          ;; C functions `child_setup' and
                          ;; `getenv_internal' accordingly.
-                         (environment . ,(process-get proc 'env)))))))
+                         (environment . ,(process-get proc 'env))
+                         ,@parameters)))))
 
     ;; ttys don't use the `display' parameter, but callproc.c does to set
     ;; the DISPLAY environment on subprocesses.
@@ -1241,7 +1242,8 @@ The following commands are accepted by the client:
 						       frame-parameters))
 		   ;; When resuming on a tty, tty-name is nil.
 		   (tty-name
-		    (server-create-tty-frame tty-name tty-type proc))))
+		    (server-create-tty-frame tty-name tty-type proc
+                                             frame-parameters))))
 
             (process-put
              proc 'continuation
-- 
2.8.0.rc3.226.g39d4020


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-25 11:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-03 23:51 bug#24147: emacsclient should pass frame-parameters to tty frames Michael Shields
2016-08-06 10:06 ` Eli Zaretskii
2016-08-24 15:08   ` Michael Shields
2016-08-24 15:15     ` Eli Zaretskii
2016-08-24 15:20       ` Michael Shields
2016-08-24 15:57         ` Eli Zaretskii
2019-06-25 11:58 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).