From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lynn Winebarger Newsgroups: gmane.emacs.bugs Subject: bug#57035: Support for site-load.el in native-compile dumping Date: Sun, 7 Aug 2022 09:16:11 -0400 Message-ID: References: <878ro02owz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007c40d005e5a6812a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18999"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57035@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 07 15:17:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKg9V-0004jY-Ed for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Aug 2022 15:17:09 +0200 Original-Received: from localhost ([::1]:60564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKg9U-0007Vg-FW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Aug 2022 09:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKg9O-0007VY-HL for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2022 09:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKg9O-0006BQ-8x for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2022 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oKg9O-0001Vn-4I for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2022 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lynn Winebarger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Aug 2022 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57035 X-GNU-PR-Package: emacs Original-Received: via spool by 57035-submit@debbugs.gnu.org id=B57035.16598781925770 (code B ref 57035); Sun, 07 Aug 2022 13:17:02 +0000 Original-Received: (at 57035) by debbugs.gnu.org; 7 Aug 2022 13:16:32 +0000 Original-Received: from localhost ([127.0.0.1]:36224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKg8t-0001Uy-SF for submit@debbugs.gnu.org; Sun, 07 Aug 2022 09:16:32 -0400 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:56152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKg8r-0001Ui-7V for 57035@debbugs.gnu.org; Sun, 07 Aug 2022 09:16:31 -0400 Original-Received: by mail-pj1-f47.google.com with SMTP id a8so6572079pjg.5 for <57035@debbugs.gnu.org>; Sun, 07 Aug 2022 06:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=EiqgTV7kynsmhhVVdooeoSxjUnihcw/UvjM1sH6xsDQ=; b=kD1EbDsMSgmIAzm+kOduR5zjNlyux7RZNM0KXNAVTPR54Czf3DjyFF3ZdKyQ2wt0uw POg/8no0H7s9CgDfH8bFItvpsssg8GE9Z4bFTHdabU9UzSn+4uJDvR3g7v0OGECo9Jix jflYDx/T1g/k3UH6DO6/ver2Ep9cyJy4xmM+i6DD0VU1vevTWcx/IAxdXNtREVtJsY2t FRO4m4pPMkebv8xlgnHpWGYCM7f3QD2gOxgIZk1nOIV47vl7xQuhca2T4OHrhSn/HHCm B4id+0tdOzRT38lc9UCXDsMbN19cYiA09z097RTD3ccwishbJRelbDaPMVGo7yGEg/ih zigA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=EiqgTV7kynsmhhVVdooeoSxjUnihcw/UvjM1sH6xsDQ=; b=6ZdhQ7dMgwtcNfB8WpLz8RMFTQCuus2eu+/QYfTKsSG18XLdEO/MvACxSyjDUOZJnA VNsi9mr7UApDjPPJ0JhZLhzVAUvqam+8x6vdMTm0hdsxVd5nEfrHNG4Bx40sGLPToELI Bgpn5bwEwwTEKx3etPiH3y0FMHPt4T/8kWA6vewzzX2tH9eyguJD6MALfsZRv1yYvv6G XWDxIb6Yw4Sb0nJZPCdU8a1NUIzrs9L/bMwbpLC49dW1T5BWkERSP+Dhi4WeonVtyCeC eOlYgI75DDa4zxW8nldoDIbU46V915gzKGWWg8PUxvqZAK1jv3wqr4nBddvZgzR6h73P TQVA== X-Gm-Message-State: ACgBeo0gaz2w0UsvSVEC7sr2btS0NJBKCCZR9caVpebYN8WmfIav5cFE UIukxnhr9Xi4KS9bWgctHyakztaUyvM3ttTj440= X-Google-Smtp-Source: AA6agR7pU+ubT4tCH0AxjqujI7HF4iC5Q5uqXIHguuXeX29KXxFsaX/JfbGy1bUCzT84cUH6GgOOVTJ8niDGBOQblxs= X-Received: by 2002:a17:90a:bc1:b0:1f2:435f:94bc with SMTP id x1-20020a17090a0bc100b001f2435f94bcmr16690591pjd.5.1659878183287; Sun, 07 Aug 2022 06:16:23 -0700 (PDT) In-Reply-To: <878ro02owz.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239058 Archived-At: --0000000000007c40d005e5a6812a Content-Type: text/plain; charset="UTF-8" On Sun, Aug 7, 2022, 8:55 AM Lars Ingebrigtsen wrote: > Lynn Winebarger writes: > > > +. Add a flag variable to turn off the docstring hack in lead.c once > > loadup has been processed (or eliminate the hack entirely). > > The hack has been removed on the trunk. > > > I think that covers all the issues I dealt with. If my employer > > allows I can donate code to fix the purecopy issues in versions prior > > to 29. > > As I think Eli has said before, changes in this area are not going to be > backported to earlier Emacs versions, so you should just concentrate on > Emacs 29. The code fixing the limitations and bugs of purecopy (at least the ones triggered while dumping a large variety of loaded libraries) has already been implemented for 28.1 on my employer's systems. If they are willing to donate it (less than 100 lines of C), I'll post a patch. Even if it won't be incorporated in the Emacs distribution, Linux vendors who are conservative in the version of Emacs they package may choose to use it in their builds. Aside from supporting bool vectors and strings with text properties in pure space, it fixes a couple of fatal bugs that can be triggered while dumping - one segfault and one runaway allocation. Lynn --0000000000007c40d005e5a6812a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Aug 7, 2022, 8:55 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Lynn Winebarger <owinebar@gmail.com> writes:
> +. Add a flag variable to turn off the docstring hack in lead.c once > loadup has been processed (or eliminate the hack entirely).

The hack has been removed on the trunk.

> I think that covers all the issues I dealt with.=C2=A0 If my employer<= br> > allows I can donate code to fix the purecopy issues in versions prior<= br> > to 29.

As I think Eli has said before, changes in this area are not going to be backported to earlier Emacs versions, so you should just concentrate on
Emacs 29.

The code fixing the limitations and bugs of purecopy (at least the one= s triggered while dumping a large variety of loaded libraries) has already = been implemented for 28.1 on my employer's systems.=C2=A0 If they are w= illing to donate it (less than 100 lines of C), I'll post a patch.=C2= =A0 Even if it won't be incorporated in the Emacs distribution, Linux v= endors who are conservative in the version of Emacs they package may choose= to use it in their builds.=C2=A0 Aside from supporting bool vectors and st= rings with text properties in pure space, it fixes a couple of fatal bugs t= hat can be triggered while dumping - one segfault and one runaway allocatio= n.

Lynn


--0000000000007c40d005e5a6812a--