From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.bugs Subject: bug#31760: 26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists Date: Fri, 15 Jun 2018 19:54:27 +0200 Message-ID: References: <87k1r972fp.wl-bordjukov@gmail.com> <87po11i0he.fsf@gmail.com> <83d8f202-8842-56fe-0350-5f2fa9a01d67@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e5ed91056eb1e8b6" X-Trace: blaine.gmane.org 1529085291 24190 195.159.176.226 (15 Jun 2018 17:54:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Jun 2018 17:54:51 +0000 (UTC) Cc: Petko Bordjukov , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 31760@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 15 19:54:47 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTsvu-0006DH-Md for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jun 2018 19:54:46 +0200 Original-Received: from localhost ([::1]:48640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTsy1-0007xA-PK for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jun 2018 13:56:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTswD-0006ZQ-Sv for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 13:55:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTswA-0003XU-Pa for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 13:55:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42742) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTswA-0003XN-Ip for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 13:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTswA-0006xP-89 for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 13:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bozhidar Batsov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jun 2018 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31760 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31760-submit@debbugs.gnu.org id=B31760.152908528826721 (code B ref 31760); Fri, 15 Jun 2018 17:55:02 +0000 Original-Received: (at 31760) by debbugs.gnu.org; 15 Jun 2018 17:54:48 +0000 Original-Received: from localhost ([127.0.0.1]:50639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTsvu-0006ws-2k for submit@debbugs.gnu.org; Fri, 15 Jun 2018 13:54:48 -0400 Original-Received: from mail-qt0-f179.google.com ([209.85.216.179]:46525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTsvs-0006wg-RP for 31760@debbugs.gnu.org; Fri, 15 Jun 2018 13:54:45 -0400 Original-Received: by mail-qt0-f179.google.com with SMTP id h5-v6so9775665qtm.13 for <31760@debbugs.gnu.org>; Fri, 15 Jun 2018 10:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=batsov-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=usl1iAft3lkCEv/h/EI8ANWLkG4QvqG0qVFOp2IRXys=; b=OoEgdjFBfsQISxbIyNLaAyi8wsgDL4e15Lo+DTepwHrlBUU2V+sNNlRH+NktFvKYWQ Gs3sOolA3I91Lp5Lgu0GbEdAGAhuEM/ej2UfNKp6UEekHRcOb2IO2bSnxRBqVBkI9A7H yj/0ORv2gZFdFfyJ9AxfLHjhtPQM/JVLkcY7diy/DLAZM2XhQ7pc78v7dGSffH85qY9l Zzt3aiOcD5WYmgSBsLSDF4QzZmT+3Iyo9mrfWl3ltZ79YKa+exh4RiFwGBd4wfI6JYVC Z7zUeLxIhWPcZCHTzfZUMAMWpUIL14vG/K9of/5ao2wfRSWXDZO198ZblNUMcNDMidcf 4Iwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=usl1iAft3lkCEv/h/EI8ANWLkG4QvqG0qVFOp2IRXys=; b=Dx2rxR5G7GNexQ5mdzLbQ2S9njWW6tHErQTOoPQFGJRZawX8slZ/Rnn5SW81sEPieK tFqPwS6hH920Jowr9CuDXBseT8tHmKPIfr6oPMXiPiMkwacXY5RnwsZk8/HP/l+aSi4q XivM1HLM7FOiGoIpGsuIsSstL3tXJ20ErNSspNC6HRk8Gfi8CY0VaE27JBxazKjP2VIa kSZ7zl1bEtofaqJnT4tExdXUW8XTJ8PgqzHryESCfqrFadfOAj3iO7W9Fjk7TJAeXFbV OQwsKPJQ6VdQP43cWOQIlDM3ptIcn15zRMxRjDr76ZyuF5xzCreFcgLRgx7Z/xQu4Ieq yM0Q== X-Gm-Message-State: APt69E3W0of3xMse+5v+97kvlKkOky54Nb+CK7X+3zRCZKRpVCHnE+Vq 0WaRFD1HOhAYAxiqj2bxgDmRDtbECKLgtu/UZxg= X-Google-Smtp-Source: ADUXVKLJ/V7wbKGeQGPc6ZqgU8eAQ/nJGEAWUqaMhRpEh2LfHtwO3kAr4GYUp1BL5brxqOjZh9mAsTjubhBKlP8Zo1w= X-Received: by 2002:ac8:1bee:: with SMTP id m43-v6mr2502576qtk.339.1529085279201; Fri, 15 Jun 2018 10:54:39 -0700 (PDT) In-Reply-To: <83d8f202-8842-56fe-0350-5f2fa9a01d67@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147465 Archived-At: --000000000000e5ed91056eb1e8b6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Why would have RuboCop installed and not what to use it? I think the check is perfectly fine in its current state, especially given the fact that you can simply disable RuboCop with the defcustom mentioned. > Since most if not all of the warnings that >> Rubocop generates are not raised by Ruby I consider them not adopted by >> the Ruby community by default. You know this thing is configurable, right? ;-) The vast majority of checks are actually pretty much community standard - Ruby produces only a minimal amount of lint warnings, RuboCop has extended linting but also a lot of code style checking functionality. I don't really want us to check for RuboCop config files (those are hierarchical and won't necessarily be in the root of your current project anyways) - I think the current check + config is sufficient. On Fri, 15 Jun 2018 at 17:16, Dmitry Gutov wrote: > On 6/8/18 9:42 PM, Jo=C3=A3o T=C3=A1vora wrote: > > Petko Bordjukov writes: > > > >> Emacs 26.1 enables flymake-rubocop by default if the rubocop executabl= e > >> is present in the system. Since most if not all of the warnings that > >> Rubocop generates are not raised by Ruby I consider them not adopted b= y > >> the Ruby community by default. Based on that, I propose that either > >> using Rubocop by default is turned off, or at least a more inteligent > >> per-project Rubocop detection scheme is implemented. > >> > > Paging Dmitry :-) > > So... First of all, there is the variable > ruby-flymake-use-rubocop-if-available, to satisfy the individual > preference to turn Rubocop off. > > Second, what kind of per-project detection scheme? I suppose we can > abort if no ruby-rubocop-config file is found. That would certainly work > for me, but would maybe conflict with the general usage of Rubocop out > there (but probably not). > > Maybe Bozhidar has something to say on this? > --000000000000e5ed91056eb1e8b6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Why would have RuboCop installed and not what to use it?
I think the check is perfectly fine in its current state,= especially given the fact that you can simply disable RuboCop with the def= custom mentioned.

>=C2=A0Sin= ce most if not all of the warnings that
>> Rubocop ge= nerates are not raised by Ruby I consider them not adopted by
>> the Ruby community by default.

You know this thing is configu= rable, right? ;-) The vast majority of checks are actually pretty much comm= unity standard - Ruby produces only a minimal amount of lint warnings, Rubo= Cop has extended linting but also a lot of code style checking functionalit= y.=C2=A0

I don't really want us to check for RuboCop config files (th= ose are hierarchical and won't necessarily be in the root of your curre= nt project anyways) - I think the current check + config is sufficient.=C2= =A0

On Fr= i, 15 Jun 2018 at 17:16, Dmitry Gutov <dgutov@yandex.ru> wrote:
= On 6/8/18 9:42 PM, Jo=C3=A3o T=C3=A1vora wrote:
> Petko Bordjukov <bordjukov@gmail.com> writes:
>
>> Emacs 26.1 enables flymake-rubocop by default if the rubocop execu= table
>> is present in the system. Since most if not all of the warnings th= at
>> Rubocop generates are not raised by Ruby I consider them not adopt= ed by
>> the Ruby community by default. Based on that, I propose that eithe= r
>> using Rubocop by default is turned off, or at least a more intelig= ent
>> per-project Rubocop detection scheme is implemented.
>>
> Paging Dmitry :-)

So... First of all, there is the variable
ruby-flymake-use-rubocop-if-available, to satisfy the individual
preference to turn Rubocop off.

Second, what kind of per-project detection scheme? I suppose we can
abort if no ruby-rubocop-config file is found. That would certainly work for me, but would maybe conflict with the general usage of Rubocop out
there (but probably not).

Maybe Bozhidar has something to say on this?
--000000000000e5ed91056eb1e8b6--