From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gustavo Barros Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sun, 30 Oct 2022 21:23:18 -0300 Message-ID: References: <58149.1667174501@alto> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27386"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 58721@debbugs.gnu.org To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 31 01:24:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opIbH-0006w4-3G for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Oct 2022 01:24:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opIb0-0007dR-Tk; Sun, 30 Oct 2022 20:24:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opIaz-0007dK-Dp for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 20:24:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opIaw-0005E0-Ca for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 20:24:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opIaw-0004dI-09 for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 20:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gustavo Barros Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 00:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166717582017781 (code B ref 58721); Mon, 31 Oct 2022 00:24:01 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 31 Oct 2022 00:23:40 +0000 Original-Received: from localhost ([127.0.0.1]:39259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opIaZ-0004ci-Vx for submit@debbugs.gnu.org; Sun, 30 Oct 2022 20:23:40 -0400 Original-Received: from mail-pf1-f173.google.com ([209.85.210.173]:35611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opIaX-0004cS-9c for 58721@debbugs.gnu.org; Sun, 30 Oct 2022 20:23:38 -0400 Original-Received: by mail-pf1-f173.google.com with SMTP id k15so1282276pfg.2 for <58721@debbugs.gnu.org>; Sun, 30 Oct 2022 17:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YxnVqzYkFkYs4RXE7N3tPH+e3Oi/K8Srvc6zNoGXiTA=; b=nH8FTuzmjRdQx8asWFO8eqbtevBc07xqje7SaOnQuxLxCjU9FDm4yS0lQ+iSnYq6mI yeoH5RbIVJeD7Ya3JUFIRf7xWZAK40f02Z8fbqqUVwgJNC6IfrD7MAQniu+Im4ecebRf 7g5Y924kqmGleFde3laLfBIowDujh/u8z7wOKJhluDq8pgQNqVeschvTML931/+gvHlr +d0aJOG+T3CkgqstlGBGXhXlMfyoR+i4yTh9xorvo2pLEa+nGYC4S5nwR5XbvLkKiS7/ toG/lT9hXjLkYrD2mv33ISZZ2v39SlJBHnCbW33cL2FLEuT8OdsBWDJ7nwh0SIpA/4m1 u6nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YxnVqzYkFkYs4RXE7N3tPH+e3Oi/K8Srvc6zNoGXiTA=; b=1RQDrhGQaxgILvmJaaIKqG6TeUJFQR39sWkFf/oMAdmaVhZivD3uXaXGnhI7r4WN/O S4ymunOOmuXMVt1G/s+BcBMw8J/jOGbZ83N+pRLDOW55JMX/T8/y5YYfVCQvNMr2y9tH buc2ioQKiQ9yH1Jfa+x/3sQWU3UdY+j2tFsPGcF6NsLK532Qh9Dz+irGzGrOs/pgPKC8 5ZVFWewrgTI3m2uLxVDf+HOmyMIRMwW7q8Lz9dG5eyJB9aS1NM7MeWFvJ83mVLmFPTT+ k/haCX/mm51oJ2gSPMhbKYzidhvpKA/aX33LxGEglbp4C6mugit1WN/eIETdnhO+apja wmtA== X-Gm-Message-State: ACrzQf2QJiOhZP52TRIYUWWKQrlbpB3M5tZAYN3lL/jV0MIhHWuJjjS0 Grpepoamxlt/I3jdT5+p1zmS9O1E4kMeXbZX/FE= X-Google-Smtp-Source: AMsMyM7EWRZSdInud1cmOc+vHzDtr+BYyO0USf3JV5t59Nc4PkQfcZNNQFKEP2uiEVc/3ZljnxhtjuA46qsU4x9VQKA= X-Received: by 2002:a05:6a00:1a44:b0:52a:ecd5:bbef with SMTP id h4-20020a056a001a4400b0052aecd5bbefmr11341594pfv.28.1667175810506; Sun, 30 Oct 2022 17:23:30 -0700 (PDT) In-Reply-To: <58149.1667174501@alto> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246659 Archived-At: On Sun, 30 Oct 2022 at 21:01, Mike Kupfer wrote: > Good point, thanks. I think this points out a pre-existing issue with > move-file-to-trash, in that the code to create a unique trash name will > create a directory, rather than a file. I agree, I also think that there was a pre-existing inconsistency there, but `rename-file` would cover it up later on. But trying to do it manually, complicates things in this regard as well. > I agree that it's an inconsistency in the behavior of rename-file. If > the thing being renamed is a file, the target gets replaced, whether or > not we're crossing filesystems. But if it's a directory, the target > gets replaced if it's in the same filesystem, but it's an error if the > target is in a different filesystem. If I understand Eli's concern, > it's a question of whether making the behavior more consistent is worth > the risk that it would break existing code--code that could assume the > current behavior. I understand that concern too. But we don't even understand well (as far as I can see) why it fails when crossing filesystems, and are already rushing to a workaround. I just offered some respectful resistance. And if, after all, the decision is not to touch `rename-file' because it's risky, so that a workaround is really what is intended, I'll get that. > I'd like to resolve the symlink behavior before pushing any fix. But > I've been feeling increasingly unwell as the day has progressed, so I > think I'll stop work on this bug until I'm feeling better. Get well soon! :-)