From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gustavo Barros Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Mon, 31 Oct 2022 10:16:47 -0300 Message-ID: References: <58149.1667174501@alto> <83y1swdupn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32716"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721@debbugs.gnu.org, Mike Kupfer To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 31 14:19:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opUh8-0008Nj-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Oct 2022 14:19:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opUg1-0006YV-Dp; Mon, 31 Oct 2022 09:18:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opUfy-0006NE-MT for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 09:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opUfy-0004cB-CZ for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 09:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opUfy-0007rx-6M for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 09:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gustavo Barros Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166722222830187 (code B ref 58721); Mon, 31 Oct 2022 13:18:02 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 31 Oct 2022 13:17:08 +0000 Original-Received: from localhost ([127.0.0.1]:39768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opUf5-0007qp-QP for submit@debbugs.gnu.org; Mon, 31 Oct 2022 09:17:08 -0400 Original-Received: from mail-pj1-f51.google.com ([209.85.216.51]:43990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opUf3-0007qH-H4 for 58721@debbugs.gnu.org; Mon, 31 Oct 2022 09:17:06 -0400 Original-Received: by mail-pj1-f51.google.com with SMTP id d13-20020a17090a3b0d00b00213519dfe4aso10262904pjc.2 for <58721@debbugs.gnu.org>; Mon, 31 Oct 2022 06:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RbgbqhnIQXglE5jHUWI5E/HN7dBMPHqsUn0iZWu5JVk=; b=YsyIzrFhSCiy9YLlK/fwzeEB2MrFIymyWuY68rb7lOrdFAqKKzj/oP2L5XCZHg9H8L hr+S3y6nbO79RNlf8pcT6SQfabjmLT1gVp7bDI2kXRPck+BWt1U91nSMmBzaaK9HCmrV tM8b/QLCnaVeEyfAkIqClSZFXdAPKvL2fAJMDxB+qufDG9nZQzn4tsSqqbXnnoh0CvJ0 i2/zO6cTtraobE77XA7wTzfSHdAIE56O1m1pCJ/80THNgaK3C+QavFaOr/q27vbkUrB+ taA8ufLnv5Ddy8q9gYMY2/I0XQqMlMhDlqJ4B/mCVYhVHiUuF2xhGueQlnpTxYa9tcpg Fmzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RbgbqhnIQXglE5jHUWI5E/HN7dBMPHqsUn0iZWu5JVk=; b=jC17nBIuWQ0r8DnnORw+NR7gG6j6JWt+LnFD2wV4Ikhsy5AiZ5xqOhDsFyzyIQU/mt ZaPZxSYvaLLjqC4jqkYGkZMqh8Sc+btnCp93Xxnu8d9EbE8cCysUsuBqFjbcZPdAr9TB dBL0W36/iKc5hF++3Hbq9rH3BihN0K/tUer5SQ0GqodQk4VOSYuwmt+P6IfteQXTnY4H rq8++f8Ep5Ad1wZ8wdRbbMif+FuzAL6S1XmUf8KGybR2Q7uhQFNPZPKO6MTKO2jfr5qs zFTlRDSbGlVWaQg0LvAQKa8TVDnpiH2govLPcqGK11sMiot0FZpylChI5NiRoVx/F6b/ Am5Q== X-Gm-Message-State: ACrzQf1l7vFC5MwPZwL63wzZhi1f6LeHYhhiWa0QkjWH9lBjlkIcyBz+ cXVcg10jKAzbivKT0ZQJtRnBMbEplOUwrbZKB0c= X-Google-Smtp-Source: AMsMyM5p1l2O47g6QF+L3kOtoHWic0dzPox4/mXInuEcsTw6n0pPqzXebA9ZzLX3XJF9azgjSf13MTMPcBqx5Wd8vA4= X-Received: by 2002:a17:90a:8a8c:b0:213:c06c:7003 with SMTP id x12-20020a17090a8a8c00b00213c06c7003mr10737178pjn.147.1667222219576; Mon, 31 Oct 2022 06:16:59 -0700 (PDT) In-Reply-To: <83y1swdupn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246681 Archived-At: On Mon, 31 Oct 2022 at 09:49, Eli Zaretskii wrote: > What is the expected semantics of moving a symlink to trashcan? Is it > supposed to move the symlink or its target? (I'd think it's the > former, but maybe my instincts are wrong.) If the expectations are > that the symlink is moved, then all we need to do is to treat symlinks > as regular files, by augmenting file-directory-p not to dupe us. I'm not sure either, but my instincts are the same as yours. If that's any reference, I just tested here, and that's what "gio trash" does (moves the symlink, not the target). > I'm okay with filing another bug report about rename-file, and > discussing this there. But that's a separate issue, and fix of this > bug should not depend on that. Understood.