From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gauthier =?UTF-8?Q?=C3=96stervall?= Newsgroups: gmane.emacs.bugs Subject: bug#31754: 25.1; etags output lacks info for making xref more useful Date: Tue, 12 Jun 2018 16:49:44 +0200 Message-ID: References: <83y3flp672.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1528814963 32558 195.159.176.226 (12 Jun 2018 14:49:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Jun 2018 14:49:23 +0000 (UTC) Cc: 31754@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 12 16:49:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSkbk-0008GX-5l for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 16:49:16 +0200 Original-Received: from localhost ([::1]:56019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSkdr-0004n5-BM for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 10:51:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSkdU-0004cs-OX for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 10:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSkdS-0007JV-3B for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 10:51:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSkdR-0007IW-Vn for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 10:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSkdR-0002K0-Ny for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 10:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gauthier =?UTF-8?Q?=C3=96stervall?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jun 2018 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31754-submit@debbugs.gnu.org id=B31754.15288150128861 (code B ref 31754); Tue, 12 Jun 2018 14:51:01 +0000 Original-Received: (at 31754) by debbugs.gnu.org; 12 Jun 2018 14:50:12 +0000 Original-Received: from localhost ([127.0.0.1]:45145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSkcd-0002Ir-TB for submit@debbugs.gnu.org; Tue, 12 Jun 2018 10:50:12 -0400 Original-Received: from mail-qt0-f180.google.com ([209.85.216.180]:40514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSkcc-0002Id-AP for 31754@debbugs.gnu.org; Tue, 12 Jun 2018 10:50:10 -0400 Original-Received: by mail-qt0-f180.google.com with SMTP id q6-v6so23925458qtn.7 for <31754@debbugs.gnu.org>; Tue, 12 Jun 2018 07:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ostervall-se.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=12eGJCMZNOsGMEUtwxpiLbSOU0AoS+3F8hdeJ9KibGs=; b=cn5tJhrajciI1HYNk7mQOcXrMxcSmglnc6TmxYEOzDJybAv57CdE2w9GX6YraMB7lR +oMu7Ctcw69RzRPGqhwUXzJT+3/tOioYuuIZfoFhybFUjjX5HaZo8/wTPhd+i63Pzkax XmWJdIvNE1o4p6R1HeZ/Ek98COigvGJQmy94I+3rJXHFDQeSX4QZfvTjHUYJ6K51qiDN F7VRpqElnxESuVVSa6WQdBJbxDpPAAM+roVdz0ysy0HXAKdxaX+QWcdTQ0ZS1ZrHrv4K dTRZ06bgI/qjrHNpMyPiELto0KlLM7T5K1hdxDwQ21aUfoswNd6hMFQd/CoatZBOsVWB 0QPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=12eGJCMZNOsGMEUtwxpiLbSOU0AoS+3F8hdeJ9KibGs=; b=GjxWLZjDNbmi13qjRMiq0YaeHrW8nRouB9XMnJMcuBVMiMy87pJ4Tw7MbOT/JAKvlG BZEDBDsa0vbs/QCTEcf61abFkcJ4kI7yuWybZhOmHbcnnmWTFFeo75FHQko2CNE1mnFf QaLh1pLXINVot/MwTV28xpmgibAjBpG4OOC2rJeu8cJBbhCOYs8c5nkdUYZHG2v3HRVL Q6YmvucXYJBOHb2MPqUBNcnyPgC/tTXjvxIxbDXPDne1aGUEffh0MEnc6aj9LsrCcpjg qhARabTT3ABgzjX5aeb38xrKSWnuqUHicghKlFmtNJAnKmDs3g14uxKcfjVKEEsIvi5R RcCQ== X-Gm-Message-State: APt69E2MIO7rETILaUt1XKVdNezNGxBLcrsWooFE0f61aU6F2AtnDTOP WKt++BEA59nQ63uCS2nqyVjux/5rHxXmmX9MVaTTjQ== X-Google-Smtp-Source: ADUXVKKe0rHZ3IzhhQIWZ3IznTXSHQ0cZNu8sGRF+OzTLNlJOtsmW1FBiJQygLb289nE/kwLMOVxIWwmOtPmKFY1Muc= X-Received: by 2002:a0c:e74c:: with SMTP id g12-v6mr746483qvn.203.1528815004646; Tue, 12 Jun 2018 07:50:04 -0700 (PDT) Original-Received: by 2002:ac8:391:0:0:0:0:0 with HTTP; Tue, 12 Jun 2018 07:49:44 -0700 (PDT) X-Originating-IP: [176.10.221.242] In-Reply-To: <83y3flp672.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147329 Archived-At: On Mon, Jun 11, 2018 at 7:46 PM, Eli Zaretskii wrote: > severity 31754 wishlist > thanks > >> From: Gauthier =C3=96stervall >> Date: Fri, 8 Jun 2018 11:21:54 +0200 >> This could be more helpful, the suggestions are not distinguishable. I >> suggest including at least the whole source row. > > I originally thought that etags should be extended to include the > while line in TAGS, at least as an option, but the more I think about > this, the less I'm convinced thats the right approach. For starters, > no one said that line will show enough to tell the difference. For > example, imagine this code: > > int my_identifier(int a, > int b) { > return 2 * a + b; > } > > int my_identifier(int a, > int b, double fac) { > return fac*a + b; > } > Agreed, showing the whole row is not enough. > So now I think that perhaps we should leave etags alone, and instead > add a feature to xref whereby the lines in the XREF buffer will show > in a tooltip the full signature of the function. I am not a fan of tooltips, to be honest. I guess I'm not alone here. I like to visually grep all the suggestions then go to the right one fast, instead of needing to put my cursor on every row before I can see their tooltip. In order to show the full signature, XREF would need to parse the source files. etags is already parsing files anyway, I can't see why not let it save whole signatures to TAGS?