From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24358: 25.1.50; re-search-forward errors with "Variable binding depth exceeds max-specpdl-size" Date: Sun, 23 Oct 2016 14:14:59 -0400 Message-ID: References: <87eg3rvtsf.fsf@users.sourceforge.net> <83k2dihpm9.fsf@gnu.org> <8760p2wzgj.fsf@users.sourceforge.net> <838ttyhhzu.fsf@gnu.org> <871szqwu51.fsf@users.sourceforge.net> <831szqhbc2.fsf@gnu.org> <87h98hujcx.fsf@users.sourceforge.net> <831szkahyz.fsf@gnu.org> <87eg3jvfj6.fsf@users.sourceforge.net> <8360ov8lbu.fsf@gnu.org> <877f95uj66.fsf@users.sourceforge.net> <83zim0vn1t.fsf@gnu.org> <874m48v7wj.fsf@users.sourceforge.net> <83insov1zr.fsf@gnu.org> <87zilztzd5.fsf@users.sourceforge.net> <83oa2ftnvp.fsf@gnu.org> <87wph2ts1a.fsf@users.sourceforge.net> <83oa2erx0k.fsf@gnu.org> <87lgxht8hp.fsf@users.sourceforge.net> <871sz8kq2v.fsf@gmail.com> <87shroroh8.fsf@users.sourceforge.net> <838ttfpnxt.fsf@gnu.org> <83vawjo21l.fsf@gnu.org> <83bmybnopx.fsf@gnu.org> <8360ojnk0n.fsf@gnu.org> <83twc3m198.fsf@gnu.org> <83pomrlz27.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1477246705 32194 195.159.176.226 (23 Oct 2016 18:18:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Oct 2016 18:18:25 +0000 (UTC) Cc: Sam Halliday , 24358@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 23 20:18:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byNL8-0004Cu-PC for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 20:17:46 +0200 Original-Received: from localhost ([::1]:41973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byNLB-0003tW-5R for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 14:17:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byNJV-00032P-4A for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byNJR-0008B0-V3 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:16:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34245) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1byNJR-0008Au-RX for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1byNJR-0006My-M8 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2016 18:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 24358-submit@debbugs.gnu.org id=B24358.147724650724416 (code B ref 24358); Sun, 23 Oct 2016 18:16:01 +0000 Original-Received: (at 24358) by debbugs.gnu.org; 23 Oct 2016 18:15:07 +0000 Original-Received: from localhost ([127.0.0.1]:49638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byNIZ-0006Lk-9J for submit@debbugs.gnu.org; Sun, 23 Oct 2016 14:15:07 -0400 Original-Received: from mail-yw0-f175.google.com ([209.85.161.175]:35338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byNIX-0006Kz-K0 for 24358@debbugs.gnu.org; Sun, 23 Oct 2016 14:15:05 -0400 Original-Received: by mail-yw0-f175.google.com with SMTP id t193so140902851ywc.2 for <24358@debbugs.gnu.org>; Sun, 23 Oct 2016 11:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jDQl56eYl96LCAoxeKepZIF8rYTRCC8OFp1KAJlh+O8=; b=oIMgalrSUJhnWRxwJLFpDDqm7vL+T47xH4Xi5gO9f3ezOjHr9x2hNtkfZeA9K42SmY ncSB6q+KiDqbaadIqjqzO8J+dJPfvw8UNaG3Mfuh4JS/SnkGfnv1yi9W/lkNFGG0CxDG 61mbZjjo/kq8ut7aq6Ekv6P4hH6G3LRyAtFUwgQlodnCv/5WLEE59qc01j1MjIEatW4d AUQ8OfsTVQMkD+oqrcAchk0tbE0qqhFP5e2atE5rhk3r8ZQl29jF9c2WmHT3B6mudp8t NvCeQzPg99Q1UqYr8rmrGXY0UUn/rsJP++bn34MUWLMx9znEfE7crIx8d3I8y/bgu/20 MXSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jDQl56eYl96LCAoxeKepZIF8rYTRCC8OFp1KAJlh+O8=; b=dZY7LU9UYLG6J1tQvCzXq16msXTlkLXia2LGuEeIJNcIq77yUt1G7RIhq1PVcrYciS LlM8rI51PYww8RU1W3qP4/zf9vYB235sQ0LGWNfORQs4ujxfUjFz3LHDG3D+Oa7XWlx8 Vu7axAvh2Wo7xTRchG3i+4xV7zAjnhZSlArWzWngGqx6Y+xgEFAGS8eB5QrDXPIrjy5f uBdUQ4jSMsh5as8g+SoYNa7/IbNxW4uAm0SIq9wQDROIjeTcXICfMz3NhMr8frgN9O4C HST0hPM95wVKofCsiXnA4l5ArvgTfk6rvtxBzcYWbwfYoHP8uAGFMTdb4qmjF0nidokx oHhQ== X-Gm-Message-State: AA6/9Rn3SCU8RIPU6F4SBqXsQcCCRykoJ+Lz/Hi58BSfYi5FRCHyly2mvFJDdkPLEbgWj5HmUb2aTMxi3V/U5A== X-Received: by 10.202.207.151 with SMTP id f145mr18218577oig.45.1477246500273; Sun, 23 Oct 2016 11:15:00 -0700 (PDT) Original-Received: by 10.157.29.239 with HTTP; Sun, 23 Oct 2016 11:14:59 -0700 (PDT) In-Reply-To: <83pomrlz27.fsf@gnu.org> X-Google-Sender-Auth: vDgdhsJFUA_lllBRYECcZuuJLmI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124925 Archived-At: On Sun, Oct 23, 2016 at 2:06 PM, Eli Zaretskii wrote: > Noam, I think we need these two changes, because otherwise looping > more than once in search_buffer will fail to update the pointers > passed to re_search_2, if buffer text was relocated inside > re_search_2. > > Do you agree? Ack, yes! Missing the update to base was a total thinko on my part. > > diff --git a/src/search.c b/src/search.c > index ec5a1d7..5c04916 100644 > --- a/src/search.c > +++ b/src/search.c > @@ -1233,6 +1233,8 @@ search_buffer (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, > ? &search_regs : &search_regs_1), > /* Don't allow match past current point */ > pos_byte - BEGV_BYTE); > + /* Update 'base' due to possible relocation inside re_search_2. */ > + base = current_buffer->text->beg; > if (val == -2) > { > matcher_overflow (); > @@ -1279,6 +1281,8 @@ search_buffer (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, > (NILP (Vinhibit_changing_match_data) > ? &search_regs : &search_regs_1), > lim_byte - BEGV_BYTE); > + /* Update 'base' due to possible relocation inside re_search_2. */ > + base = current_buffer->text->beg; > if (val == -2) > { > matcher_overflow ();