From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#5845: load-library vs. list-load-path-shadows Date: Tue, 16 Jan 2018 16:32:11 -0500 Message-ID: References: <8162aa6c-e00a-199b-3572-e3e0a7d4cad7@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a11422bbab33d030562eb76c9" X-Trace: blaine.gmane.org 1516138376 14036 195.159.176.226 (16 Jan 2018 21:32:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Jan 2018 21:32:56 +0000 (UTC) Cc: 5845@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 16 22:32:52 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebYqf-0003Ar-Os for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jan 2018 22:32:49 +0100 Original-Received: from localhost ([::1]:38081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebYsf-0000nd-M3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jan 2018 16:34:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebYqx-0008HA-NA for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2018 16:33:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebYqt-0006K8-38 for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2018 16:33:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebYqs-0006Jv-Tn for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2018 16:33:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebYqs-00008Q-Fr for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2018 16:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jan 2018 21:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5845-submit@debbugs.gnu.org id=B5845.1516138341472 (code B ref 5845); Tue, 16 Jan 2018 21:33:02 +0000 Original-Received: (at 5845) by debbugs.gnu.org; 16 Jan 2018 21:32:21 +0000 Original-Received: from localhost ([127.0.0.1]:59152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebYqB-00007X-Uy for submit@debbugs.gnu.org; Tue, 16 Jan 2018 16:32:21 -0500 Original-Received: from mail-wm0-f54.google.com ([74.125.82.54]:42594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebYq9-00007J-Je for 5845@debbugs.gnu.org; Tue, 16 Jan 2018 16:32:18 -0500 Original-Received: by mail-wm0-f54.google.com with SMTP id b141so11273671wme.1 for <5845@debbugs.gnu.org>; Tue, 16 Jan 2018 13:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Cpe7fepK6gO8y1k2MWX/lLAK+4YTbx3JsKUqbNDXL+E=; b=smf6l2s33gw7ORJQkMu8yzCKDPEYbsQ8bmoHjgjYnd2cN8843FVO0WI0XoEAV9iL1+ 1HtaDzaVDH08dP+7udMjqG8ms6qNQCo/4r4LF83PvGslt+giNsa1wG1T/KMrVQgY0/TA vLTGwgsFDHxbCW8fF0ThUzuDsroiv19OAmCUpMAx0mz2fCiTtNd+iPqSsLSwwH0ZHvqm auRVsjO1+WlDW1+Iw3sGA8hverfbw9LQjaIMBsAgO4e3llxK4NyYUwk8qBhwMxu+q9nu KOMJiTCAZYrtPsfYgUZubfgkqaZn179KZP9WQYvLf3Qay1h9okyITiCaJdSixObm5H4W oaNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Cpe7fepK6gO8y1k2MWX/lLAK+4YTbx3JsKUqbNDXL+E=; b=RsnBDQEv5WaiXLAB7AThjFPCci8GyBnhuCaajSpFAN+hNAf33UcmluYpsSG1mlSY31 YHZ/6QaQ9xiIqLTWYpOdoHiidtluyyG6F7LceJ75GlEL8ka2bACS1dwQlO21J84PWWJu /cRJDpRFSZHUkH6LJEkx/li5BgDUgFRuSyYQ0p1Eo/kszWImjQe/UoJTHcGvu+Fh14gS oPZjFo4baAgZkc/Q4K3RVl+Gmtuu/Rh/9peZv3as0yRHbyb+TiO8WIMvWa9WEgiFcKMv Oo4+SxNfgSDjYar7gmN5VrUaRMLExROa2x0AAqkbDfS8H80CmhhQq3qsIqi79MUdejnB DWeg== X-Gm-Message-State: AKwxytegYxNp60xni5PnTsNHr/dpr2rucd70JZD4PR93HobxckBWonr0 Qc88yLeu5q5mSznCPbHEUOQ+zHpsXejVc43pZ/s= X-Google-Smtp-Source: ACJfBotQ7zeH6YlmkMI9GuYh9/d8mx4Cde5KCCmEIw53JLfhIMs0E6ztaP9ZhJVLiqnpsDHF/V5bLyStVsZujipfZh0= X-Received: by 10.28.129.70 with SMTP id c67mr398442wmd.160.1516138331838; Tue, 16 Jan 2018 13:32:11 -0800 (PST) Original-Received: by 10.223.142.53 with HTTP; Tue, 16 Jan 2018 13:32:11 -0800 (PST) In-Reply-To: <8162aa6c-e00a-199b-3572-e3e0a7d4cad7@cornell.edu> X-Google-Sender-Auth: 4WUH1JXjCfP1zWNF1eUCz_EbZUI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142214 Archived-At: --001a11422bbab33d030562eb76c9 Content-Type: text/plain; charset="UTF-8" On Tue, Jan 16, 2018 at 12:25 PM, Ken Brown wrote: > On 1/16/2018 10:54 AM, Noam Postavsky wrote: >> >> Should we just use case-insensitive compare for `windows-nt' systems? >> The idea of using "the same heuristics" as `load' sounds nice, but as >> far as I can tell, `load' just queries the file system directly. Doing >> the same in `load-path-shadow-find' is far too slow (raises execution >> time from 0.38s to 5.64s, and that's without any packages adding to >> the load-path). > > > Would it help to use file-name-case-insensitive-p? Ah, good point. How about the attached? --001a11422bbab33d030562eb76c9 Content-Type: application/octet-stream; name="v2-0001-Handle-case-insensitive-filenames-for-load-path-s.patch" Content-Disposition: attachment; filename="v2-0001-Handle-case-insensitive-filenames-for-load-path-s.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jci5lbi50 RnJvbSBhY2JkYjMyYjBhMTk3M2FkM2Y5YzM2MTc0OGQ5YWEzYzQ2MWUyNDQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBUdWUsIDE2IEphbiAyMDE4IDE2OjI2OjU2IC0wNTAwClN1YmplY3Q6IFtQQVRDSCB2Ml0g SGFuZGxlIGNhc2UtaW5zZW5zaXRpdmUgZmlsZW5hbWVzIGZvciBsb2FkLXBhdGggc2hhZG93cwog KEJ1ZyM1ODQ1KQoKKiBsaXNwL2VtYWNzLWxpc3Avc2hhZG93LmVsIChsb2FkLXBhdGgtc2hhZG93 cy1maW5kKTogQ2hlY2sgZm9yCnNoYWRvd2luZyB3aXRoIGNhc2UtaW5zZW5zaXRpdmUgbWF0Y2hp bmcgZm9yIGZpbGVzIG9mIGNhc2UtaW5zZW5zaXRpdmUKZGlyZWN0b3JpZXMgKGFzIGRldGVybWlu ZWQgYnkgYGZpbGUtbmFtZS1jYXNlLWluc2VudGl2ZS1wJykuCi0tLQogbGlzcC9lbWFjcy1saXNw L3NoYWRvdy5lbCB8IDggKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3Avc2hhZG93LmVsIGIv bGlzcC9lbWFjcy1saXNwL3NoYWRvdy5lbAppbmRleCA4OGE0OTRmLi42NDAyNjk1IDEwMDY0NAot LS0gYS9saXNwL2VtYWNzLWxpc3Avc2hhZG93LmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9zaGFk b3cuZWwKQEAgLTc4LDYgKzc4LDcgQEAgbG9hZC1wYXRoLXNoYWRvd3MtZmluZAogCXNoYWRvd3MJ CQkJOyBMaXN0IG9mIHNoYWRvd2luZ3MsIHRvIGJlIHJldHVybmVkLgogCWZpbGVzCQkJCTsgRmls ZSBuYW1lcyBldmVyIHNlZW4sIHdpdGggZGlycy4KIAlkaXIJCQkJOyBUaGUgZGlyIGJlaW5nIGN1 cnJlbnRseSBzY2FubmVkLgorCWRpci1jYXNlLXNlbnNpdGl2ZSAgICAgICAgICAgICAgOyBgZmls ZS1uYW1lLWNhc2UtaW5zZW50aXZlLXAnIGZvciBkaXIuCiAJY3Vyci1maWxlcwkJCTsgVGhpcyBk aXIncyBFbWFjcyBMaXNwIGZpbGVzLgogCW9yaWctZGlyCQkJOyBXaGVyZSB0aGUgZmlsZSB3YXMg Zmlyc3Qgc2Vlbi4KIAlmaWxlcy1zZWVuLXRoaXMtZGlyCQk7IEZpbGVzIHNlZW4gc28gZmFyIGlu IHRoaXMgZGlyLgpAQCAtMTA0LDYgKzEwNSw5IEBAIGxvYWQtcGF0aC1zaGFkb3dzLWZpbmQKIAkg ICAgIChtZXNzYWdlICJDaGVja2luZyAlZCBmaWxlcyBpbiAlcy4uLiIgKGxlbmd0aCBjdXJyLWZp bGVzKSBkaXIpKQogCiAJKHNldHEgZmlsZXMtc2Vlbi10aGlzLWRpciBuaWwpCisgICAgICAgIDs7 IFdlIGFzc3VtZSB0aGF0IGNhc2Ugc2Vuc2l0aXZpdHkgb2YgYSBkaXJlY3RvcnkgYXBwbGllcyB0 bworICAgICAgICA7OyBpdHMgZmlsZXMuCisgICAgICAgIChzZXRxIGRpci1jYXNlLXNlbnNpdGl2 ZSAoZmlsZS1uYW1lLWNhc2Utc2Vuc2l0aXZlLXAgZGlyKSkKIAogCShkb2xpc3QgKGZpbGUgY3Vy ci1maWxlcykKIApAQCAtMTIzLDcgKzEyNyw5IEBAIGxvYWQtcGF0aC1zaGFkb3dzLWZpbmQKIAkg ICAgOzsgWFhYLmVsYyAob3IgdmljZS12ZXJzYSkgd2hlbiB0aGV5IGFyZSBpbiB0aGUgc2FtZSBk aXJlY3RvcnkuCiAJICAgIChzZXRxIGZpbGVzLXNlZW4tdGhpcy1kaXIgKGNvbnMgZmlsZSBmaWxl cy1zZWVuLXRoaXMtZGlyKSkKIAotCSAgICAoaWYgKHNldHEgb3JpZy1kaXIgKGFzc29jIGZpbGUg ZmlsZXMpKQorICAgICAgICAgICAgKGlmIChzZXRxIG9yaWctZGlyIChhc3NvYyBmaWxlIGZpbGVz CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh1bmxlc3MgZGlyLWNhc2Ut c2Vuc2l0aXZlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJk YSAoZjEgZjIpIChlcSAoY29tcGFyZS1zdHJpbmdzIGYxIG5pbCBuaWwgZjIgbmlsIG5pbCB0KSB0 KSkpKSkKIAkJOzsgVGhpcyBmaWxlIHdhcyBzZWVuIGJlZm9yZSwgd2UgaGF2ZSBhIHNoYWRvd2lu Zy4KIAkJOzsgUmVwb3J0IGl0IHVubGVzcyB0aGUgZmlsZXMgYXJlIGlkZW50aWNhbC4KIAkJKGxl dCAoKGJhc2UxIChjb25jYXQgKGNkciBvcmlnLWRpcikgIi8iIGZpbGUpKQotLSAKMi42LjIud2lu ZG93cy4xCgo= --001a11422bbab33d030562eb76c9--