From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests Date: Sat, 4 Feb 2017 09:01:49 -0500 Message-ID: References: <87inoqqdgr.fsf@calancha-pc> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1486216936 23397 195.159.176.226 (4 Feb 2017 14:02:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Feb 2017 14:02:16 +0000 (UTC) Cc: 25618@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 04 15:02:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca0uq-0005th-SN for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 15:02:12 +0100 Original-Received: from localhost ([::1]:39491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca0uv-00073r-Us for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 09:02:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca0uk-00072m-Ab for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 09:02:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca0ug-0006gW-Le for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 09:02:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ca0ug-0006gS-I7 for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 09:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ca0ug-0005D6-0r for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 09:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2017 14:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25618 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25618-submit@debbugs.gnu.org id=B25618.148621691720015 (code B ref 25618); Sat, 04 Feb 2017 14:02:01 +0000 Original-Received: (at 25618) by debbugs.gnu.org; 4 Feb 2017 14:01:57 +0000 Original-Received: from localhost ([127.0.0.1]:55580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca0ub-0005Ck-1N for submit@debbugs.gnu.org; Sat, 04 Feb 2017 09:01:57 -0500 Original-Received: from mail-ot0-f182.google.com ([74.125.82.182]:36534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca0uZ-0005CY-5n for 25618@debbugs.gnu.org; Sat, 04 Feb 2017 09:01:55 -0500 Original-Received: by mail-ot0-f182.google.com with SMTP id 32so34017385oth.3 for <25618@debbugs.gnu.org>; Sat, 04 Feb 2017 06:01:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=pYaiYKuO5mr2/8jwnhfvVGH3ZvjZnR2bMavlyQQXXLY=; b=EBp7OoMFRANPiN0iQdc0SbifJo95Wp1a5AVZTLYYEKHliw4WGWlUx4r466kEUvhbKh pdRVTmbRNKNzApTayu13V6zgrGOuoU78zDhR71GmEHzjR1bah8fm2xzPss1JZ2XK88V7 c3HxL7x6YoAL8iJoVZCmoIUbECISltfxsDLjk46eycUVAFBeXWG50LmnwB9zLsKgBzk+ NdxTWC983Eq/7IIPRryKL8TAe7gCrA60lj+AKYL0VC8/bK5u6bihJLL6u+X+pNg3h9qw bhMvBqVjYmCTxPWwKRIm3uCHvJ93HL4YVgy+T82fcCESxFNzGxOIy8OwZrf1ybLvEizT FgsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=pYaiYKuO5mr2/8jwnhfvVGH3ZvjZnR2bMavlyQQXXLY=; b=Gp6IlfKFtZD6wLmymx6UDxhb+MxuI16IzFb+nbwiDzJ3hmEMaRprvVUxN4ujUrF6qS CRXaNbjPfAjS7gpuScLVBS0B16Qn/qM6GH8lhgw6w1xldwiOY9dJGgymS2Xb04SfE/IM WTnlotk+5Xc9ArIC+2MjSzgexwJsdQmXzmagjCLRnMaExaz9ar067oceSyY8/lxUuz6P v2n/MaGhWmsAOtePl5MPIxqPoEBgOonWhIdFeO40uJleKJ0m6RCMndjRIHP8Bs4cZU5F MoMOd/BwwaFFpL+be+GkucKKketfMT+YHrUfqW6aWT2acZUvPRV3Ou5JLB0hbRE5X/kI 6P/A== X-Gm-Message-State: AMke39kUouqReo8pcrnsnTd7oYOFWmuGRawDzILLAIt11bqBmT90lr9aQKc9xzXiNLAqImKYOovUybaBpWYjbg== X-Received: by 10.157.42.202 with SMTP id e68mr966705otb.221.1486216909443; Sat, 04 Feb 2017 06:01:49 -0800 (PST) Original-Received: by 10.157.21.117 with HTTP; Sat, 4 Feb 2017 06:01:49 -0800 (PST) In-Reply-To: <87inoqqdgr.fsf@calancha-pc> X-Google-Sender-Auth: pdCiQaJ36YlttwpYdREQn-ATKWU X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128950 Archived-At: On Sat, Feb 4, 2017 at 8:42 AM, Tino Calancha wrote: > > Prefer set a numeric limit of seconds than using the word 'few'. > > For instance, in my box the test `cl-seq-test-bug24264' in > test/lisp/emacs-lisp/cl-seq-tests.el > takes 7 s. > With an explicit numeric threshold is easier to decide whether this test > must be tagged as expensive or not. > > In following patch i define a few as 2-3 seconds. Other people might > prefer 4-5 or even higher. > Please, suggest a proper value to consider a test as expensive. Is it worth specifying this so precisely? The time elapsed depends on the speed of the computer you run it on (also, whether Emacs is compiled with optimization or not). A test that takes 2 seconds on your computer might easily take 5 seconds on mine.