unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: 3552@debbugs.gnu.org
Subject: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties
Date: Sat, 4 Jun 2016 11:22:23 -0400	[thread overview]
Message-ID: <CAM-tV-_J5zFnX77DH9W4OUgjpziThBf2HJbqkYJP7LBUJ1pB7Q@mail.gmail.com> (raw)
In-Reply-To: <CAM-tV--UrGA4dV_LBZwZwzx99mq0Y+gPYtfnwPeAC1ZakHWvsQ@mail.gmail.com>

On Sat, Jun 4, 2016 at 9:35 AM, Noam Postavsky
<npostavs@users.sourceforge.net> wrote:
> I propose the following patch be applied to the emacs-25 branch:

Sorry, that's not quite right, I didn't realize DEC_BOTH also reads
from the buffer, here is a patch that actually fixes the invalid read:

@@ -3109,8 +3109,10 @@ DEFUN ("backward-prefix-chars",
Fbackward_prefix_chars, Sbackward_prefix_chars,
       opoint = pos;
       opoint_byte = pos_byte;

-      if (pos + 1 > beg)
+      if (pos > beg)
     DEC_BOTH (pos, pos_byte);
+      else
+        break;
     }

   SET_PT_BOTH (opoint, opoint_byte);





  reply	other threads:[~2016-06-04 15:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-13 10:40 bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties Johan =?UTF-8?Q?Bockg=C3=A5rd
2016-06-03  3:34 ` Noam Postavsky
2016-06-04 13:35   ` Noam Postavsky
2016-06-04 15:22     ` Noam Postavsky [this message]
2016-06-04 17:55       ` Eli Zaretskii
2016-06-04 21:25         ` Noam Postavsky
2016-06-05  7:36           ` martin rudalics
2016-06-05 13:35             ` Noam Postavsky
2016-06-16  2:07               ` Noam Postavsky
2016-06-16 15:05                 ` Eli Zaretskii
2016-06-17  3:20                   ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV-_J5zFnX77DH9W4OUgjpziThBf2HJbqkYJP7LBUJ1pB7Q@mail.gmail.com \
    --to=npostavs@users.sourceforge.net \
    --cc=3552@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).