From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24091: Problem caused by the fix for this bug Date: Thu, 26 Oct 2017 16:40:02 -0400 Message-ID: References: <24533f31-9fc2-b38e-aaeb-561616cdf77f@gmail.com> <136e1c0c-a33f-3edb-505b-c74a1ea0c6d0@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1509050488 16165 195.159.176.226 (26 Oct 2017 20:41:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Oct 2017 20:41:28 +0000 (UTC) Cc: 24091@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 26 22:41:23 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7oxh-0001oS-Cj for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Oct 2017 22:41:09 +0200 Original-Received: from localhost ([::1]:54575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7oxl-0000Ac-Ak for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Oct 2017 16:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7oxe-00009d-QV for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 16:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7oxa-00010B-VY for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 16:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55091) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7oxa-0000zs-Re for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 16:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e7oxa-0006mJ-GK for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 16:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Oct 2017 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24091 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed fixed Original-Received: via spool by 24091-submit@debbugs.gnu.org id=B24091.150905041025991 (code B ref 24091); Thu, 26 Oct 2017 20:41:02 +0000 Original-Received: (at 24091) by debbugs.gnu.org; 26 Oct 2017 20:40:10 +0000 Original-Received: from localhost ([127.0.0.1]:35539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7owj-0006l9-MS for submit@debbugs.gnu.org; Thu, 26 Oct 2017 16:40:09 -0400 Original-Received: from mail-wr0-f181.google.com ([209.85.128.181]:47964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7owi-0006kw-HP for 24091@debbugs.gnu.org; Thu, 26 Oct 2017 16:40:08 -0400 Original-Received: by mail-wr0-f181.google.com with SMTP id y39so4379453wrd.4 for <24091@debbugs.gnu.org>; Thu, 26 Oct 2017 13:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=vvvoSHVkbhfxF9A+cqe3BDeLlqBS11CF9UOtrogye6M=; b=msXXaANBF++TacyvwSWmAeuR/VWi8o2srCEmycEIcg1HJageCXQ4lbZ5Fgxbw4tYbp JxccV0RBo9zwllMXjsP2VPfTgKwC4K3PF3EV+Z/6cEgQTUApSIJEZepOraz3PuCJMaLv 17oUr3KGm3F8wmuDi64APhKWTeMseWiICrO5HYsRvP1l3pRBJRftvF4xg+78/uIXD8Tj 2IuqCnvIege46DMkDE0VytwpgQBkmTDkoidFGy0Rfo/8k0q1H7QWnOj1l8cgDOvNEK9E xvveTmlHSQpKpr1/DDOuFAXglbRr4Tf9Cp6CEt8xrrIcolpZylaKqXSvIYP7S0OVQV6M A7QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=vvvoSHVkbhfxF9A+cqe3BDeLlqBS11CF9UOtrogye6M=; b=E9gddhxxgG3FTXSN0QoagUAMOhRqVl1chSdQeMe21uII/MhBKOmgmN9doNSyVOib1x m/ZZBc1FYD4VznA4mmVOFDQ+IVPulIFLECFNxYGF046SK4P8CvQtRJuB7R8Oj9kOo9Ey 5G2/dbk7GMzRhIQLe+koLzdUeJ7T5doYQcuW2KqzziaxcPzgx3Dnvq5UL89KSBb37L6N sBHHzCLr9h3NBGwqJ2/zRpuqO/pg/4QLJYKNJS5Cm3Jd/1tRet1G55Xa5ZL+bdbsnc+v L7oNdX5fp+90OyYR3PvCDiTgnZroV6jfoUwhCifNBjoSHYbFpX/EOq7f03kjSsA/A5fK DWqQ== X-Gm-Message-State: AMCzsaVvKJfFforJpAQlGHlZ7h1TfoMoDtlM6Q6mRSM7GK314xY9oEch wKSIiQoMzDRRNCKdgicswT+bnZ/N2M46BNmMQcmSwQ== X-Google-Smtp-Source: ABhQp+SkN232gcITYJjzatlu5Z+21Fh/G0F4yZE8CjUQMUCW9XblQOZMM4uQqpwA0veZIDaQq7SITID/J/lj4nYLfqA= X-Received: by 10.223.200.132 with SMTP id k4mr6160118wrh.215.1509050402761; Thu, 26 Oct 2017 13:40:02 -0700 (PDT) Original-Received: by 10.223.146.227 with HTTP; Thu, 26 Oct 2017 13:40:02 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: RqtFDHPdIRw_z8XVGqNXdbUVsy8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139037 Archived-At: On Thu, Oct 26, 2017 at 2:12 PM, Ken Brown wrote: > The commit I cited was the first bad one (as determined by git bisect). The > problem still exists in the current HEAD of the emacs-26 branch. Okay. I removed the code because my understanding of the comment was that it was needed to prevent a hang during the busy wait for visibility. Therefore, when I removed that busy wait, I thought that poll_for_input_1 was no longer needed either. However, from what you say, it sounds like it's rather needed after creating a frame, unrelated to the waiting per se. I don't really understand what the code does, but I guess you could try putting the poll_for_input_1 stuff back in either before, inside, or after the x_wait_for_event at the end of x_make_frame_visible and see what helps?