From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 21468@debbugs.gnu.org
Subject: bug#21468: 24.5; When next-line (visual) crosses overlay with before-string="\n" point goes to column 0
Date: Mon, 14 Sep 2015 08:46:57 -0400 [thread overview]
Message-ID: <CAM-tV-_3uWHuEEnMLvHPbBiYThPnBN=sScwSd526_BGvgJKKjg@mail.gmail.com> (raw)
In-Reply-To: <83twqxa5is.fsf@gnu.org>
On Mon, Sep 14, 2015 at 2:17 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> Of course: that's a line of text. Why is that a problem? (I have no
> idea what role is that thin line serving in Magit.)
In this particular case, the overlays are delimiting a "magit region"
(consisting of whole logical lines touched by Emacs' region). This
means the thin line has to move with point, staying just ahead of it.
Here is a demo, eval this in a buffer, then do set-mark-command and
move around a bit:
(require 'cl-lib)
(defvar-local magit-region-overlays nil)
(defun 21468-update-hunk-region (start end window rol)
(mapc #'delete-overlay magit-region-overlays)
(let ((rbeg (save-excursion (goto-char (region-beginning))
(line-beginning-position)))
(rend (save-excursion (goto-char (region-end))
(line-end-position))))
(cl-flet ((ov (start end &rest args)
(let ((ov (make-overlay start end nil t)))
(overlay-put ov 'evaporate t)
(while args (overlay-put ov (pop args) (pop args)))
(push ov magit-region-overlays)
ov)))
(ov rbeg (1+ rbeg) 'before-string
(propertize (concat (propertize "\s" 'display '(space :height (1)))
(propertize "\n" 'line-height t))
'face 'highlight))
(ov rend (1+ rend) 'after-string
(propertize (concat (propertize "\s" 'display '(space :height (1)))
(propertize "\n" 'line-height t))
'face 'highlight)))))
(setq-local redisplay-highlight-region-function '21468-update-hunk-region)
(setq-local redisplay-unhighlight-region-function
(lambda (rol) (mapc #'delete-overlay magit-region-overlays)))
next prev parent reply other threads:[~2015-09-14 12:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 5:17 bug#21468: 24.5; When next-line (visual) crosses overlay with before-string="\n" point goes to column 0 Noam Postavsky
2015-09-13 10:30 ` Eli Zaretskii
2015-09-13 17:20 ` Noam Postavsky
2015-09-13 19:50 ` Eli Zaretskii
2015-09-13 20:22 ` Noam Postavsky
2015-09-14 6:17 ` Eli Zaretskii
2015-09-14 12:46 ` Noam Postavsky [this message]
2015-09-14 13:22 ` Stefan Monnier
2015-09-14 13:33 ` Eli Zaretskii
2015-09-14 13:55 ` Noam Postavsky
2015-09-14 15:14 ` Eli Zaretskii
2015-09-14 20:50 ` Noam Postavsky
2015-09-15 6:53 ` Eli Zaretskii
2015-10-01 20:43 ` Noam Postavsky
2015-10-02 10:01 ` Eli Zaretskii
2015-10-02 19:58 ` Noam Postavsky
2015-10-02 21:00 ` Eli Zaretskii
2015-10-09 23:34 ` Noam Postavsky
2015-10-10 7:14 ` Eli Zaretskii
2015-10-10 13:37 ` Noam Postavsky
2015-10-10 14:20 ` Eli Zaretskii
2015-10-10 16:51 ` Noam Postavsky
2015-10-10 17:09 ` Eli Zaretskii
2015-10-10 21:06 ` Noam Postavsky
2015-10-11 2:38 ` Eli Zaretskii
2015-10-10 17:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-_3uWHuEEnMLvHPbBiYThPnBN=sScwSd526_BGvgJKKjg@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=21468@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).