From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning Date: Sat, 31 Oct 2015 18:36:40 -0400 Message-ID: References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1446331041 21694 80.91.229.3 (31 Oct 2015 22:37:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2015 22:37:21 +0000 (UTC) Cc: 21681@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 31 23:37:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zselr-0002a0-2m for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Oct 2015 23:37:11 +0100 Original-Received: from localhost ([::1]:57211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zselq-0004lB-Ej for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Oct 2015 18:37:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zseln-0004ju-4t for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 18:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zseli-0002la-Ri for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 18:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zseli-0002lW-O3 for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 18:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zseli-0001Dz-Iu for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2015 18:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2015 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21681 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21681-submit@debbugs.gnu.org id=B21681.14463310044683 (code B ref 21681); Sat, 31 Oct 2015 22:37:02 +0000 Original-Received: (at 21681) by debbugs.gnu.org; 31 Oct 2015 22:36:44 +0000 Original-Received: from localhost ([127.0.0.1]:47354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZselP-0001DS-FW for submit@debbugs.gnu.org; Sat, 31 Oct 2015 18:36:43 -0400 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:35395) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZselN-0001DK-BY for 21681@debbugs.gnu.org; Sat, 31 Oct 2015 18:36:41 -0400 Original-Received: by wmll128 with SMTP id l128so35330057wml.0 for <21681@debbugs.gnu.org>; Sat, 31 Oct 2015 15:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=8fBE7Yms0VMnRv3MqJgam1t0NSGGeNes7w9XUAqKxmg=; b=HI6LWHeN0UPJbvCtamkqfT6SDJvvdoIVwjYpvItA0bRKHKW4lDkm0R7ELP8s3S0ktN 1Ycg0nhvb3la5+oNdSIC6jxR6RmVIy6MN2Qd9+6FNmZadWYnmmw7jA1bHkj+8Q8LDnzV lZIdX1qIMACwvc61cyv2SK/dZ4UoeG5em/aVNceHr+PxPpimL/8oBBCNDXHiRJql5G7r a8qPPVfZOE4Yr7ICQ4RZyAkjI7YjLa/3ZytYBoBI8P9aSmPXqXQEgx8am9V+SDkIUddW 2XJxZYPMvrEDxJx+9eParGDspGQNwNIhwEDgOC+ofvD6L09fMV6gkcNSXIv8X7ZWdHdx /Cyg== X-Received: by 10.28.210.77 with SMTP id j74mr5116000wmg.60.1446331000584; Sat, 31 Oct 2015 15:36:40 -0700 (PDT) Original-Received: by 10.28.29.87 with HTTP; Sat, 31 Oct 2015 15:36:40 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: ocFdIeDTqfrdcOdGPx9H77yAcO0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108246 Archived-At: On Wed, Oct 14, 2015 at 1:47 PM, Noam Postavsky wrote: > On Wed, Oct 14, 2015 at 1:42 PM, Eli Zaretskii wrote: >>> Date: Wed, 14 Oct 2015 12:56:28 -0400 >>> From: Noam Postavsky >>> own, but display-warning only prints the 1st symbol of the list so the >>> warning text itself wouldn't change. >> >> I find "files" no more explanatory that "warning". If we lack >> infrastructure to display meaningful messages that unequivocally point >> to the nature of the problem, let's add the missing infrastructure. > > How about making display-warning print all TYPE symbols then? I've been playing a bit more with display-warning, and I think the part in brackets is not supposed to be part of the warning's explanation, but rather it tells you how to block it. Like gcc's "[-Wfoo]". The problem with printing all the symbols is that it would make the warnings using TYPE lists longer, pushing the actual warning text to the right, and discourage use of more specific TYPEs. Another possiblity is still to truncate to a single item, but show a "..." button to expand it, like `eval-last-sexp' does for long lists. Another thing I've been experimenting with is including buttons with an action to resolve the problem in the warning text. It seems to work pretty well, except that because *Warnings* is in special-mode isn't bound to forward-button. It could be nice to have a warnings-mode which does that. It could also bind e.g. `i' to something like ignore-warning-at-point (which would customize warning-suppress-types). But I know Emacs supposed to be in feature freeze so maybe now is not the time to be adding new modes.