From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#23574: 24.5; Overzealous underlining in emacs-nox Date: Tue, 7 Jun 2016 22:52:25 -0400 Message-ID: References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <83vb1mrura.fsf@gnu.org> <83bn3dro1g.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1465354405 18573 80.91.229.3 (8 Jun 2016 02:53:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jun 2016 02:53:25 +0000 (UTC) Cc: 23574@debbugs.gnu.org, Colin Woodbury , John Mastro To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 08 04:53:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bATcJ-0002tE-0v for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Jun 2016 04:53:15 +0200 Original-Received: from localhost ([::1]:54181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bATcH-0005a3-MD for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jun 2016 22:53:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bATcB-0005Zy-SE for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 22:53:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bATc6-0004u8-Pr for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 22:53:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bATc6-0004u4-M9 for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 22:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bATc6-0000rE-Ay for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 22:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jun 2016 02:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 23574-submit@debbugs.gnu.org id=B23574.14653543543261 (code B ref 23574); Wed, 08 Jun 2016 02:53:02 +0000 Original-Received: (at 23574) by debbugs.gnu.org; 8 Jun 2016 02:52:34 +0000 Original-Received: from localhost ([127.0.0.1]:59355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bATbd-0000qW-Nq for submit@debbugs.gnu.org; Tue, 07 Jun 2016 22:52:33 -0400 Original-Received: from mail-oi0-f53.google.com ([209.85.218.53]:34965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bATbc-0000qK-1U for 23574@debbugs.gnu.org; Tue, 07 Jun 2016 22:52:32 -0400 Original-Received: by mail-oi0-f53.google.com with SMTP id s139so68499202oie.2 for <23574@debbugs.gnu.org>; Tue, 07 Jun 2016 19:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=psa68JqwEQICRwaXxZZsVMaCc4rNQpQSV7Qld792UfU=; b=iBgLpzjXSC7skC/6aYfw41jtfO2DO6e4cWsag1dUy23WDSIKfP9NTjAS0YI0lywFaO uP4TaZ7cn4IjofY1xYpUeGxxexVarbTjDSs4FbUWFuMUO6LLGXabH5gHSMU9oQSHZRpf JZ4lRElPrJJ3425vjMyUSi3pp6PugRtxVbdtBpy98k89MgejEixXvjZDgFrRvIdjjvAn XUW4qdw6mfxCt6mpuHhw1mivbSsE3cI7KpCi6BfSLqQ5KzQoIi+xpnKKrgfZ1rDlLWUl MbNWwIfoFVx8KQmTBcCpI1gXQA6WPyuXc+nzy2lZEEQkPoQDOFbS5WOLGYq1hFRA8pD+ gliw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=psa68JqwEQICRwaXxZZsVMaCc4rNQpQSV7Qld792UfU=; b=c0HJ93euelAoXmZnPSfI4ZzYaVseiEOrCv1KaHk56Fr16HvtBAHzXidn5EJsnsoyTf MP4uyPnsjkLdrVzoGbWi1glEeZXvrjLILDh2cjpEmV2hlUcm59ejEiHmfkxS4IxWCr9S 1VxiFgPV7O5mEXf6kaC4sVDnpsMGdRX9Ml0EZrQIFoqu1LnJZVEPQks9I44wfc+S9DQX vznIWlTutyuRQ2IicvlwEB8NQV6W03jTDnN/MDNbxWn567dMxNDpFyLXyWQjFBsxDnkF flSs4O75xVyMlFGPlOtlCsUQcMfsEbAirAOh1oHxVPKz+kKOFU2Vr8713BWSYAMWWVTu HgGQ== X-Gm-Message-State: ALyK8tJ1KlBEL0GnacAOwJ02B4rLmekDtY0cIo2uA29TlevWsbQ9EG/vvVI+sirNtqs8ljQLrIosE1I9SXos7Q== X-Received: by 10.202.168.131 with SMTP id r125mr1613934oie.40.1465354346384; Tue, 07 Jun 2016 19:52:26 -0700 (PDT) Original-Received: by 10.157.5.168 with HTTP; Tue, 7 Jun 2016 19:52:25 -0700 (PDT) In-Reply-To: <83bn3dro1g.fsf@gnu.org> X-Google-Sender-Auth: 3W4sKS_7YIdCLvbdZsfkapP_nMA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119248 Archived-At: On Tue, Jun 7, 2016 at 11:55 AM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Mon, 6 Jun 2016 20:18:06 -0400 >> Cc: Colin Woodbury , martin rudalics , 23574@debbugs.gnu.org, >> John Mastro >> >> I think it makes sense to not do the face extension by default. > > Not even for the background color? Or are you talking only about the > underline? Well, I was thinking mostly about underlining, but imagining a scenario with paper again, if I'm highlighting text with a marker, I wouldn't go to edge of the page there either. For some applications, the intention is to colour a whole block, not just the text. So I think it's better to let the code making the faces have a way to indicate which scenario is intended rather than relying on user customization. > >> For the case I mentioned earlier, magit isn't actually underlining >> text, it just wants to make some horizontal lines. It would be nice to >> have some way to ask the display engine to do this directly. > > There's a way of doing that which we use in the VC commit log buffer, > I believe it uses the line-height property. (I thought magit was > using that as well, no?) Yes, and it caused some problems with cursor movement that you weren't so happy about fixing.