From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#17862: 24.3; regexp-opt docstring is incorrect Date: Sun, 21 Aug 2016 08:47:40 -0400 Message-ID: References: <87zip19rm4.fsf@users.sourceforge.net> <87lh0j9rwg.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1471783701 12007 195.159.176.226 (21 Aug 2016 12:48:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Aug 2016 12:48:21 +0000 (UTC) Cc: 17862@debbugs.gnu.org, Andreas Schwab To: immerrr again Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 21 14:48:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbSAj-0002ov-1Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Aug 2016 14:48:17 +0200 Original-Received: from localhost ([::1]:36557 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbSAg-0001iu-1o for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Aug 2016 08:48:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbSAZ-0001gj-RX for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 08:48:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbSAU-0004t8-Q5 for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 08:48:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbSAU-0004t4-ML for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 08:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bbSAU-0004AI-Cc for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 08:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2016 12:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17862-submit@debbugs.gnu.org id=B17862.147178366915990 (code B ref 17862); Sun, 21 Aug 2016 12:48:02 +0000 Original-Received: (at 17862) by debbugs.gnu.org; 21 Aug 2016 12:47:49 +0000 Original-Received: from localhost ([127.0.0.1]:35560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbSAH-00049q-7Z for submit@debbugs.gnu.org; Sun, 21 Aug 2016 08:47:49 -0400 Original-Received: from mail-oi0-f49.google.com ([209.85.218.49]:36604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbSAF-00049b-89 for 17862@debbugs.gnu.org; Sun, 21 Aug 2016 08:47:47 -0400 Original-Received: by mail-oi0-f49.google.com with SMTP id f189so118978533oig.3 for <17862@debbugs.gnu.org>; Sun, 21 Aug 2016 05:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GhdoxzrzC3zBnvM1ojxTgemJBuwXJqGFOa48Vuno8T8=; b=y5jiuSOmQk6ph3VMW0m4x2v+yvw9TXCmCGnf2RTurFLSBNPV7LmYB8lJncit+q5SM1 iCJWDH4YuzRN6zCKKgMYHVakx5KR8zYUcMKKWsjuACI6sRgFBoeHt67iXZVdIzxsfOKz 419ltE4OqPi8s7SM7IeIKa0MR4468ha0MvGd9igOXAM8iRq1V+3/PI2ovmYboefosQyq OTQlb7CVnqMch6VLEu5jbDtnto3DvkEJlWxugdJUhcIbEGwKPfM4nHcsqCIPk/UzdEEl nSafAXWzMsZyOmh/x9B6Rs1vpYZX0AqhtuY4ATwPwiKIpgHMWQIG8HZ65tveFSZ9HTPY dvNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=GhdoxzrzC3zBnvM1ojxTgemJBuwXJqGFOa48Vuno8T8=; b=HchBDRY54gVUxc3eUkauC5scpvcan3FDhYrko/kZiS5oSuak5TGJKuAd9mlcXW9HTc i7kvy5UL7OmZFEVAFZ+wov36lD+SnXSi9cRd42fRB87s6jU9weC633nuF+GqxkBsyKD1 4yi227C2x+4ADD+eHRz0JGJ5qqWfqW7Fwtqjpt7dEt2QGdoyLDcPuJ3ZuFw6Od0w/fa+ 7Dh12mohYa3aG1nb3BLdHkvpLYdAxFGAayQ7vVFuk851iVErZKcPL66TC1R0ATOEdJWe QKQMYR+wkKa9coSXFPJhxXow1SYZYez7dV6UeIEcOO4hgGClbVf4B5fM8HSsFZSNPDWw f2aw== X-Gm-Message-State: AEkoouueHrpCwiwK1bRCziEGMqN7N7/TFx3F0ZckVXATwG0M6a6EnCj03hOVaJOlARrjRROv1r6HOInU06EWEw== X-Received: by 10.202.73.205 with SMTP id w196mr9854346oia.40.1471783661635; Sun, 21 Aug 2016 05:47:41 -0700 (PDT) Original-Received: by 10.157.7.200 with HTTP; Sun, 21 Aug 2016 05:47:40 -0700 (PDT) In-Reply-To: <87lh0j9rwg.fsf@users.sourceforge.net> X-Google-Sender-Auth: UKDH_GROdx2U77nc1FATn5Tf_OM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122450 Archived-At: On Sat, Jul 30, 2016 at 9:28 AM, wrote: > immerrr again writes: >> I agree that adding "impenetrable definitions" might be unclear, but I'd argue >> that it's still an improvement because the equivalence statement is >> plain false now: >> >> - "words" and "symbol" keywords add special backslash characters >> around the result >> >> - if PAREN is nil, the result is still grouped (unless the strings can be >> represented as a character set, but that's not handled in the >> simplified version) >> >> I doubt we can put all the logic behind PAREN into the simplified version. > > Hah, sounds like a challenge :) How about > > (defun simplified-regexp-opt (strings &optional paren) > (let ((parens (cond ((eq paren 'words) '("\\<\\(" . "\\)\\>")) > ((eq paren 'symbols) '("\\_<\\(" . "\\)\\_>")) > ((null paren) '("\\(?:" . "\\)")) > (t '("\\(" . "\\)"))))) > (concat (car paren) > (mapconcat 'regexp-quote strings "\\|") > (cdr paren)))) > >> +@code{nil} >> + if all @var{strings} are single-character, the resulting regexp is >> + not surrounded, otherwise it is surrounded by @samp{\(?:} and >> + @samp{\)}. > > Zero character strings also: > > (regexp-opt '("a" "")) ;=> "a?" > > How about saying "the regexp may be surrounded with \?(: ) to ensure that > it constitutes a single expression (such that appending a postfix > operator like '+' will apply to the whole expression)." > ping?