From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ynyaaa@gmail.com, 23533@debbugs.gnu.org
Subject: bug#23533: 24.5; test-completion with completion-regexp-list
Date: Sat, 18 Jun 2016 13:40:04 -0400 [thread overview]
Message-ID: <CAM-tV-9cmjKxPz499pA1fpv6M25AT2zwzipkVmNZUwhSKWi43g@mail.gmail.com> (raw)
In-Reply-To: <83r3bu9zi4.fsf@gnu.org>
On Sat, Jun 18, 2016 at 1:29 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Noam Postavsky <npostavs@users.sourceforge.net>
>> Date: Sat, 18 Jun 2016 13:14:59 -0400
>> Cc: 23533@debbugs.gnu.org, ynyaaa@gmail.com
>>
>> On Sat, Jun 18, 2016 at 4:08 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> > I'm not sure this is a bug.
>>
>> I think it's pretty clearly a bug, because the docs explain that
>> test-completion takes the same arguments as all-completions and
>> try-completions, which do handle an alist COLLECTION with a non-nil
>> completion-regexp-list.
>
> When code contradicts the documentation, it's not immediately clear
> that the code should be fixed.
Independently of the documentation, I also think it makes no sense to
have test-completion be inconsistent with all-completions and
try-completion.
>
> Anyway, I don't consider myself an expert on completion, so I feel
> uneasy about makings this change without any of the experts voicing
> their opinions on the change.
Okay, I will wait another week before pushing to master in case anyone
has some objections/comments.
next prev parent reply other threads:[~2016-06-18 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 16:57 bug#23533: 24.5; test-completion with completion-regexp-list ynyaaa
2016-06-17 4:06 ` Noam Postavsky
2016-06-18 1:01 ` Noam Postavsky
2016-06-18 8:08 ` Eli Zaretskii
2016-06-18 17:14 ` Noam Postavsky
2016-06-18 17:29 ` Eli Zaretskii
2016-06-18 17:40 ` Noam Postavsky [this message]
2016-06-27 1:14 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-9cmjKxPz499pA1fpv6M25AT2zwzipkVmNZUwhSKWi43g@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=23533@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ynyaaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).