From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' Date: Wed, 6 Jul 2016 16:39:15 -0400 Message-ID: References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1467837626 13767 80.91.229.3 (6 Jul 2016 20:40:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jul 2016 20:40:26 +0000 (UTC) Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 06 22:40:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bKtcF-0004Ym-CV for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Jul 2016 22:40:15 +0200 Original-Received: from localhost ([::1]:35751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKtcE-0005ri-N3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Jul 2016 16:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKtc6-0005qT-Pu for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 16:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKtc2-00030N-5p for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 16:40:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKtc2-00030J-2U for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 16:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bKtc1-0004RD-LG for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 16:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2016 20:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 19362-submit@debbugs.gnu.org id=B19362.146783756417001 (code B ref 19362); Wed, 06 Jul 2016 20:40:01 +0000 Original-Received: (at 19362) by debbugs.gnu.org; 6 Jul 2016 20:39:24 +0000 Original-Received: from localhost ([127.0.0.1]:39915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKtbP-0004Q9-Lu for submit@debbugs.gnu.org; Wed, 06 Jul 2016 16:39:23 -0400 Original-Received: from mail-oi0-f41.google.com ([209.85.218.41]:35852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKtbN-0004Pv-MF for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 16:39:22 -0400 Original-Received: by mail-oi0-f41.google.com with SMTP id f189so287249150oig.3 for <19362@debbugs.gnu.org>; Wed, 06 Jul 2016 13:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=silCjUTkNwNx+3UwQI81OMyeGWjZwBo8XeLo7Lu/1cY=; b=dMTiljywU2ZKiJBQnWY5yDEjK3wDW362rIU98Hvw2jP/EfO80HSrV7F3HKpUGJlb0Z rzuaagSaMz3NGVG8X98uh+JW0gY4/+6/WVSPakVIMZeSkXFF5Ywj9RmCK6y3kjNEDfSy zu9j/1HMlYjEnfF4M+gJ/ogQUxmCk4vowZ/mvUePyh9sF2L0CgpujV8y+SV8N/TgqY/q JyXWUpG7TMUII0kaMOaBFgwB1rQH2v3Ipy81QZOf/jUHMzErAWl01DD+754yJQ2MiX/w xcQVl7p9bJINJms8JqzapFqEAhsN8Oa3LHoHsKH7CcND+vjoUkhqYseWTlZm1SqtyiA2 hZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=silCjUTkNwNx+3UwQI81OMyeGWjZwBo8XeLo7Lu/1cY=; b=fcuXmay7pYLV5o4XEJMVu5yIUkfWgn+JuDOg5xQZOGgDO98sFPREO9ggUBgbdqQ87D qRI+y70wB6EwQoAhix1gXN20FYkl4J2+klnlkgIst+99CwbhP4byZQhYkW2mhNJBIdwI +EVIS7CZvmtQCNkOAvTnCF+Oq5oo5xmuyg3YOwww5gwG7jcss9SawcJ1nGrw9Kz49AqF 2fDCQG35lqmt4spWsIfCvsdbL5OthTHzNnsFcePBA0SlaNWvuPH6ux4ptq9tYRZqdRus aVro8FCUcpZAqSuUnPPz9qV2Yf/SoSj03i8goz8Chfpj4bJaERET3rWldtVgSucy2NlK S6sQ== X-Gm-Message-State: ALyK8tKK5ilU1NNSyR2IkV06bSEe5MQCINwY3QTFfvjCdS+UgMsXpvjFiYZ+wBFVgMTy/+Colm8GNeLLB6Cd3Q== X-Received: by 10.202.207.16 with SMTP id f16mr13203554oig.178.1467837556039; Wed, 06 Jul 2016 13:39:16 -0700 (PDT) Original-Received: by 10.157.4.197 with HTTP; Wed, 6 Jul 2016 13:39:15 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: utIA_jCk0SdH7DlrK3PLBXLZ9f8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120533 Archived-At: On Thu, Jun 30, 2016 at 11:07 PM, Drew Adams wrote: >> >> Do you have a list of things that you think should be aligned? >> > >> > No, but diff of the source code should show it. ;-) >> >> I tried diffing pp.el and elisp-mode.el, but it was unenlightening. >> Like this bug report. > > Yes, well, it's quite difficult. Some of the code from lisp-mode.el > was moved to elisp-mode.el. And then it was modified, in some cases > radically. Dunno why, except that some of the changes seem to have > involved integrating eldoc. But most of the changes presumably do not > concern this bug, which is only about the part of lisp-mode.el that > had functions that correspond to pp.el functions.) > > ===> The starting point is `eval-last-sexp', which used to correspond > directly with `pp-eval-last-sexp'. The former was (presumably) > improved, but the latter was not modified similarly. > > Some functions were renamed to add the prefix `elisp-' or `elisp--' > (e.g. `elisp--preceding-sexp', `elisp--eval-last-sexp', > `elisp--eval-last-sexp-print-value', `elisp--eval-last-sexp-fake-value', > `elisp--eval-defun-1', `elisp--eval-defun'), so knowing that can help. > In some cases they were just renamed. In other cases the code was > changed quite a bit. But again, this bug is only about the pp-like > code. > > This is not something you will understand in 5 minutes. It likely > requires understanding the changes that were made to `eval-last-sexp' > and its supporting functions, and then doing the right thing (not > necessarily exactly the same thing) for `pp-eval-last-sexp'. The > pp.el code was slightly different from the Emacs 24.4 (and prior) > lisp-mode.el code (different helper functions, and one does not > involve pretty-printing), but they generally mirror one another. > Using their former correspondence as a guide should help. > > I cannot help more than this. It is unfortunate that the person > who changed the non-pp version did not think to act similarly for > the pp version. I discovered it late, myself. Once things are > properly understood, perhaps the code fix will be minor. Dunno. But do you know of any concrete cases where there is a difference in behaviour? Or is this report just about code duplication (or lack thereof)? I found #10495 "pp-eval-last-sexp doesn't work on a `symbol' in quotes", but that was reported against 24.0.92, so perhaps these functions were in fact never "aligned"?