From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#10980: GNU bugs information: logs for bug#10980 Date: Tue, 21 Jun 2016 17:03:21 -0400 Message-ID: References: <83twh3r5vr.fsf@gnu.org> <83d1na7jtx.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1466543069 32032 80.91.229.3 (21 Jun 2016 21:04:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jun 2016 21:04:29 +0000 (UTC) Cc: bo.johansson@lsn.se, 10980@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 21 23:04:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFSqF-0005XJ-3g for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 23:04:15 +0200 Original-Received: from localhost ([::1]:54239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFSqE-0006OO-7a for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 17:04:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFSq7-0006O4-TG for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 17:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFSq2-00005w-TN for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 17:04:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFSq2-00005s-Q0 for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 17:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFSq2-0006RY-E1 for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 17:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2016 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10980-submit@debbugs.gnu.org id=B10980.146654300924723 (code B ref 10980); Tue, 21 Jun 2016 21:04:02 +0000 Original-Received: (at 10980) by debbugs.gnu.org; 21 Jun 2016 21:03:29 +0000 Original-Received: from localhost ([127.0.0.1]:50094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFSpV-0006Qh-Jr for submit@debbugs.gnu.org; Tue, 21 Jun 2016 17:03:29 -0400 Original-Received: from mail-oi0-f53.google.com ([209.85.218.53]:35030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFSpT-0006QR-Nz for 10980@debbugs.gnu.org; Tue, 21 Jun 2016 17:03:28 -0400 Original-Received: by mail-oi0-f53.google.com with SMTP id r2so3751138oih.2 for <10980@debbugs.gnu.org>; Tue, 21 Jun 2016 14:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9Nzz0/HbeiV/b95qf9goF169oLWXbOQI3QJB/zh9byo=; b=BTA4Y2NHIvbMG8F0qBF+/quQu30lUWsj19CfCb2wYcphjul44TbOExEKDu9Vz7biw7 4XvAaUGCGvCfxwsmKfSh0vHBpEsmm5EPGMbG0sGtk9463w974EnMTqNfTe4jWodTH2Fm 0tLM6NusVwsjhbluGQPuZM3EYCGf9QKIRZHXYYwEUuQhyE90bIn+3wgdU/ECXZLYQgVj hnLWfNWsCDBGnsbkvNmyNRXy+B5FSLk4Iub2RHHbtR5o36kltTbKgepRhVPi8t5wXj04 EZg4kvRCSot90npkdTKZ8I6cXO54iiTPpa4HClrZLSMS373EtNafZEZA7hnkWkZ3kNWX kkhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9Nzz0/HbeiV/b95qf9goF169oLWXbOQI3QJB/zh9byo=; b=HbCZ+lySa3BlO5ubu1rwS2EBswcmT1VinJ+egbn/vsTAzd1UkNLl/uM26LLf3+VZly vzV2jaTPmRTCycfSlQrtN1KApmf+W8A8FF/kUbZgVpcU5Ho2gT8bzUAsfIlEy+rvVgbL 3ayEkwUuMajbRYFGC11iZqvwNSbeYRFuCNLymAVl40pAX2iXTyos4TrWAbjSYyir4MjP P5G1vwVRsLgRJBTKvP8sLrhGsBwKwSeoGmia9kE7bmlFZqkGZ91jwVMtzo4pFqwOkj+n bpXL0MM0IbYRjWwvLWnPN71DxX8m46cIUGZoxmMT1FMeKsC/pFOAT4XH7w49j/JgFGan Ms3A== X-Gm-Message-State: ALyK8tJa4TuKS8dHmis8pMPC1ZoLsN9NXp2pgQiqVIQvJMk4YxTlBEmgUklfbuXCOgiLBKVU/SSDBWbKVfIg0Q== X-Received: by 10.157.49.119 with SMTP id v52mr17974654otd.134.1466543001957; Tue, 21 Jun 2016 14:03:21 -0700 (PDT) Original-Received: by 10.157.52.238 with HTTP; Tue, 21 Jun 2016 14:03:21 -0700 (PDT) In-Reply-To: <83d1na7jtx.fsf@gnu.org> X-Google-Sender-Auth: DNwA0BRfNdmWOt_kkAxNXZQd8Nw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119902 Archived-At: On Tue, Jun 21, 2016 at 9:27 AM, Eli Zaretskii wrote: >> How about splitting apart initialization of Vinitial_environment and >> Vprocess_environment and moving the former earlier so that it's >> unaffected by Emacs' manipulations of the environment? See attached >> patch. > > Thanks. However, I wonder if we could do better. First, your patch > only fixed initial-environment, which means Lisp applications will > need to explicitly use it, and probably only on Windows, Well, Lisp applications that want the environment as Emacs originally received it will use initial-environment regardless of platform (without the patch, on Windows, they get an environment with some modifications from Emacs). > that is not the best solution, IMO. I hoped we could come up with a > way of pushing the additional variables into Emacs's own environment > after Vprocess_environment is already computed -- can you try doing > that? I feel like I'm missing some important point here. If these environment variables won't affect subprocess environments, why set them at all? > > In any case, the reasons for calling the same function twice in two > different places should be explained, at least in the comments, or > else someone might become confused at some future point in time. Right. > Better yet, perhaps only the Windows build should do something like > that, and the other platforms could continue using the current code > mostly unaltered, as they don't need this. Isn't it simpler to do the same thing on all platforms? They don't need a different approach, but it doesn't hurt either.