From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33263: 27.0.50; Tidying up Gnus modes Date: Tue, 6 Nov 2018 11:28:17 -0500 Message-ID: References: <875zxbipby.fsf@gmail.com> <87o9b3za3p.fsf@ericabrahamsen.net> <8736seibdv.fsf@gmail.com> <877ehs1bgq.fsf@ericabrahamsen.net> <87k1lqw510.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1541521658 19255 195.159.176.226 (6 Nov 2018 16:27:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2018 16:27:38 +0000 (UTC) Cc: 33263@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 06 17:27:34 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK4CT-0004tl-JM for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 17:27:33 +0100 Original-Received: from localhost ([::1]:41968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK4EZ-00009a-Ur for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 11:29:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK4EN-000051-2M for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 11:29:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK4E4-0007A7-ID for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 11:29:16 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK4Du-00075P-KF for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 11:29:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gK4Du-0006lq-Bn for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 11:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33263 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33263-submit@debbugs.gnu.org id=B33263.154152171825996 (code B ref 33263); Tue, 06 Nov 2018 16:29:02 +0000 Original-Received: (at 33263) by debbugs.gnu.org; 6 Nov 2018 16:28:38 +0000 Original-Received: from localhost ([127.0.0.1]:37534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK4DW-0006lE-G0 for submit@debbugs.gnu.org; Tue, 06 Nov 2018 11:28:38 -0500 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:39798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK4DT-0006l1-Jo for 33263@debbugs.gnu.org; Tue, 06 Nov 2018 11:28:37 -0500 Original-Received: by mail-ot1-f54.google.com with SMTP id g27so11958162oth.6 for <33263@debbugs.gnu.org>; Tue, 06 Nov 2018 08:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AaJS+5loYqjd5S4M/ATSi0FAHw8d6e8TNllWth0Kzc0=; b=p6JZpbf2OGcl86QsoNwlik8oTdxl6gJr0Dm8iX/RWDb72bA+l6+srg4dKYlEXVMG2F SJ8XB/T25m0OyO+OMy2gFc7SiV1ope0pNUrRiiDsxgTknE1Ktlr4Bz051CwXAjvDdxUc gOQLkA5GCNjCjZRakaAnIsorLCX0ohe50KgWH9LKqv4XFYM10ECWY9R4lsn0b7gzTYK6 lLVkKVpj21KejNVeIRAtgNRRE3pYh4bYad8KAALNRBM1HNI2eIew3cMzUiVH/S+k1jTA JfJDb3C8M1xm3StANOeFOkmpSqTJs0VxTUo/S0Mik9DEDRweIJ/uNCD7V14X/kpKxgjr Hnbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AaJS+5loYqjd5S4M/ATSi0FAHw8d6e8TNllWth0Kzc0=; b=EPwMEWl+30bx/MTqdUGlfvG389X6uUsmWnht5qnPuOY43MDGxV31k7B7lV23L5jCmZ +IXyXetQ3lAOW+YjkK5HX6ZXz2Abavz0l1gU6NlMXiIQUP3Js5Nkwu32KhJEdNpLWaGo ZRccPrSdnMcnef5D1Ahi+p3r9TY4wxwWHBx5J+Jpex1TBBpI0gayq8t+iI5p5y1Etfi5 R2SARaNo41tY/XEk19kvz93iAc3cBQ9QqsycEeTmxhPm5TpVg5MoU38DjofdEOBN4I9K rcfgzJQKlsFwbc2FPkg14A4UJUJgFwXfdfFOncxVq6MUbAg/7osBr8dqSWLGSbP9aFpN PYcw== X-Gm-Message-State: AGRZ1gL5g9lxejIMv+xOIoVbzVkpK66ugOf62LeltIVxMRIg7Jk2W9Hv NVm5YJMLJkFYgag0051jXu8nbn2qj+DSU1i8//A= X-Google-Smtp-Source: AJdET5ccrXjgUT4xz4hZ0c1QU20JmLXa2CojnwfYCr5VDAhVhUqTX3WvbAxzuCo5hMeY+RWJAEwD2QgyjhUulhQwPns= X-Received: by 2002:a9d:38ca:: with SMTP id k10mr17428277ote.72.1541521709855; Tue, 06 Nov 2018 08:28:29 -0800 (PST) In-Reply-To: <87k1lqw510.fsf@ericabrahamsen.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152105 Archived-At: On Tue, 6 Nov 2018 at 11:22, Eric Abrahamsen wrote: > >>>> +(defvar gnus-browse-mode-map (make-keymap)) > >>>> > >>>> (unless gnus-browse-mode-map > >>>> - (setq gnus-browse-mode-map (make-keymap)) > >>>> + (defvar gnus-browse-mode-map (make-keymap)) > Right, I got that much, I was mostly wondering why the `unless' -- it's > unlikely these files would be loaded multiple times, and even if they > were, that wouldn't break anything, would it? Without the `unless', if the user had made changes to gnus-browse-mode-map they would be lost upon reload (as you say, it's not especially likely to happen, but I guess the original author wanted to preserve the semantics of the single defvar form).