From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#21072: Brave new mark-defun (and a testing tool) Date: Thu, 27 Apr 2017 17:48:06 -0400 Message-ID: References: <87o9ydrzkr.fsf@mbork.pl> <87k28sdka6.fsf@jane> <87efyze00g.fsf@jane> <87bmu2eoji.fsf@jane> <87wpcpw61w.fsf@jane> <83o9xdghmc.fsf@gnu.org> <87o9wkoald.fsf@jane> <87a881ofsu.fsf@jane> <87k272wh8x.fsf@users.sourceforge.net> <871st4aal7.fsf@jane> <87tw5l7v26.fsf@jane> <877f2hs1nw.fsf@users.sourceforge.net> <87zifa9ce5.fsf@jane> <87shl0pbcg.fsf@users.sourceforge.net> <87shky9ez8.fsf@jane> <8737cyotmt.fsf@users.sourceforge.net> <87h919yf5g.fsf@jane> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1493329753 20004 195.159.176.226 (27 Apr 2017 21:49:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Apr 2017 21:49:13 +0000 (UTC) Cc: 21072@debbugs.gnu.org, Stefan Monnier To: Marcin Borkowski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 27 23:49:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3rHf-00054L-2v for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Apr 2017 23:49:07 +0200 Original-Received: from localhost ([::1]:34344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3rHk-0008Ll-VW for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Apr 2017 17:49:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3rHe-0008Ld-S9 for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2017 17:49:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3rHb-0005N6-05 for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2017 17:49:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45119) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3rHa-0005Ms-Qb for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2017 17:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d3rHa-00067q-G7 for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2017 17:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2017 21:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21072-submit@debbugs.gnu.org id=B21072.149332969523493 (code B ref 21072); Thu, 27 Apr 2017 21:49:02 +0000 Original-Received: (at 21072) by debbugs.gnu.org; 27 Apr 2017 21:48:15 +0000 Original-Received: from localhost ([127.0.0.1]:43318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3rGo-00066r-Td for submit@debbugs.gnu.org; Thu, 27 Apr 2017 17:48:15 -0400 Original-Received: from mail-io0-f170.google.com ([209.85.223.170]:32967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3rGm-00066d-NG for 21072@debbugs.gnu.org; Thu, 27 Apr 2017 17:48:13 -0400 Original-Received: by mail-io0-f170.google.com with SMTP id k87so37547705ioi.0 for <21072@debbugs.gnu.org>; Thu, 27 Apr 2017 14:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+KSs06qTdz/9AWplIVaNLzyUq6ob3bDbLmgL/myhym4=; b=WLPairr8jEwWFvZO/8tesYdvc06tBxnF5GTE33Tzt+CMdzaNeVcOSZwNM/m7e/RP+C QSQ380oa7733anPa28Bf/1Y2B0MuqAxjMzJu+qTNVy+XTDfsu4Y+0vFRXGtFmZP1PsGG phqXNyesRhgIL3UXXlWKvzjaoN3CF7c9jr1eWUx+8z9MqLW4RVn4fmexAijL5m8NZQvp dKlsH/pnw0Bfvtzc0TRaLI7pznLfALrxQVmUSh/ypAwmV4x36vpTzjLw4O+0+P3t7JP0 xlcUNd/+I19SsRD5/sfOMx9hrYYiTWtawdjGQOsCORyckHzZjAF5D0+R/7P3UOGUgcWz jH+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+KSs06qTdz/9AWplIVaNLzyUq6ob3bDbLmgL/myhym4=; b=sp81Xw/wzFl/6m332FW4TtAaEjuudvCAMwCT7FWOKuhyTOvrNnkVONLzK/r2AVax/6 XoXJiQl3DSvuXmKdUp3nmyMg56F70z8yBWR+ODDEJOEMDfsaJB93DTwJ1SuxJ+EhnuXy aWxgX2m0QsvDRNkuMza5NH/v2/aGEhnoCMuvt742VR8EpDFpkKlqIPSjM56A8oJhLukO G4kgBzltGjmVc1wdAINJOsZElC2lGczz9yxiqPXOA+ZQT0r0E9srcwrFk0z/c8UueETX Ry2nXpnbWIgKZ1xeL9kj3mIxJkQNhTMmaf+1+pMwsxEdM+XFRrzc7SVvAE3hWMgvm+9K lRdg== X-Gm-Message-State: AN3rC/5la6TTzjuLWQzIVKcjWdDsaE1oJeAnOMftbVxDC67rPe35eQES yMtP3+j1AMYksCJvs8ni7L9wVrr9AQ== X-Received: by 10.157.33.98 with SMTP id l31mr3769282otd.245.1493329686773; Thu, 27 Apr 2017 14:48:06 -0700 (PDT) Original-Received: by 10.157.25.10 with HTTP; Thu, 27 Apr 2017 14:48:06 -0700 (PDT) In-Reply-To: <87h919yf5g.fsf@jane> X-Google-Sender-Auth: s0VrvwqQnY4s82JcIjqkRPG43Gw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132065 Archived-At: On Thu, Apr 27, 2017 at 12:43 PM, Marcin Borkowski wrote: > > On 2017-04-24, at 14:52, npostavs@users.sourceforge.net wrote: > >> Actually, now that I've applied this thing properly, I notice 2 test >> failures in batch mode: >> >> 2 unexpected results: >> FAILED mark-defun-arg-region-active >> FAILED mark-defun-no-arg-region-active >> >> They pass when run in interactive mode (I haven't looked into why). > > Strangely enough, they also fail with my original code. Does anyone > have any idea why that might be the case? Oh I see what it is, your test depends on `transient-mark-mode' being enabled. With --batch, that defaults to nil. Should we be testing in both modes or just explicitly set it to t? PS I noticed some problems with elisp-tests-with-temp-buffer while looking at this, I pushed a fix to fix/bug-21072 [1: 04741f0]. 1: 2017-04-27 17:38:09 -0400 04741f02cca95147581e05cb49b54e6dbf8bed56 Fix elisp-tests-with-temp-buffer compilation