From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#23574: 24.5; Overzealous underlining in emacs-nox Date: Sun, 5 Jun 2016 15:13:00 -0400 Message-ID: References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1465154068 10376 80.91.229.3 (5 Jun 2016 19:14:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Jun 2016 19:14:28 +0000 (UTC) Cc: 23574@debbugs.gnu.org, John Mastro , cwoodbury@azavea.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 05 21:14:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9dV4-0007tY-82 for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 21:14:18 +0200 Original-Received: from localhost ([::1]:38328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9dV3-0006ln-8u for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 15:14:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9dUu-0006jQ-Ik for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 15:14:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9dUp-0000MT-50 for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 15:14:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9dUp-0000MP-1S for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 15:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b9dUo-0005Xj-US for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2016 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23574-submit@debbugs.gnu.org id=B23574.146515398921210 (code B ref 23574); Sun, 05 Jun 2016 19:14:02 +0000 Original-Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 19:13:09 +0000 Original-Received: from localhost ([127.0.0.1]:55892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9dTw-0005W0-KK for submit@debbugs.gnu.org; Sun, 05 Jun 2016 15:13:08 -0400 Original-Received: from mail-oi0-f45.google.com ([209.85.218.45]:34232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9dTu-0005VU-DH for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 15:13:06 -0400 Original-Received: by mail-oi0-f45.google.com with SMTP id e72so197767175oib.1 for <23574@debbugs.gnu.org>; Sun, 05 Jun 2016 12:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5h6N3Xu3EdMPmNm61OXuM+EE5EnOiax2HdnoMlhq8ZQ=; b=aKt6iJb8DuI8/pwnsmjFP5cLnuXsZcsuiWfZPPa9tORLz9NF7bAZxWjvTVh3vJJXNr xdDJCuoPIaeBaac8Xx7pONZ7qGyNLfP2tDojWHCXrHFOmp0HFKH3mYpkjseGJ3J9gizC HWs4hs51Bo8hyHhVIgor274PFWXu7m9M9T85DGxf9T/ZSxiYv4qw5dWu4iRyIgtHPicx uO/nj9qudkUa7ojswqBzqIZuBWuTRwK1a6pJ2+WzDiXy6fgLyX3TkknO241j3ryfOWL8 D1JnO8PyKN8FQckvSBvFh3mglXbutgXpzdPVSYNV2A5YcKdW5DuOyy9jUNkl21CNcusJ jLhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5h6N3Xu3EdMPmNm61OXuM+EE5EnOiax2HdnoMlhq8ZQ=; b=PXd6fg3RzFp4C84+PptZfVSlZ85UK0n2Da7kfJgln1SwyurjrCUPT676jg5sr1ERB4 HhXbDbvwdoHKm3pYaN1NUk8CfFMyhBmFgPeEjMAWIik8Gyl0/hTYBsZWQFoGFw5lbxEU N090cMMqCjxJuW6v1bxduQ3CsU54XoePvDXV4DfcGl33Ql60BjT9YQSm7u2bX0J9m6kd aF7Tiwa/Oc02fSnW4K1sgIXx0ZwuZeD0O3l186TXaRNZdAjREKn+tJyVo2E208Atvisl A8UvsTEy8VsbvDwIiTUUoXi3cqu3PhFYFtOtCXdipZlz0NsjdJVgpy224Oej8b4yX1ZZ AgvQ== X-Gm-Message-State: ALyK8tLSBL+53XoRtOGeEup2xdbrWYP9RHC12ot7897BvZMQVHqs8i+IqWJnkRZMA/yS6NV51XGSjHDCJpU9Qw== X-Received: by 10.157.23.195 with SMTP id j61mr7557183otj.92.1465153980816; Sun, 05 Jun 2016 12:13:00 -0700 (PDT) Original-Received: by 10.157.5.168 with HTTP; Sun, 5 Jun 2016 12:13:00 -0700 (PDT) In-Reply-To: <83twh7tt83.fsf@gnu.org> X-Google-Sender-Auth: cesdxdjJB5omYNezSYsAbmNn63Q X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119126 Archived-At: On Sun, Jun 5, 2016 at 1:56 PM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Sun, 5 Jun 2016 13:05:53 -0400 >> Cc: John Mastro , 23574@debbugs.gnu.org, cwoodbury@azavea.com >> >> On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii wrote: >> > We always try to make the empty space >> > after the end of a screen line have the same face as the last >> > character of that line. >> >> Just to clarify, "last character of that line" refers to the newline >> character or the one before it? > > The last displayed character of the line. The newline is not > displayed, in the sense that it has no glyph, so it can have no face. That doesn't seem to be the case, with the following modification to the recipe so that the newline characters are not underlined, the underlining does not continue to the edge of the screen: (let (beg end ov) (defface example-underline-face '((t :underline t)) "Example face with underlining") (goto-char (point-max)) (newline) (setq beg (point)) (insert " foo") (setq end (point)) (setq ov (make-overlay beg end)) (overlay-put ov 'face 'example-underline-face) (insert "\n") (setq beg (point)) (insert " bar") (setq end (point)) (setq ov (make-overlay beg end)) (overlay-put ov 'face 'example-underline-face) (insert "\n")) > >> > While it should be >> > possible to have GUI frames display underline all the way to window >> > edge, no one has ever requested that, so we didn't bother. >> >> I think this would have been useful for magit to simplify the use of >> overlays to display the region with horizontal lines. > > This is doable (and in fact we already do that in R2L paragraphs, > which you can observe if you change the recipe's text to use R2L > characters). Yes (though it seems R2L is disabled in programming modes by default, needed to use fundamental-mode buffer to see the effect). >> In http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21468#43 you >> suggested a way using :align-to which turned out to have a bunch of >> complications and magit ended up not using it (see >> https://github.com/magit/magit/pull/2293). > > Did you try using the box attribute of a face? Yes, but magit actually wants a multiline box (without internal lines), so it didn't really work out (anyway, this is getting off-topic for this bug).