bug#21419: isearch does not exit cleanly when ido active

bug#21419: isearch does not exit cleanly when ido active

[Ista Zahn]

When ido mode is active some isearch commands are not exited properly, and
the isearch face remains active. To reproduce:

1. Start emacs with "emacs -Q"
2. Turn on ido mode with "M-x ido mode"
3. Select buffer contents and copy with "C-x h M-w"
4. Run "M-x isearch-yank-kill" followed by "C-g"

Results: buffer contents remains font-locked with isearch face.
Expected result: the final "C-g" should have exited from isearch mode,
as happens when ido mode is not active. Note that this bug does not
occur when step 2 above is omitted.

In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.2)
 of 2015-04-20 on bitzer.hoetzel.info
Windowing system distributor `The X.Org Foundation', version 11.0.11702000
Configured using:
 `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --with-x-toolkit=gtk3 --with-xft
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
 --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Ido mode enabled
Mark set [3 times]
Quit [2 times]

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils ido time-date tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 84418 6670)
 (symbols 48 17938 0)
 (miscs 40 48 113)
 (strings 32 17619 4577)
 (string-bytes 1 397448)
 (vectors 16 9348)
 (vector-slots 8 387292 14153)
 (floats 8 73 286)
 (intervals 56 201 22)
 (buffers 960 11)
 (heap 1024 25601 1292))

bug#21419: isearch does not exit cleanly when ido active

[Noam Postavsky]

Ista Zahn <istazahn <at> gmail.com> wrote:
> Results: buffer contents remains font-locked with isearch face.
> Expected result: the final "C-g" should have exited from isearch
> mode, as happens when ido mode is not active.

I'm seeing the font-lock leftovers from isearch remaining without
ido-mode being active as well.

I think isearch-yank-kill is not intended as an entry point. Perhaps
it should have something like (unless isearch-mode (user-error
"isearch not active!"))
Or maybe
(unless isearch-mode (isearch-mode t))

bug#21419: isearch does not exit cleanly when ido active

[Noam Postavsky]

severity 21419 minor
tags 21419 fixed
close 21419 27.1
quit

Noam Postavsky <npostavs@users.sourceforge.net> writes:

> I think isearch-yank-kill is not intended as an entry point. Perhaps
> it should have something like (unless isearch-mode (user-error
> "isearch not active!"))
> Or maybe
> (unless isearch-mode (isearch-mode t))

I've done the latter in master.

[1: 9966842a21]: 2018-06-07 08:42:55 -0400
  Let isearch-yank-kill enable isearch-mode if needed (Bug#21419)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9966842a2166d42cb6969b6bbc5154960d1252bc