From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist Date: Mon, 8 Apr 2019 14:34:41 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a10e360586091718" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46313"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33016@debbugs.gnu.org To: Klaus-Dieter Bauer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 08 20:36:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDZ81-000BsA-3z for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 20:36:21 +0200 Original-Received: from localhost ([127.0.0.1]:57221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDZ80-0004N9-1V for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 14:36:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDZ6m-0003PW-NP for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 14:35:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDZ6l-0003ka-Ln for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 14:35:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36634) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDZ6k-0003jV-Q8 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 14:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDZ6k-0002Jy-IS for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 14:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2019 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33016 X-GNU-PR-Package: emacs Original-Received: via spool by 33016-submit@debbugs.gnu.org id=B33016.15547485018911 (code B ref 33016); Mon, 08 Apr 2019 18:35:02 +0000 Original-Received: (at 33016) by debbugs.gnu.org; 8 Apr 2019 18:35:01 +0000 Original-Received: from localhost ([127.0.0.1]:50178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDZ6j-0002Jf-2U for submit@debbugs.gnu.org; Mon, 08 Apr 2019 14:35:01 -0400 Original-Received: from mail-ot1-f49.google.com ([209.85.210.49]:34611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDZ6h-0002JP-Jz for 33016@debbugs.gnu.org; Mon, 08 Apr 2019 14:35:00 -0400 Original-Received: by mail-ot1-f49.google.com with SMTP id k21so13163659otf.1 for <33016@debbugs.gnu.org>; Mon, 08 Apr 2019 11:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UhE2mPbSe5akH5Xtz6cswOmB0/U2E4ICDvO05ot3JiA=; b=iDxu9894gGvCPWYFOHVWMBmLeBNnv+g1NNPJtca2/heUBsHKXn1t0LbPZrAY8j/wyB IUEpFZOFrCxRSi4PCZ1Wr57+6EW6NGeeywryWIzsKVbxXeCZT31/LjT2bcDXuXbx1koY zdvhqkH/OR2dTWAxnjrtVWapIrCWl7m5kyWkEVE+MaGODV2RWLa2kKCMFld4RqZrN8Kg 7DWJwmjSzzRjqRacz/xgT5ZoGLCVS1OasZP2/j7+hwI4ft+tGhz21QkGek9Ai7pwEJsg 2wGAHFG4De9xaWvTPIvFpHUOWrfsPga045v2NcEeQ0CfWbmBwRX1ReIv+7WgD+1ijFvd 4OmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UhE2mPbSe5akH5Xtz6cswOmB0/U2E4ICDvO05ot3JiA=; b=K2zk6eTZYdy4b1cNqsSduz2hDuC9WUFMaQ6cqKXNuSZgMj62zcc2F/Iu8+9cR/mHwe Nu21V+G3zQ8JB+9kKmHBHxjdcki4obZ5y3u2eNplITqMP1ka1vzPICmlbzrBDNxYd8nh HPwASEoGvUkn0KCGMaVBCn5xK7bQEGPi7TlKgbrSOeicnWbNyIhkmJI6oy5QD05edlVb 63X7Rm0tRjXDuUSPYStofGNvw36Kz5RK83bIE1ASowajpd2iKnIjrfDcCu+Ilp60mI6y EoTP03105hSwWty1hwh2ycpwAJHUhONrQgIReRk4g2NSQDUXkFQ1RLd5zXyaKndZn4N0 e1bg== X-Gm-Message-State: APjAAAUpS2ef8KNhJJSNR4oK7p3jqlZKjMbJ2uLwyF2HUDEUWsAGqQns H2EU2BHEV6D/a9fCMya2FrxR4zMaNNNWvqJunzE= X-Google-Smtp-Source: APXvYqxxa4QfTMgck8w7/uy8DxJg3Tt1Nk5XlyT2o8m+setxDIXx/YwBwqTUCOSlSxgupf75w2J8JQjsyEMgvIeBGIE= X-Received: by 2002:a9d:7749:: with SMTP id t9mr20846542otl.229.1554748492803; Mon, 08 Apr 2019 11:34:52 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157356 Archived-At: --000000000000a10e360586091718 Content-Type: text/plain; charset="UTF-8" On Thu, 11 Oct 2018 at 08:57, Klaus-Dieter Bauer wrote: > M-x eval-expression RET > (make-process :name "test" :command '("c:/No Such Command")) > > will merely display in the echo-area message: > > eval: Spawning child process: Invalid argument The confusing thing here is that the error is signaled between block_input()...unblock_input(), which prevents the debugger from triggering. E.g., the "-unless-debug" part in the expression below appears not to work, even though the error flows normally in other respects: (condition-case-unless-debug err (make-process :name "test" :command '("c:/No Such Command")) (error (list :error err))) ;=> (:error (file-error "Spawning child process" "Invalid argument")) The attached patch fixes this by moving the signal to after the unblock_input(). --000000000000a10e360586091718 Content-Type: application/octet-stream; name="v1-0001-Let-debugger-handle-process-spawn-errors-on-w32-B.patch" Content-Disposition: attachment; filename="v1-0001-Let-debugger-handle-process-spawn-errors-on-w32-B.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ju8p0vp60 RnJvbSBkODcxNmMxNDA2MzAxNTEyZmJiZmNlN2YxZWViNDVmYzhkNTMxZmQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBNb24sIDggQXByIDIwMTkgMTM6MTY6MzggLTA0MDAKU3ViamVjdDogW1BBVENIIHYxXSBM ZXQgZGVidWdnZXIgaGFuZGxlIHByb2Nlc3Mgc3Bhd24gZXJyb3JzIG9uIHczMgogKEJ1ZyMzMzAx NikKCldoZW4gYW4gZXJyb3IgaXMgc2lnbmFsZWQgYmV0d2VlbiBibG9ja19pbnB1dCgpLi4udW5i bG9ja19pbnB1dCgpLCB0aGUKTGlzcCBkZWJ1Z2dlciBpcyBwcmV2ZW50ZWQgZnJvbSBzdGFydGlu Zy4KKiBzcmMvY2FsbHByb2MuYyAoY2hpbGRfc2V0dXApOiBNb3ZlIHRoZSByZXBvcnRfZmlsZV9l cnJvciBjYWxsIGZyb20gaGVyZS4uLgoqIHNyYy9wcm9jZXNzLmMgKGNyZWF0ZV9wcm9jZXNzKSBb V0lORE9XU05UXTogLi4uIHRvIGhlcmUsIGFmdGVyIHRoZQp1bmJsb2NrX2lucHV0KCkgY2FsbC4K LS0tCiBzcmMvY2FsbHByb2MuYyB8IDcgKystLS0tLQogc3JjL2xpc3AuaCAgICAgfCA2ICsrKysr Kwogc3JjL3Byb2Nlc3MuYyAgfCAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygr KSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvY2FsbHByb2MuYyBiL3NyYy9jYWxs cHJvYy5jCmluZGV4IGZhMTJkMDIuLmEwMTEyNTAgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxscHJvYy5j CisrKyBiL3NyYy9jYWxscHJvYy5jCkBAIC02OTUsNyArNjk1LDcgQEAgY2FsbF9wcm9jZXNzIChw dHJkaWZmX3QgbmFyZ3MsIExpc3BfT2JqZWN0ICphcmdzLCBpbnQgZmlsZWZkLAogICB1bmJsb2Nr X2lucHV0ICgpOwogCiAgIGlmIChwaWQgPCAwKQotICAgIHJlcG9ydF9maWxlX2Vycm5vICgiRG9p bmcgdmZvcmsiLCBRbmlsLCBjaGlsZF9lcnJubyk7CisgICAgcmVwb3J0X2ZpbGVfZXJybm8gKENI SUxEX1NFVFVQX0VSUk9SX0RFU0MsIFFuaWwsIGNoaWxkX2Vycm5vKTsKIAogICAvKiBDbG9zZSBv dXIgZmlsZSBkZXNjcmlwdG9ycywgZXhjZXB0IGZvciBjYWxscHJvY19mZFtDQUxMUFJPQ19QSVBF UkVBRF0KICAgICAgc2luY2Ugd2Ugd2lsbCB1c2UgdGhhdCB0byByZWFkIGlucHV0IGZyb20uICAq LwpAQCAtMTE4OSw3ICsxMTg5LDcgQEAgZXhlY19mYWlsZWQgKGNoYXIgY29uc3QgKm5hbWUsIGlu dCBlcnIpCiAgICBleGVjdXRhYmxlIGRpcmVjdG9yeSBieSB0aGUgcGFyZW50LgogCiAgICBPbiBH TlVpc2ggaG9zdHMsIGVpdGhlciBleGVjIG9yIHJldHVybiBhbiBlcnJvciBudW1iZXIuCi0gICBP biBNUy1XaW5kb3dzLCBlaXRoZXIgcmV0dXJuIGEgcGlkIG9yIHNpZ25hbCBhbiBlcnJvci4KKyAg IE9uIE1TLVdpbmRvd3MsIGVpdGhlciByZXR1cm4gYSBwaWQgb3IgcmV0dXJuIC0xIGFuZCBzZXQg ZXJybm8uCiAgICBPbiBNUy1ET1MsIGVpdGhlciByZXR1cm4gYW4gZXhpdCBzdGF0dXMgb3Igc2ln bmFsIGFuIGVycm9yLiAgKi8KIAogQ0hJTERfU0VUVVBfVFlQRQpAQCAtMTMzNCw5ICsxMzM0LDYg QEAgY2hpbGRfc2V0dXAgKGludCBpbiwgaW50IG91dCwgaW50IGVyciwgY2hhciAqKm5ld19hcmd2 LCBib29sIHNldF9wZ3JwLAogICAvKiBTcGF3biB0aGUgY2hpbGQuICAoU2VlIHczMnByb2MuYzpz eXNfc3Bhd252ZSkuICAqLwogICBjcGlkID0gc3Bhd252ZSAoX1BfTk9XQUlULCBuZXdfYXJndlsw XSwgbmV3X2FyZ3YsIGVudik7CiAgIHJlc2V0X3N0YW5kYXJkX2hhbmRsZXMgKGluLCBvdXQsIGVy ciwgaGFuZGxlcyk7Ci0gIGlmIChjcGlkID09IC0xKQotICAgIC8qIEFuIGVycm9yIG9jY3VycmVk IHdoaWxlIHRyeWluZyB0byBzcGF3biB0aGUgcHJvY2Vzcy4gICovCi0gICAgcmVwb3J0X2ZpbGVf ZXJyb3IgKCJTcGF3bmluZyBjaGlsZCBwcm9jZXNzIiwgUW5pbCk7CiAgIHJldHVybiBjcGlkOwog CiAjZWxzZSAgLyogbm90IFdJTkRPV1NOVCAqLwpkaWZmIC0tZ2l0IGEvc3JjL2xpc3AuaCBiL3Ny Yy9saXNwLmgKaW5kZXggMDhjNmRiZC4uYzdlYjQ3MSAxMDA2NDQKLS0tIGEvc3JjL2xpc3AuaAor KysgYi9zcmMvbGlzcC5oCkBAIC00MjMzLDYgKzQyMzMsMTIgQEAgZXh0ZXJuIHZvaWQgc2V0dXBf cHJvY2Vzc19jb2Rpbmdfc3lzdGVtcyAoTGlzcF9PYmplY3QpOwogI2Vsc2UKICMgZGVmaW5lIENI SUxEX1NFVFVQX1RZUEUgaW50CiAjZW5kaWYKKyNpZmRlZiBXSU5ET1dTTlQKKyMgZGVmaW5lIENI SUxEX1NFVFVQX0VSUk9SX0RFU0MgIlNwYXduaW5nIGNoaWxkIHByb2Nlc3MiCisjZWxzZQorIyBk ZWZpbmUgQ0hJTERfU0VUVVBfRVJST1JfREVTQyAiRG9pbmcgdmZvcmsiCisjZW5kaWYKKwogZXh0 ZXJuIENISUxEX1NFVFVQX1RZUEUgY2hpbGRfc2V0dXAgKGludCwgaW50LCBpbnQsIGNoYXIgKios IGJvb2wsIExpc3BfT2JqZWN0KTsKIGV4dGVybiB2b2lkIGluaXRfY2FsbHByb2NfMSAodm9pZCk7 CiBleHRlcm4gdm9pZCBpbml0X2NhbGxwcm9jICh2b2lkKTsKZGlmZiAtLWdpdCBhL3NyYy9wcm9j ZXNzLmMgYi9zcmMvcHJvY2Vzcy5jCmluZGV4IDJkZjUxY2YuLmI4YjdhM2UgMTAwNjQ0Ci0tLSBh L3NyYy9wcm9jZXNzLmMKKysrIGIvc3JjL3Byb2Nlc3MuYwpAQCAtMjIwNCw3ICsyMjA0LDcgQEAg Y3JlYXRlX3Byb2Nlc3MgKExpc3BfT2JqZWN0IHByb2Nlc3MsIGNoYXIgKipuZXdfYXJndiwgTGlz cF9PYmplY3QgY3VycmVudF9kaXIpCiAgIHVuYmxvY2tfaW5wdXQgKCk7CiAKICAgaWYgKHBpZCA8 IDApCi0gICAgcmVwb3J0X2ZpbGVfZXJybm8gKCJEb2luZyB2Zm9yayIsIFFuaWwsIHZmb3JrX2Vy cm5vKTsKKyAgICByZXBvcnRfZmlsZV9lcnJubyAoQ0hJTERfU0VUVVBfRVJST1JfREVTQywgUW5p bCwgdmZvcmtfZXJybm8pOwogICBlbHNlCiAgICAgewogICAgICAgLyogdmZvcmsgc3VjY2VlZGVk LiAgKi8KLS0gCjIuNi4yLndpbmRvd3MuMQoK --000000000000a10e360586091718--