From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path Date: Mon, 5 Feb 2018 14:37:40 -0500 Message-ID: References: <874lmwfbfe.fsf@users.sourceforge.net> <83y3k773on.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a114b4448ffb07005647c31ec" X-Trace: blaine.gmane.org 1517861279 7099 195.159.176.226 (5 Feb 2018 20:07:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Feb 2018 20:07:59 +0000 (UTC) Cc: 30346@debbugs.gnu.org, ro@cebitec.uni-bielefeld.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 05 21:07:55 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ein3L-0000xE-No for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Feb 2018 21:07:47 +0100 Original-Received: from localhost ([::1]:55589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ein5L-0008Fh-3Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Feb 2018 15:09:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eimab-0004Tz-Da for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 14:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eimaY-0003h9-8I for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 14:38:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51141) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eimaY-0003h2-4L for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 14:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eimaX-0001nI-Rq for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 14:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Feb 2018 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30346 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30346-submit@debbugs.gnu.org id=B30346.15178594716880 (code B ref 30346); Mon, 05 Feb 2018 19:38:01 +0000 Original-Received: (at 30346) by debbugs.gnu.org; 5 Feb 2018 19:37:51 +0000 Original-Received: from localhost ([127.0.0.1]:59038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eimaN-0001mo-L1 for submit@debbugs.gnu.org; Mon, 05 Feb 2018 14:37:51 -0500 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:36206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eimaJ-0001mR-3c for 30346@debbugs.gnu.org; Mon, 05 Feb 2018 14:37:47 -0500 Original-Received: by mail-wm0-f46.google.com with SMTP id f3so28170423wmc.1 for <30346@debbugs.gnu.org>; Mon, 05 Feb 2018 11:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=tqPpvzelDqKDtlXr9SzRWWtiksQeXfdpeRgrgaY0yVk=; b=mQll+6Yn+Vdcm2AeLzpiGDrTAs4COIwIOEIiFYut9DNGcWWghqxPUETQAW5fgDhQj8 Iu30p9tkIFnaSDiIYjQ8pk7ucJ8613LUc8nF/jnTVEiao7bIO0HIf+IGOxc7bEXZhLY7 lQ//syyn52yxck0Ivv9myxcky3tT/qSZrvLnM4KbiA5zc13xsFxyVBIje3FRLX5pKeey 3nC1LTIP+J4rSrA1kkBHXB4hCCzQ37eZzyYhKUJFUVKgtLXQ3XttoJ0pg+7/uoKJsVMN ICF5bcfBkaCtKDmiGOYxCYneHSB/4xrQT9cWUeHbzepF5iKc0ayqZPeICOQ9gWL0aP2L lIyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=tqPpvzelDqKDtlXr9SzRWWtiksQeXfdpeRgrgaY0yVk=; b=emn6SYHZ6klVngya/dA28cueaKbLxdG/1y6Cny2gGde6/B375WyziRAk5iPZ3eWqVo diUGxfxiBiiKF2VvOL167t63lJ/RqQ1eEQyNZdS7dE7nP7JdP1J6T8rBrioyaflP2Ih7 y+ABh0K0GSbc09hwY81TydgOqGjufNt4RiEu72kV2ZMgfH56p6L5/P0mYaIVJ8l/l+3+ PWkhoJuv+f8S8u9VcecB4JeUSBIC/SbVf3hqryzSbimjFHifmL6FYx+JC9xGuO9EYdnI xVeddh9z9CbltaTPQcEhKr8HvHmth/B5U/aQC0kYI7jLfN59syHG5zWxnsKx7N6ZyIc7 sqwQ== X-Gm-Message-State: APf1xPC5G8hmhHyL20iYFTNYUefP/sYrVtdc7tO+l9YLxf6oF35EHabI zkeAaMdeOLXUNPskfJ+aK5RF8chxsn/MKCw/LnM= X-Google-Smtp-Source: AH8x226AHtZwKs/mKNHFv/EFhn3S0ptajVeN9lUphmGLwUA0a9DTgNph+kGPB5ewxjsmvWIsUwMvaSm1ddhcPoN2y5c= X-Received: by 10.28.157.206 with SMTP id g197mr330802wme.96.1517859461103; Mon, 05 Feb 2018 11:37:41 -0800 (PST) Original-Received: by 10.223.182.69 with HTTP; Mon, 5 Feb 2018 11:37:40 -0800 (PST) In-Reply-To: <83y3k773on.fsf@gnu.org> X-Google-Sender-Auth: ZjFAX0EIYsga7yD5_HhO64knAic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142946 Archived-At: --001a114b4448ffb07005647c31ec Content-Type: text/plain; charset="UTF-8" severity 30346 minor quit On Mon, Feb 5, 2018 at 12:21 PM, Eli Zaretskii wrote: >> Does the below work? (I notice that all of a sudden this bug's severity >> has been set to "important", although it looks more like it should be >> "minor" to me. And I would intend the patch for master, not emacs-26.) > > I agree. > Maybe I'm missing something, but it looks like you effectively renamed > LIBLCMS2 to LCMS2_LIBS, so now LIBLCMS2 is set, but not used, and the > part of configure.ac that took care of the MS-Windows build, where > "-lcms2" should NOT be used at link time, now does nothing useful. > Right? Ah, you're right. Also, I think the AC_CHECK_HEADERS/LIB calls I put wouldn't work without some CFLAGS and LIBS juggling. But I guess they're redundant anyway unless we start getting reports about pkg-config of lcms2 being incorrect. New patch attached (the patch is still against emacs-26 just for convenience of OP). --001a114b4448ffb07005647c31ec Content-Type: application/octet-stream; name="v2-0001-Use-pkg-config-to-find-lcms2-CFLAGS-and-LIBS-Bug-.patch" Content-Disposition: attachment; filename="v2-0001-Use-pkg-config-to-find-lcms2-CFLAGS-and-LIBS-Bug-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jdam60ea0 RnJvbSA3NDYyMzcyNzJjNzg1N2JjNDMxZjVkY2Y5NGE0MGE2ODA5MjFkYTNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBTdW4sIDQgRmViIDIwMTggMjA6NDM6MjYgLTA1MDAKU3ViamVjdDogW1BBVENIIHYyXSBV c2UgcGtnLWNvbmZpZyB0byBmaW5kIGxjbXMyIENGTEFHUyBhbmQgTElCUyAoQnVnIzMwMzQ2KQoK KiBjb25maWd1cmUuYWM6IFVzZSBFTUFDU19DSEVDS19NT0RVTEVTIGZvcnMgTENNUzIgcmF0aGVy IHRoYW4KQUNfU0VBUkNIX0xJQlMuCiogc3JjL01ha2VmaWxlLmluOiBHZXQgTENNUzJfTElCUyBh bmQgTENNUzJfQ0ZMQUdTIGZyb20gY29uZmlndXJlLAppbnN0ZWFkIG9mIGp1c3QgTElCTENNUzIu Ci0tLQogY29uZmlndXJlLmFjICAgIHwgMTUgKysrKysrLS0tLS0tLS0tCiBzcmMvTWFrZWZpbGUu aW4gfCAgNyArKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEyIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRl eCBmOWM3YmI3Li4zMjY4OGQxIDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmln dXJlLmFjCkBAIC0zNDY3LDIzICszNDY3LDIwIEBAIEFDX0RFRlVOCiBBQ19TVUJTVChMSUJKUEVH KQogCiBIQVZFX0xDTVMyPW5vCi1MSUJMQ01TMj0KK0xDTVMyX0NGTEFHUz0KK0xDTVMyX0xJQlM9 CiBpZiB0ZXN0ICIke3dpdGhfbGNtczJ9IiAhPSAibm8iOyB0aGVuCi0gIE9MSUJTPSRMSUJTCi0g IEFDX1NFQVJDSF9MSUJTKFtjbXNDcmVhdGVUcmFuc2Zvcm1dLCBbbGNtczJdLCBbSEFWRV9MQ01T Mj15ZXNdKQotICBMSUJTPSRPTElCUwotICBjYXNlICRhY19jdl9zZWFyY2hfY21zQ3JlYXRlVHJh bnNmb3JtIGluCi0gICAgLSopIExJQkxDTVMyPSRhY19jdl9zZWFyY2hfY21zQ3JlYXRlVHJhbnNm b3JtIDs7Ci0gIGVzYWMKKyAgRU1BQ1NfQ0hFQ0tfTU9EVUxFUyhbTENNUzJdLCBbbGNtczJdKQog ZmkKIGlmIHRlc3QgIiR7SEFWRV9MQ01TMn0iID0gInllcyI7IHRoZW4KICAgQUNfREVGSU5FKFtI QVZFX0xDTVMyXSwgMSwgW0RlZmluZSB0byAxIGlmIHlvdSBoYXZlIHRoZSBsY21zMiBsaWJyYXJ5 ICgtbGxjbXMyKS5dKQogICAjIyMgbWluZ3czMiBkb2Vzbid0IHVzZSAtbGxjbXMyLCBzaW5jZSBp dCBsb2FkcyB0aGUgbGlicmFyeSBkeW5hbWljYWxseS4KICAgaWYgdGVzdCAiJHtvcHN5c30iID0g Im1pbmd3MzIiOyB0aGVuCi0gICAgIExJQkxDTVMyPQorICAgICBMQ01TMl9MSUJTPQogICBmaQog ZmkKLUFDX1NVQlNUKExJQkxDTVMyKQorQUNfU1VCU1QoTENNUzJfQ0ZMQUdTKQorQUNfU1VCU1Qo TENNUzJfTElCUykKIAogSEFWRV9aTElCPW5vCiBMSUJaPQpkaWZmIC0tZ2l0IGEvc3JjL01ha2Vm aWxlLmluIGIvc3JjL01ha2VmaWxlLmluCmluZGV4IDE1Y2ExNjYuLjlmYTFkN2IgMTAwNjQ0Ci0t LSBhL3NyYy9NYWtlZmlsZS5pbgorKysgYi9zcmMvTWFrZWZpbGUuaW4KQEAgLTIzNCw3ICsyMzQs OCBAQCBMSUJYTUwyX0NGTEFHUyA9CiAKIEdFVEFERFJJTkZPX0FfTElCUyA9IEBHRVRBRERSSU5G T19BX0xJQlNACiAKLUxJQkxDTVMyID0gQExJQkxDTVMyQAorTENNUzJfTElCUyA9IEBMQ01TMl9M SUJTQAorTENNUzJfQ0ZMQUdTID0gQExDTVMyX0NGTEFHU0AKIAogTElCWiA9IEBMSUJaQAogCkBA IC0zNjAsNyArMzYxLDcgQEAgRU1BQ1NfQ0ZMQUdTPQogICAkKEdOVVNURVBfQ0ZMQUdTKSAkKENG TEFHU19TT1VORCkgJChSU1ZHX0NGTEFHUykgJChJTUFHRU1BR0lDS19DRkxBR1MpIFwKICAgJChQ TkdfQ0ZMQUdTKSAkKExJQlhNTDJfQ0ZMQUdTKSAkKERCVVNfQ0ZMQUdTKSBcCiAgICQoWFJBTkRS X0NGTEFHUykgJChYSU5FUkFNQV9DRkxBR1MpICQoWEZJWEVTX0NGTEFHUykgJChYREJFX0NGTEFH UykgXAotICAkKFdFQktJVF9DRkxBR1MpIFwKKyAgJChXRUJLSVRfQ0ZMQUdTKSAkKExDTVMyX0NG TEFHUykgXAogICAkKFNFVFRJTkdTX0NGTEFHUykgJChGUkVFVFlQRV9DRkxBR1MpICQoRk9OVENP TkZJR19DRkxBR1MpIFwKICAgJChMSUJPVEZfQ0ZMQUdTKSAkKE0xN05fRkxUX0NGTEFHUykgJChE RVBGTEFHUykgXAogICAkKExJQlNZU1RFTURfQ0ZMQUdTKSBcCkBAIC00OTIsNyArNDkzLDcgQEAg TElCRVMgPQogICAgJChMSUJYTUwyX0xJQlMpICQoTElCR1BNKSAkKExJQlNfU1lTVEVNKSAkKENB SVJPX0xJQlMpIFwKICAgICQoTElCU19URVJNQ0FQKSAkKEdFVExPQURBVkdfTElCUykgJChTRVRU SU5HU19MSUJTKSAkKExJQlNFTElOVVhfTElCUykgXAogICAgJChGUkVFVFlQRV9MSUJTKSAkKEZP TlRDT05GSUdfTElCUykgJChMSUJPVEZfTElCUykgJChNMTdOX0ZMVF9MSUJTKSBcCi0gICAkKExJ QkdOVVRMU19MSUJTKSAkKExJQl9QVEhSRUFEKSAkKEdFVEFERFJJTkZPX0FfTElCUykgJChMSUJM Q01TMikgXAorICAgJChMSUJHTlVUTFNfTElCUykgJChMSUJfUFRIUkVBRCkgJChHRVRBRERSSU5G T19BX0xJQlMpICQoTENNUzJfTElCUykgXAogICAgJChOT1RJRllfTElCUykgJChMSUJfTUFUSCkg JChMSUJaKSAkKExJQk1PRFVMRVMpICQoTElCU1lTVEVNRF9MSUJTKQogCiAjIyBGT1JDRSBpdCBz byB0aGF0IGFkbWluL3VuaWRhdGEgY2FuIGRlY2lkZSB3aGV0aGVyIHRoZXNlIGZpbGVzCi0tIAoy LjYuMi53aW5kb3dzLjEKCg== --001a114b4448ffb07005647c31ec--