* bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25
@ 2016-03-27 12:37 david lopez villegas
2016-06-04 17:47 ` Noam Postavsky
0 siblings, 1 reply; 6+ messages in thread
From: david lopez villegas @ 2016-03-27 12:37 UTC (permalink / raw)
To: 23126
--text follows this line--
Debugger entered--Lisp error: (void-function format-message)
(format-message "Add `%s' clause? " name)
(let* ((name (symbol-name name)) (function-name (intern (concat
"python-skeleton--" name))) (msg (format-message "Add `%s' clause? "
name))) (if (not skel) (progn (setq skel (cons (quote <) (cons (format
"%s:" name) (quote (n n > _ n))))))) (cons (quote define-skeleton)
(cons function-name (cons (or doc (format "Auxiliary skeleton for %s
statement." name)) (cons nil (cons (cons (quote unless) (cons ...
...)) skel))))))
(closure (python-shell--interpreter-args python-shell--interpreter
outline-heading-end-regexp view-return-to-alist t) (name doc &optional
&rest skel) "Define a `python-mode' auxiliary skeleton using NAME DOC
and SKEL.\nThe skeleton will be bound to python-skeleton-NAME." (let*
((name (symbol-name name)) (function-name (intern (concat
"python-skeleton--" name))) (msg (format-message "Add `%s' clause? "
name))) (if (not skel) (progn (setq skel (cons (quote <) (cons (format
"%s:" name) (quote ...)))))) (cons (quote define-skeleton) (cons
function-name (cons (or doc (format "Auxiliary skeleton for %s
statement." name)) (cons nil (cons (cons ... ...) skel)))))))(else
nil)
(python-define-auxiliary-skeleton else nil)
eval-buffer(#<buffer *load*-689492> nil
"/home/user-name/.emacs.d/elpa/python-0.25.1/python.el" nil t) ;
Reading at buffer position 170847
load-with-code-conversion("/home/user-name/.emacs.d/elpa/python-0.25.1/python.el"
"/home/user-name/.emacs.d/elpa/python-0.25.1/python.el" nil t)
require(python)
eval-buffer(#<buffer *load*> nil
"/home/user-name/.emacs.d/elpa/elpy-1.11.0/elpy.el" nil t) ; Reading
at buffer position 1541
load-with-code-conversion("/home/user-name/.emacs.d/elpa/elpy-1.11.0/elpy.el"
"/home/user-name/.emacs.d/elpa/elpy-1.11.0/elpy.el" nil t)
command-execute(elpy-config record)
execute-extended-command(nil "elpy-config")
call-interactively(execute-extended-command nil nil)
If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/usr/share/emacs/24.3/etc/DEBUG.
In GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.7)
of 2014-03-07 on lamiak, modified by Debian
System Description: Trisquel GNU/Linux 7.0, Belenos
Configured using:
`configure '--build' 'x86_64-linux-gnu' '--build' 'x86_64-linux-gnu'
'--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
'--localstatedir=/var/lib' '--infodir=/usr/share/info'
'--mandir=/usr/share/man' '--with-pop=yes'
'--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3/site-lisp:/usr/share/emacs/site-lisp'
'--with-crt-dir=/usr/lib/x86_64-linux-gnu' '--with-x=yes'
'--with-x-toolkit=gtk3' '--with-toolkit-scroll-bars'
'build_alias=x86_64-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall'
'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro'
'CPPFLAGS=-D_FORTIFY_SOURCE=2''
Important settings:
value of $LANG: es_ES.UTF-8
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
Major mode: Info
Minor modes in effect:
gpm-mouse-mode: t
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
buffer-read-only: t
line-number-mode: t
transient-mark-mode: t
Recent input:
C-n C-n C-n C-n C-n C-n RET C-v C-v C-u C-u C-n C-n
C-n C-p TAB C-p C-p TAB RET C-u C-n C-u C-n C-u C-n
C-f C-f C-n C-n RET C-v n C-v C-x ESC C-g C-x 3 C-x
o ESC x r e TAB p o TAB r TAB RET
Recent messages:
("emacs")
Loading 00debian-vars...done
Loading /etc/emacs/site-start.d/50cmake-data.el (source)...done
Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...
Loading /var/cache/dictionaries-common/emacsen-ispell-dicts.el (source)...
Error while loading 50dictionaries-common: Symbol's value as variable
is void: debian-aspell-only-dictionary-alist
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list... [2 times]
Load-path shadows:
/usr/share/emacs24/site-lisp/cmake-data/cmake-mode hides
/usr/share/emacs/site-lisp/cmake-mode
/usr/share/emacs/24.3/site-lisp/debian-startup hides
/usr/share/emacs/site-lisp/debian-startup
/home/user-name/.emacs.d/elpa/company-0.8.12/.dir-locals hides
/usr/share/emacs/24.3/lisp/gnus/.dir-locals
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25
2016-03-27 12:37 bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25 david lopez villegas
@ 2016-06-04 17:47 ` Noam Postavsky
2016-06-14 5:37 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Noam Postavsky @ 2016-06-04 17:47 UTC (permalink / raw)
To: 23126; +Cc: david lopez villegas
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
tag 23126 + patch
quit
I guess the point of having python.el in ELPA is to support older
emacs, so we should avoid calling format-message rather than require
Emacs 25? Patch attached.
[-- Attachment #2: 0001-Make-python.el-work-in-Emacs-24.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]
From c7b8c9832a71a28052b1388bf9664c4e00fcb586 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 4 Jun 2016 13:32:50 -0400
Subject: [PATCH] Make python.el work in Emacs 24
* lisp/progmodes/python.el (python-define-auxiliary-skeleton): Only use
format-message if fbound (Bug#23126).
---
lisp/progmodes/python.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index 343023f..d12d98a 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -4045,8 +4045,8 @@ python-define-auxiliary-skeleton
(declare (indent 2))
(let* ((name (symbol-name name))
(function-name (intern (concat "python-skeleton--" name)))
- (msg (format-message
- "Add `%s' clause? " name)))
+ (msg (funcall (if (fboundp 'format-message) 'format-message format)
+ "Add `%s' clause? " name)))
(when (not skel)
(setq skel
`(< ,(format "%s:" name) \n \n
--
2.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25
2016-06-04 17:47 ` Noam Postavsky
@ 2016-06-14 5:37 ` Glenn Morris
2016-06-14 5:40 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2016-06-14 5:37 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 23126, david lopez villegas
Thanks, please apply. (Or we could just use \"%\" instead...)
(I guess I am not the only one who did not know that
lisp/progmodes/python.el gets used as-is in GNU elpa. Seems like a
recipe for confusion... I guess it gets it from the master branch, so
presumably you only need to patch it there?)
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25
2016-06-14 5:37 ` Glenn Morris
@ 2016-06-14 5:40 ` Glenn Morris
2016-06-14 12:19 ` Noam Postavsky
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2016-06-14 5:40 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 23126, david lopez villegas
PS perhaps you will also need to bump the Version: header, so that elpa
offers it as a new package? I don't know how this stuff works...
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25
2016-06-14 5:40 ` Glenn Morris
@ 2016-06-14 12:19 ` Noam Postavsky
2016-06-14 22:48 ` Noam Postavsky
0 siblings, 1 reply; 6+ messages in thread
From: Noam Postavsky @ 2016-06-14 12:19 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23126, david lopez villegas
Oh, hah, I do have write access, don't I? I asked for it to push
yasnippet versions to ELPA, but didn't quite realize the access is to
both emacs and elpa repos.
On Tue, Jun 14, 2016 at 1:40 AM, Glenn Morris <rgm@gnu.org> wrote:
>
> PS perhaps you will also need to bump the Version: header, so that elpa
> offers it as a new package? I don't know how this stuff works...
>
I think that's right, based on archive--core-package-sync (in
elpa.git/admin/archive-contents.el), and what elpa.gnu.org is
currently serving. I've pushed to master now (2f523c15801), I'll close
the bug after the new python.el shows up in ELPA.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25
2016-06-14 12:19 ` Noam Postavsky
@ 2016-06-14 22:48 ` Noam Postavsky
0 siblings, 0 replies; 6+ messages in thread
From: Noam Postavsky @ 2016-06-14 22:48 UTC (permalink / raw)
To: 23126-done; +Cc: david lopez villegas
Version: elpa/python-0.25.2
On Tue, Jun 14, 2016 at 8:19 AM, Noam Postavsky
<npostavs@users.sourceforge.net> wrote:
> I've pushed to master now (2f523c15801), I'll close
> the bug after the new python.el shows up in ELPA.
The fixed version is now being served from ELPA.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-14 22:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-27 12:37 bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25 david lopez villegas
2016-06-04 17:47 ` Noam Postavsky
2016-06-14 5:37 ` Glenn Morris
2016-06-14 5:40 ` Glenn Morris
2016-06-14 12:19 ` Noam Postavsky
2016-06-14 22:48 ` Noam Postavsky
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).