From: Daniel McClanahan <danieldmcclanahan@gmail.com>
To: 21493@debbugs.gnu.org
Subject: bug#21493: 25.0.50; fix invalid regex in lisp--el-match-keyword introduced in master
Date: Wed, 16 Sep 2015 01:02:05 -0500 [thread overview]
Message-ID: <CALuGEhJ9jhAHXWC=fBkkO6Ph3xNc0W3KaH8QH4hc62U604KvXw@mail.gmail.com> (raw)
In commit 6d98299e761f18f171e042391138f4f5f5762de7, the form
lisp-mode-symbol-regexp was introduced, but it was added incorrectly
in one place. The form added,
(eval-when-compile "(\\(" lisp-mode-symbol-regexp "\\)\\_>")
is invalid, returning just "\\)\\_>". The fix is simple, and the diff
is given below.
Sorry if this message comes across garbled; I have selected the option
to turn off html in gmail, but I don't know if it works. Also sorry if
the fix is already committed, I just pulled and the fix has not been
made yet.
--Danny McClanahan
diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 56c2966..fed91b3 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -224,7 +224,8 @@
;; FIXME: Move to elisp-mode.el.
(catch 'found
(while (re-search-forward
- (eval-when-compile "(\\(" lisp-mode-symbol-regexp "\\)\\_>")
+ (eval-when-compile
+ (concat "(\\(" lisp-mode-symbol-regexp "\\)\\_>"))
limit t)
(let ((sym (intern-soft (match-string 1))))
(when (or (special-form-p sym)
next reply other threads:[~2015-09-16 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 6:02 Daniel McClanahan [this message]
2015-09-16 7:09 ` bug#21493: 25.0.50; fix invalid regex in lisp--el-match-keyword introduced in master martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALuGEhJ9jhAHXWC=fBkkO6Ph3xNc0W3KaH8QH4hc62U604KvXw@mail.gmail.com' \
--to=danieldmcclanahan@gmail.com \
--cc=21493@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).