From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Cameron Desautels Newsgroups: gmane.emacs.bugs Subject: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Date: Thu, 11 Dec 2014 19:04:19 -0600 Message-ID: References: <87egs7a5b0.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113f9232fd1fc20509fa783e X-Trace: ger.gmane.org 1418346328 25939 80.91.229.3 (12 Dec 2014 01:05:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Dec 2014 01:05:28 +0000 (UTC) Cc: 19328@debbugs.gnu.org To: Ted Zlatanov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 12 02:05:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XzEfY-0006s9-U2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Dec 2014 02:05:21 +0100 Original-Received: from localhost ([::1]:54909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzEfY-0007WY-El for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2014 20:05:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzEfO-0007Td-7u for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 20:05:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzEfH-0003SZ-E0 for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 20:05:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzEfH-0003SO-9n for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 20:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XzEfG-0004MN-VN for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 20:05:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Cameron Desautels Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Dec 2014 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19328-submit@debbugs.gnu.org id=B19328.141834626816688 (code B ref 19328); Fri, 12 Dec 2014 01:05:02 +0000 Original-Received: (at 19328) by debbugs.gnu.org; 12 Dec 2014 01:04:28 +0000 Original-Received: from localhost ([127.0.0.1]:43353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzEeh-0004L5-TB for submit@debbugs.gnu.org; Thu, 11 Dec 2014 20:04:28 -0500 Original-Received: from mail-ie0-f178.google.com ([209.85.223.178]:49664) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzEef-0004Kt-KN for 19328@debbugs.gnu.org; Thu, 11 Dec 2014 20:04:26 -0500 Original-Received: by mail-ie0-f178.google.com with SMTP id tp5so6033044ieb.9 for <19328@debbugs.gnu.org>; Thu, 11 Dec 2014 17:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2BKJgQAX1FIjgmVbUn6phwCh8hogrxejnJvvRYzN7WA=; b=YYNkIQKiRhrh5cLV8xR9ODD28Pm9BCe9bDq6vFrbKBA+FTM19DgqLZV3euHZ9KDuB0 /VBAjwmOPxG1AMA0R1NwMMzAXCqZhIvQOud3ns6ZcxKLGMbPBAEDDYu2lDeSG/OZufJh g2WdVwwHF0Ihzh+8p0cy11pVGvfS+Yek8WeQSi8ZiWj68/LU5D56Y86AkDn79WQk1ym4 5Hnk4XXDQCEdaKcitYFGRhT162VkAL1wJQbQ3+AAm5Yps73L8dQNLe22bfZeD0Hy7juI akkMeHVMONqRBAFEWKlxmdSHMCwGcG7o95w7WO38oL3LToaq5Qv4Gg5RVGGQ8extfEbO BiRw== X-Received: by 10.107.11.10 with SMTP id v10mr3649652ioi.12.1418346259868; Thu, 11 Dec 2014 17:04:19 -0800 (PST) Original-Received: by 10.107.43.8 with HTTP; Thu, 11 Dec 2014 17:04:19 -0800 (PST) In-Reply-To: <87egs7a5b0.fsf@lifelogs.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97240 Archived-At: --001a113f9232fd1fc20509fa783e Content-Type: text/plain; charset=UTF-8 > Could you add a NEWS entry and maybe some docs in the manual? I think > it's very helpful for beginners. The code looks OK to me. Absolutely! I've attached an updated version of the patch with the requested additions. What about turning something like this on by default? Any strong opinions? Having it available to add to the hook is a step in the right direction, but the users most likely to be helped by it are (I assume) less likely to be editing their initialization file by hand. If it does make sense to turn it on by default then I suspect the implementation would be rather different from a call to `add-hook' (it seems a bit odd to have a user call `remove-hook' to turn off the behavior), so perhaps an addition to `save-buffers-kill-emacs' and a variable to toggle the feature would be in order? -- Cameron Desautels --001a113f9232fd1fc20509fa783e Content-Type: application/octet-stream; name="0001-Add-mechanism-to-prompt-about-unsaved-customizations.patch" Content-Disposition: attachment; filename="0001-Add-mechanism-to-prompt-about-unsaved-customizations.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i3kuq3pz0 RnJvbSAyNGYyNWZhODA2ZDY2M2Q4Mzc3ODdjYzMwMTM4NmI4ODdkMmUwYjE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYW1lcm9uIERlc2F1dGVscyA8Y2FtZGV6QGdtYWlsLmNvbT4K RGF0ZTogVHVlLCA5IERlYyAyMDE0IDAwOjI4OjQ0IC0wNjAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IG1lY2hhbmlzbSB0byBwcm9tcHQgYWJvdXQgdW5zYXZlZCBjdXN0b21pemF0aW9ucwoKLSBSZXF1 ZXN0ZWQgaW4gYGV0Yy9UT0RPJwotIFN1aXRhYmxlIGZvciB1c2UgaW4gYGtpbGwtZW1hY3MtcXVl cnktZnVuY3Rpb25zJy4KLS0tCiBkb2MvZW1hY3MvY3VzdG9tLnRleGkgfCAxMCArKysrKysrKysr CiBldGMvTkVXUyAgICAgICAgICAgICAgfCAgMyArKysKIGV0Yy9UT0RPICAgICAgICAgICAgICB8 ICA2IC0tLS0tLQogbGlzcC9DaGFuZ2VMb2cgICAgICAgIHwgIDUgKysrKysKIGxpc3AvY3VzLWVk aXQuZWwgICAgICB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCiA1IGZpbGVzIGNo YW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Rv Yy9lbWFjcy9jdXN0b20udGV4aSBiL2RvYy9lbWFjcy9jdXN0b20udGV4aQppbmRleCAwZDAwMTNm Li42YzM5MmNiIDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvY3VzdG9tLnRleGkKKysrIGIvZG9jL2Vt YWNzL2N1c3RvbS50ZXhpCkBAIC00MDUsNiArNDA1LDE2IEBAIGN1c3RvbWl6YXRpb25zIGluIHlv dXIgaW5pdGlhbGl6YXRpb24gZmlsZS4gIFRoaXMgaXMgYmVjYXVzZSBzYXZpbmcKIGN1c3RvbWl6 YXRpb25zIGZyb20gc3VjaCBhIHNlc3Npb24gd291bGQgd2lwZSBvdXQgYWxsIHRoZSBvdGhlcgog Y3VzdG9taXphdGlvbnMgeW91IG1pZ2h0IGhhdmUgb24geW91ciBpbml0aWFsaXphdGlvbiBmaWxl LgogCisgIFBsZWFzZSBub3RlIHRoYXQgYW55IGN1c3RvbWl6YXRpb25zIHlvdSBoYXZlIG5vdCBj aG9zZW4gdG8gc2F2ZSBmb3IKK2Z1dHVyZSBzZXNzaW9ucyB3aWxsIGJlIGxvc3Qgd2hlbiB5b3Ug dGVybWluYXRlIEVtYWNzLiAgSWYgeW91J2QgbGlrZQordG8gYmUgcHJvbXB0ZWQgYWJvdXQgdW5z YXZlZCBjdXN0b21pemF0aW9ucyBhdCB0ZXJtaW5hdGlvbiB0aW1lLCBhZGQKK3RoZSBmb2xsb3dp bmcgdG8geW91ciBpbml0aWFsaXphdGlvbiBmaWxlOgorCitAZXhhbXBsZQorKGFkZC1ob29rICdr aWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucworICAgICAgICAgICdjdXN0b20tcHJvbXB0LWN1c3Rv bWl6ZS11bnNhdmVkLW9wdGlvbnMpCitAZW5kIGV4YW1wbGUKKwogQG5vZGUgRmFjZSBDdXN0b21p emF0aW9uCiBAc3Vic2VjdGlvbiBDdXN0b21pemluZyBGYWNlcwogQGNpbmRleCBjdXN0b21pemlu ZyBmYWNlcwpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA1OGE1ODM2Li5h NTgzYWYyIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNDksNiArNDks OSBAQCBVc2UgJy4vY29uZmlndXJlIFBLR19DT05GSUc9L2Z1bGwvbmFtZS9vZi9wa2ctY29uZmln JyBpZiB5b3UgbmVlZCB0by4KIAwKICogQ2hhbmdlcyBpbiBFbWFjcyAyNS4xCiAKKyoqIE5ldyBm dW5jdGlvbiBgY3VzdG9tLXByb21wdC1jdXN0b21pemUtdW5zYXZlZC1vcHRpb25zJyBjaGVja3Mg Zm9yCit1bnNhdmVkIGN1c3RvbWl6YXRpb25zIGFuZCBwcm9tcHRzIHVzZXIgdG8gY3VzdG9taXpl IChpZiBmb3VuZCkuCisKICsrKwogKiogTmV0d29yayBzZWN1cml0eSAoVExTL1NTTCBjZXJ0aWZp Y2F0ZSB2YWxpZGl0eSBhbmQgdGhlIGxpa2UpIGlzCiBhZGRlZCB2aWEgdGhlIG5ldyBOZXR3b3Jr IFNlY3VyaXR5IE1hbmFnZXIgKE5TTSkgYW5kIGNvbnRyb2xsZWQgdmlhCmRpZmYgLS1naXQgYS9l dGMvVE9ETyBiL2V0Yy9UT0RPCmluZGV4IGNjZDAwZTUuLmNiYjIzOTQgMTAwNjQ0Ci0tLSBhL2V0 Yy9UT0RPCisrKyBiL2V0Yy9UT0RPCkBAIC00MTksMTIgKzQxOSw2IEBAIHJhdGhlciB0aGFuIGlu dGVyYWN0aXZlbHkuICBUaGlzIGEgdHJpdmlhbCBvbmUtbGluZXIgaW4gZWFzeS1tb2RlLmVsLgog CiAqKiBNYWtlIGJ5dGUtb3B0aW1pemF0aW9uIHdhcm5pbmdzIGlzc3VlIGFjY3VyYXRlIGxpbmUg bnVtYmVycy4KIAotKiogQSBmdW5jdGlvbiB0byBjaGVjayBmb3IgY3VzdG9taXphYmxlIG9wdGlv bnMgdGhhdCBoYXZlIGJlZW4KLSAgc2V0IGJ1dCBub3Qgc2F2ZWQsIGFuZCBhc2sgdGhlIHVzZXIg d2hldGhlciB0byBzYXZlIHRoZW0uCi0gIFRoaXMgY291bGQgZ28gaW4ga2lsbC1lbWFjcy1xdWVy eS1mdW5jdGlvbnMsIHRvIHJlbWluZCBwZW9wbGUKLSAgdG8gc2F2ZSB0aGVpciBjaGFuZ2VzLiBJ ZiB0aGUgdXNlciBzYXlzIHllcywgc2hvdyB0aGVtCi0gIGluIGEgQ3VzdG9tIGJ1ZmZlciB1c2lu ZyBjdXN0b21pemUtY3VzdG9taXplZC4KLQogKiogUmVjb3JkIHRoZSBzeGhhc2ggb2YgdGhlIGRl ZmF1bHQgdmFsdWUgZm9yIGN1c3RvbWl6ZWQgdmFyaWFibGVzCiAgIGFuZCBub3RpZnkgdGhlIHVz ZXIgKG1heWJlIGJ5IGFkZGluZyBhIG1lbnUgaXRlbSBvciB0b29sYmFyIGJ1dHRvbiwKICAgYXMg dGhlIGRldGVjdGlvbiBjYW4gb2NjdXIgZHVyaW5nIGF1dG9sb2FkIHRpbWUpIHdoZW4gdGhlIGRl ZmF1bHQKZGlmZiAtLWdpdCBhL2xpc3AvQ2hhbmdlTG9nIGIvbGlzcC9DaGFuZ2VMb2cKaW5kZXgg NDUyZjRjMy4uMGJkNWEwMyAxMDA2NDQKLS0tIGEvbGlzcC9DaGFuZ2VMb2cKKysrIGIvbGlzcC9D aGFuZ2VMb2cKQEAgLTEsMyArMSw4IEBACisyMDE0LTEyLTExICBDYW1lcm9uIERlc2F1dGVscyAg PGNhbWRlekBnbWFpbC5jb20+CisKKwkqIGN1cy1lZGl0LmVsIChjdXN0b20tcHJvbXB0LWN1c3Rv bWl6ZS11bnNhdmVkLW9wdGlvbnMpOiBBZGQgYQorCW1lY2hhbmlzbSBmb3IgcHJvbXB0aW5nIHVz ZXIgYWJvdXQgdW5zYXZlZCBjdXN0b21pemF0aW9ucy4KKwogMjAxNC0xMi0xMSAgTWljaGFlbCBB bGJpbnVzICA8bWljaGFlbC5hbGJpbnVzQGdteC5kZT4KIAogCSogdmMvdmMtaGcuZWwgKHZjLWhn LXN0YXRlKTogTWFrZSBGSUxFIGFic29sdXRlLiAgSGFuZGxlIHRoZSBjYXNlCmRpZmYgLS1naXQg YS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRpdC5lbAppbmRleCBjOGU5YjkwLi5hNmRh NTBlIDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0LmVsCisrKyBiL2xpc3AvY3VzLWVkaXQuZWwK QEAgLTEzNTYsMTIgKzEzNTYsMTAgQEAgc3VnZ2VzdCB0byBjdXN0b21pemUgdGhhdCBmYWNlLCBp ZiBpdCdzIGN1c3RvbWl6YWJsZS4iCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKG9yIChmYWNlLWF0LXBvaW50IHQgdCkgImFsbCBmYWNlcyIpIHQpKSkKICAgKGN1c3RvbWl6 ZS1mYWNlIGZhY2UgdCkpCiAKLShkZWZhbGlhcyAnY3VzdG9taXplLWN1c3RvbWl6ZWQgJ2N1c3Rv bWl6ZS11bnNhdmVkKQotCi07OzsjIyNhdXRvbG9hZAotKGRlZnVuIGN1c3RvbWl6ZS11bnNhdmVk ICgpCi0gICJDdXN0b21pemUgYWxsIG9wdGlvbnMgYW5kIGZhY2VzIHNldCBpbiB0aGlzIHNlc3Np b24gYnV0IG5vdCBzYXZlZC4iCi0gIChpbnRlcmFjdGl2ZSkKKyhkZWZ1biBjdXN0b20tdW5zYXZl ZC1vcHRpb25zICgpCisgICJMaXN0IG9mIG9wdGlvbnMgYW5kIGZhY2VzIHNldCBpbiB0aGlzIHNl c3Npb24gYnV0IG5vdCBzYXZlZC4KK0VhY2ggZW50cnkgaXMgb2YgdGhlIGZvcm0gKFNZTUJPTCBU WVBFKSwgd2hlcmUgVFlQRSBpcyBvbmUgb2YgdGhlCitzeW1ib2xzIGBjdXN0b20tZmFjZScgb3Ig YGN1c3RvbS12YXJpYWJsZScuIgogICAobGV0ICgoZm91bmQgbmlsKSkKICAgICAobWFwYXRvbXMg KGxhbWJkYSAoc3ltYm9sKQogCQkoYW5kIChvciAoZ2V0IHN5bWJvbCAnY3VzdG9taXplZC1mYWNl KQpAQCAtMTM3Miw2ICsxMzcwLDE1IEBAIHN1Z2dlc3QgdG8gY3VzdG9taXplIHRoYXQgZmFjZSwg aWYgaXQncyBjdXN0b21pemFibGUuIgogCQkJIChnZXQgc3ltYm9sICdjdXN0b21pemVkLXZhcmlh YmxlLWNvbW1lbnQpKQogCQkgICAgIChib3VuZHAgc3ltYm9sKQogCQkgICAgIChwdXNoIChsaXN0 IHN5bWJvbCAnY3VzdG9tLXZhcmlhYmxlKSBmb3VuZCkpKSkKKyAgICBmb3VuZCkpCisKKyhkZWZh bGlhcyAnY3VzdG9taXplLWN1c3RvbWl6ZWQgJ2N1c3RvbWl6ZS11bnNhdmVkKQorCis7OzsjIyNh dXRvbG9hZAorKGRlZnVuIGN1c3RvbWl6ZS11bnNhdmVkICgpCisgICJDdXN0b21pemUgYWxsIG9w dGlvbnMgYW5kIGZhY2VzIHNldCBpbiB0aGlzIHNlc3Npb24gYnV0IG5vdCBzYXZlZC4iCisgIChp bnRlcmFjdGl2ZSkKKyAgKGxldCAoKGZvdW5kIChjdXN0b20tdW5zYXZlZC1vcHRpb25zKSkpCiAg ICAgKGlmIChub3QgZm91bmQpCiAJKGVycm9yICJObyB1c2VyIG9wdGlvbnMgYXJlIHNldCBidXQg dW5zYXZlZCIpCiAgICAgICAoY3VzdG9tLWJ1ZmZlci1jcmVhdGUgKGN1c3RvbS1zb3J0LWl0ZW1z IGZvdW5kIHQgbmlsKQpAQCAtMTQ3Nyw2ICsxNDg0LDE2IEBAIElmIFRZUEUgaXMgYGdyb3Vwcycs IGluY2x1ZGUgb25seSBncm91cHMuIgogICAoaW50ZXJhY3RpdmUgKGxpc3QgKGFwcm9wb3MtcmVh ZC1wYXR0ZXJuICJncm91cHMiKSkpCiAgIChjdXN0b21pemUtYXByb3BvcyByZWdleHAgJ2dyb3Vw cykpCiAKKzs7OyMjI2F1dG9sb2FkCisoZGVmdW4gY3VzdG9tLXByb21wdC1jdXN0b21pemUtdW5z YXZlZC1vcHRpb25zICgpCisgICJQcm9tcHQgdXNlciB0byBjdXN0b21pemUgYW55IHVuc2F2ZWQg Y3VzdG9taXphdGlvbiBvcHRpb25zLgorUmV0dXJuIG5vbi1uaWwgaWYgdXNlciBjaG9vc2VzIHRv IGN1c3RvbWl6ZSwgZm9yIHVzZSBpbgorYGtpbGwtZW1hY3MtcXVlcnktZnVuY3Rpb25zJy4iCisg IChub3QgKGFuZCAoY3VzdG9tLXVuc2F2ZWQtb3B0aW9ucykKKwkgICAgKHllcy1vci1uby1wICJT b21lIGN1c3RvbWl6ZWQgb3B0aW9ucyBoYXZlIG5vdCBiZWVuIHNhdmVkOyBFeGFtaW5lPyAiKQor CSAgICAoY3VzdG9taXplLXVuc2F2ZWQpCisJICAgIHQpKSkKKwogOzs7IEJ1ZmZlci4KIAogKGRl ZmN1c3RvbSBjdXN0b20tYnVmZmVyLXN0eWxlICdsaW5rcwotLSAKMi4yLjAKCg== --001a113f9232fd1fc20509fa783e--