From: Cameron Desautels <camdez@gmail.com>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: 19328@debbugs.gnu.org
Subject: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations
Date: Sat, 13 Dec 2014 17:23:43 -0600 [thread overview]
Message-ID: <CALtQdc=D3OJae_=YJCVCnCSvPLG=JW53XoHNH0LECMGW31vfxw@mail.gmail.com> (raw)
In-Reply-To: <874msz1yxz.fsf@lifelogs.com>
Ted: thanks for adding the additional ChangeLog entries--I didn't
realize just how many ChangeLog files there are. FWIW the patch looks
good to me.
--
Cameron Desautels <camdez@gmail.com>
On Sat, Dec 13, 2014 at 7:06 AM, Ted Zlatanov <tzz@lifelogs.com> wrote:
> On Sat, 13 Dec 2014 00:55:08 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>>> To make it easier for people to try it, and to format the patch a little
>>> better, I've pushed it on top of the current master branch in the branch
>>> scratch/bug19328/custom-prompt-customize-unsaved-options from where it
>>> can be tried or cherry-picked.
>
> SM> No! Please install it into master.
> SM> This part is not under debate. The only debate is whether to enable it
> SM> by default.
>
> Could you review the commit first? I wasn't sure about the commit
> message, since it's one commit for several scattered ChangeLogs (and
> those ChangeLog deltas are not in the commit message details). I think
> it's reasonable but didn't want to presume.
>
> Ted
next prev parent reply other threads:[~2014-12-13 23:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 15:46 bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Cameron Desautels
2014-12-09 15:54 ` Drew Adams
2014-12-09 16:16 ` Cameron Desautels
2014-12-09 16:24 ` Drew Adams
2014-12-09 17:05 ` Cameron Desautels
2014-12-09 17:46 ` Drew Adams
2014-12-09 19:47 ` Cameron Desautels
2014-12-09 20:10 ` Drew Adams
2014-12-10 15:32 ` Ted Zlatanov
2014-12-12 1:04 ` Cameron Desautels
2014-12-12 1:40 ` Stefan Monnier
2014-12-12 1:56 ` Cameron Desautels
2014-12-12 2:36 ` Stefan Monnier
2014-12-12 2:39 ` Cameron Desautels
2014-12-13 1:17 ` Ted Zlatanov
2014-12-13 5:55 ` Stefan Monnier
2014-12-13 13:06 ` Ted Zlatanov
2014-12-13 23:23 ` Cameron Desautels [this message]
2014-12-14 11:54 ` Ted Zlatanov
2014-12-14 14:02 ` Stefan Monnier
2014-12-14 16:31 ` Ted Zlatanov
2016-02-23 11:36 ` Lars Ingebrigtsen
2014-12-12 2:48 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALtQdc=D3OJae_=YJCVCnCSvPLG=JW53XoHNH0LECMGW31vfxw@mail.gmail.com' \
--to=camdez@gmail.com \
--cc=19328@debbugs.gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).