From: Garklein <garklein97@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: 73401@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#73401: [PATCH] Make window dividers and internal border respect alpha background
Date: Sat, 23 Nov 2024 16:56:26 -0500 [thread overview]
Message-ID: <CALp=Ckk+wjHru3av1potuFJAdUsCVHMRSJ-v8pY7zcn6dOTu5Q@mail.gmail.com> (raw)
In-Reply-To: <8734l0supd.fsf@yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
Here is a patch that adds this option as a frame parameter.
I hope I did everything correctly, but I have never worked with the
Emacs C source before, so I probably made some mistakes in style or
logic.
Also, should this be factored out so that `border-alpha-background' is
its own parameter? In that case, a lot of functions would need to be
changed (the `respect-alpha-background' parameter in many xterm.c
functions would probably be changed to just a `double alpha` or
something like that). I am up for that, but I'm not sure if it would
be a helpful change.
Please let me know how it looks!
On Sat, Oct 12, 2024 at 8:38 PM Po Lu <luangruo@yahoo.com> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Ping! Po Lu, can you answer the OP?
> >
> >> From: Garklein <garklein97@gmail.com>
> >> Date: Sun, 29 Sep 2024 15:37:58 -0400
> >> Cc: Eli Zaretskii <eliz@gnu.org>, 73401@debbugs.gnu.org
> >>
> >> Would it be possible to have an option to make them transparent? It
> >> makes it look a lot better for EXWM.
>
> Yes, but I won't be implementing it myself till Emacs 30 is released.
> In the interim, patches welcome.
[-- Attachment #2: borders-respect-alpha-background.patch --]
[-- Type: application/x-patch, Size: 12540 bytes --]
prev parent reply other threads:[~2024-11-23 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 18:25 bug#73401: [PATCH] Make window dividers and internal border respect alpha background Garklein
2024-09-28 10:20 ` Eli Zaretskii
2024-09-28 10:40 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-29 19:37 ` Garklein
2024-10-12 11:23 ` Eli Zaretskii
2024-10-13 0:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-23 21:56 ` Garklein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALp=Ckk+wjHru3av1potuFJAdUsCVHMRSJ-v8pY7zcn6dOTu5Q@mail.gmail.com' \
--to=garklein97@gmail.com \
--cc=73401@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).