unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Fejfighter <fejfighter@gmail.com>
To: 50337@debbugs.gnu.org
Subject: bug#50337:
Date: Sat, 2 Oct 2021 00:37:03 +1000	[thread overview]
Message-ID: <CALohuRD7-Qcdy7gBhv+zMWMjz3hi9W7BHH2b9F3BKzmcZkYKXQ@mail.gmail.com> (raw)
In-Reply-To: <87tuj3p0dg.fsf@dsemy.com>


[-- Attachment #1.1: Type: text/plain, Size: 310 bytes --]

Having looked at this, the variable is respected, it's largely the same
code as the x version.
if the cursor colour and the foreground face are different it will show up

The actual error is that the colour selected to draw was the foreground
face rather than the background used. this patch should correct it

[-- Attachment #1.2: Type: text/html, Size: 385 bytes --]

[-- Attachment #2: 0001-Set-correct-face-color-for-stretched-glyphs.patch --]
[-- Type: text/x-patch, Size: 739 bytes --]

From 5d9df7345d7b3960c03099d1f698437032e63a68 Mon Sep 17 00:00:00 2001
From: Jeff Walsh <fejfighter@gmail.com>
Date: Sat, 2 Oct 2021 00:28:19 +1000
Subject: [PATCH] Set correct face color for stretched glyphs

* src/pgtkterm.c (x_draw_stretch_glyph_string): s/foreground/background
---
 src/pgtkterm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index 559fc8b5c6..e48c1ce7ad 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -2391,7 +2391,7 @@ x_draw_stretch_glyph_string (struct glyph_string *s)
 	      color = s->xgcv.foreground;
 	    }
 	  else
-	    color = s->face->foreground;
+	    color = s->face->background;
 
 	  cairo_t *cr = pgtk_begin_cr_clip (s->f);
 
-- 
2.31.1


  reply	other threads:[~2021-10-01 14:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 13:34 bug#50337: 28.0.50; (while-no-input (redisplay) forms...) block behaves differently when window-system is pgtk Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-01 14:37 ` Fejfighter [this message]
2021-10-02  1:31   ` bug#50579: Fwd: Fejfighter
2021-10-01 14:54 ` bug#50337: Fejfighter
2021-12-06 18:12 ` bug#50337: 28.0.50; (while-no-input (redisplay) forms...) block behaves differently when window-system is pgtk Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-07  2:20   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-06 18:31 ` Daniel Semyonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALohuRD7-Qcdy7gBhv+zMWMjz3hi9W7BHH2b9F3BKzmcZkYKXQ@mail.gmail.com \
    --to=fejfighter@gmail.com \
    --cc=50337@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).