From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fejfighter Newsgroups: gmane.emacs.bugs Subject: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling Date: Wed, 6 Nov 2024 19:04:42 +1100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000013ebab062639f99d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35184"; mail-complaints-to="usenet@ciao.gmane.io" To: 74224@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 06 09:06:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8b3R-000915-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Nov 2024 09:06:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8b3F-0008VX-TH; Wed, 06 Nov 2024 03:06:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8b3C-0008VJ-QU for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 03:06:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8b3C-0003cL-Gh for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 03:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:MIME-Version:To:Subject; bh=b3aJMFK86cEwt823a1Jkkh535R74xEg0Fyle9NMGP2I=; b=qfj88nI9Q2nfRJZ7YZ7dPvMEYXWoqfzGWxglQORHlBJRfPrLp/2K86i7Bgnu2mRGdPXD2yvwvZbTo6T9Da56H6QFi/jFONwuqzV7D46HpEnXn/ol0ownFDD9gNSHIGP4NAZLpSwI++t7TlkZRblKsCnfHsfDvRnKxTT2QUhT7CCHkLzZH6AH9KDU/GNPFDAxGQ8iHcM1tx/3fbbzeTp5lxQHP3v0ipIFKjJKbPsRmLRb4X8xMr1FJkCpieEgjlawC/mHgpDN7FpQZNWGRL/BOJbPVgrYUtcNcCz4yI7oX0wzVKZdBQBZsYjPdoCVOzdtgBKBQzmjChXG5n2TCSsQDg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t8b3C-0001vO-B3 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 03:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fejfighter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2024 08:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17308803047008 (code B ref -1); Wed, 06 Nov 2024 08:06:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 08:05:04 +0000 Original-Received: from localhost ([127.0.0.1]:39174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8b2G-0001ox-1R for submit@debbugs.gnu.org; Wed, 06 Nov 2024 03:05:04 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:35848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8b2D-0001no-GZ for submit@debbugs.gnu.org; Wed, 06 Nov 2024 03:05:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8b2B-0008NU-48 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 03:04:59 -0500 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8b29-0003JS-79 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2024 03:04:58 -0500 Original-Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2fb5638dd57so60771761fa.0 for ; Wed, 06 Nov 2024 00:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730880294; x=1731485094; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=BCvyO4du6y3C6LWKNN+wvU15wdbX3V+hMaSVhobG8bE=; b=KCgzqqbs3DRhC+SpbF8MGgBL04Uw/4Ql5Q2ck3URvYZgQ3UlbyU5wTlTZIjIcQwnu0 uuLLqYZu/o/KVOmHv8BkpAhcdhIvsAa/nCY3wd9ehEeFAXW6zYIu/EqbIPKWDyezLn9i Xqg9HDjr4PX3jhtKzmLldUgQJi91D+dLNOojDxA8gRp+39CIIchvtPp1y1GFow5Zsx3U 5RQdbbKrGp/MyDL8iYEEqaXwoPxGfMhPW06Yz9gerTWAPnauQRYVDOWwDayKqnH2bKPE /XESb+b02AX5U2fbKtE7wGWCKCO0jTNN271mrggqSM+SQpn8SfihZw1JlUpfxc7dmw0k szSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730880294; x=1731485094; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BCvyO4du6y3C6LWKNN+wvU15wdbX3V+hMaSVhobG8bE=; b=VqX7FBEdOsBWfKBxFp2s5gsGui8JsY+ZGKDlfGqmDK5sFimQEE2PKY/nrHeY7FrmvD mzIrnS6On4TCuOzwmCrgxA+VbUNsMybl1bkrkZ7oIb4KnXumtKrHAS2c3/a0q2jSFc3v tZA68DodDYU4ibAxrt4NVreSjL3/oL7hXuQNCnLRKKCyi6+qyfwfJn66eQjmPdTTHth1 grLKNcbr2JF6Ne91Gbr6+ft2WH9PJq0UOq9pdwtu9VwMWykoUHCJvfXN2b1uUUoO01lt sPI8AzjcSwAXrqWIzh8KprdkXJUXnONGwU8kLcbWfZv/tDkmDaIokoodGN9Mug04Zwcj 2tuA== X-Gm-Message-State: AOJu0YwiMuF7cMNPtUhDvxWHodT5e6/P4sBOLDIdG5aY+MA4MdawN9yN cusvMjVbRZmMFm8YlJlUtk+BJzOVYuD7o1JVz+pwjl+Pt5zJ83fC3VyR4/L/AER9xoJ1vcfCx/u PtOiNsODbrDTfo9tsnMqozoX1f6Ik1SJ1 X-Google-Smtp-Source: AGHT+IH/+RtDTyddY7+oOGIziGo6cmmGPH3U5mf8uCAQr7t7yfua9KUvgo3/RTxvAXU92gS/qAiVv6IBFXohpW5nULE= X-Received: by 2002:a05:651c:1546:b0:2fa:c18c:faba with SMTP id 38308e7fff4ca-2fcbe07ac05mr179508841fa.30.1730880294078; Wed, 06 Nov 2024 00:04:54 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=fejfighter@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294936 Archived-At: --00000000000013ebab062639f99d Content-Type: multipart/alternative; boundary="00000000000013eba9062639f99b" --00000000000013eba9062639f99b Content-Type: text/plain; charset="UTF-8" This patch marks 2 outstanding ambiguous roots and appears to solve crashing bugs I had been experiencing with igc/mps and pgtk. I have run this locally today, and I would have normally faced crashes at timer expiration, this appears to be holding up. In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-11-06 built on solidus.local Repository revision: 96de0bf0ba9161af5d3f783b45a5a9de530b6f95 Repository branch: scratch/igc System Description: Fedora Linux 41 (Sway) Configured using: 'configure --with-pgtk --with-mps CFLAGS=-O2' --00000000000013eba9062639f99b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This patch marks 2 outstanding ambiguous roots and appears= to solve
crashing bugs I had been experiencing with igc/mps and pgtk.
I have run this locally today, and I would have normally faced crashe= s at timer expiration, this appears to be holding up.



In GNU= Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
=C2=A03.24.43= , cairo version 1.18.0) of 2024-11-06 built on solidus.local
Repository = revision: 96de0bf0ba9161af5d3f783b45a5a9de530b6f95
Repository branch: sc= ratch/igc
System Description: Fedora Linux 41 (Sway)

Configured u= sing:
=C2=A0'configure --with-pgtk --with-mps CFLAGS=3D-O2'=


--00000000000013eba9062639f99b-- --00000000000013ebab062639f99d Content-Type: text/x-patch; charset="US-ASCII"; name="mps-igc-pgtk.patch" Content-Disposition: attachment; filename="mps-igc-pgtk.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m35lereq0 ZGlmZiAtLWdpdCBhL3NyYy9hdGltZXIuYyBiL3NyYy9hdGltZXIuYwppbmRleCA4MjUzYWUzYTE2 Ni4uNWJkMjgyYTMxMGQgMTAwNjQ0Ci0tLSBhL3NyYy9hdGltZXIuYworKysgYi9zcmMvYXRpbWVy LmMKQEAgLTE3LDYgKzE3LDcgQEAKIGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUg PGh0dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4gICovCiAKICNpbmNsdWRlIDxjb25maWcu aD4KKyNpbmNsdWRlICJpZ2MuaCIKIAogI2lmZGVmIFdJTkRPV1NOVAogI2RlZmluZSByYWlzZShz KSB3MzJfcmFpc2UocykKQEAgLTEzMiw3ICsxMzMsMTMgQEAgc3RhcnRfYXRpbWVyIChlbnVtIGF0 aW1lcl90eXBlIHR5cGUsIHN0cnVjdCB0aW1lc3BlYyB0aW1lc3RhbXAsCiAgICAgICBmcmVlX2F0 aW1lcnMgPSB0LT5uZXh0OwogICAgIH0KICAgZWxzZQotICAgIHQgPSB4bWFsbG9jIChzaXplb2Yg KnQpOworICAgIHsKKyNpZmRlZiBIQVZFX01QUworICAgICAgdCA9IGlnY194emFsbG9jX2FtYmln IChzaXplb2YgKnQpOworI2Vsc2UKKyAgICAgIHQgPSB4bWFsbG9jIChzaXplb2YgKnQpOworI2Vu ZGlmCisgICAgfQogCiAgIC8qIEZpbGwgdGhlIGF0aW1lciBzdHJ1Y3R1cmUuICAqLwogICBtZW1z ZXQgKHQsIDAsIHNpemVvZiAqdCk7CmRpZmYgLS1naXQgYS9zcmMvcGd0a3Rlcm0uYyBiL3NyYy9w Z3RrdGVybS5jCmluZGV4IGVmOTQwNTA5NjI2Li5jMGVkNjhkNjgyMCAxMDA2NDQKLS0tIGEvc3Jj L3BndGt0ZXJtLmMKKysrIGIvc3JjL3BndGt0ZXJtLmMKQEAgLTcxNjYsNyArNzE2NiwxMSBAQCAj ZGVmaW5lIE5VTV9BUkdWIDEwCiAgIGlmIChja2RfYWRkICgmbmJ5dGVzLCBTQllURVMgKFZpbnZv Y2F0aW9uX25hbWUpLCBTQllURVMgKHN5c3RlbV9uYW1lKSArIDIpKQogICAgIG1lbW9yeV9mdWxs IChTSVpFX01BWCk7CiAgIGRweWluZm8tPnhfaWQgPSArK3hfZGlzcGxheV9pZDsKKyNpZmRlZiBI QVZFX01QUworICBkcHlpbmZvLT54X2lkX25hbWUgPSBpZ2NfeHphbGxvY19hbWJpZyAobmJ5dGVz KTsKKyNlbHNlCiAgIGRweWluZm8tPnhfaWRfbmFtZSA9IHhtYWxsb2MgKG5ieXRlcyk7CisjZW5k aWYKICAgY2hhciAqbmFtZXRhaWwgPSBsaXNwc3RwY3B5IChkcHlpbmZvLT54X2lkX25hbWUsIFZp bnZvY2F0aW9uX25hbWUpOwogICAqbmFtZXRhaWwrKyA9ICdAJzsKICAgbGlzcHN0cGNweSAobmFt ZXRhaWwsIHN5c3RlbV9uYW1lKTsKQEAgLTczMDIsNyArNzMwNiwxNCBAQCBwZ3RrX2RlbGV0ZV9k aXNwbGF5IChzdHJ1Y3QgcGd0a19kaXNwbGF5X2luZm8gKmRweWluZm8pCiAgICAgfQogCiAgIHBn dGtfZnJlZV9kZXZpY2VzIChkcHlpbmZvKTsKKworI2lmZGVmIEhBVkVfTVBTCisgIGlnY194ZnJl ZSAoZHB5aW5mby0+eF9pZF9uYW1lKTsKKyAgaWdjX3hmcmVlIChkcHlpbmZvKTsKKyNlbHNlCisg IHhmcmVlIChkcHlpbmZvLT54X2lkX25hbWUpOwogICB4ZnJlZSAoZHB5aW5mbyk7CisjZW5kaWYK IH0KIAogY2hhciAqCg== --00000000000013ebab062639f99d--