From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Sam Halliday Newsgroups: gmane.emacs.bugs Subject: bug#24358: 25.1.50; re-search-forward errors with "Variable binding depth exceeds max-specpdl-size" Date: Sun, 23 Oct 2016 19:16:18 +0100 Message-ID: References: <87eg3rvtsf.fsf@users.sourceforge.net> <83k2dihpm9.fsf@gnu.org> <8760p2wzgj.fsf@users.sourceforge.net> <838ttyhhzu.fsf@gnu.org> <871szqwu51.fsf@users.sourceforge.net> <831szqhbc2.fsf@gnu.org> <87h98hujcx.fsf@users.sourceforge.net> <831szkahyz.fsf@gnu.org> <87eg3jvfj6.fsf@users.sourceforge.net> <8360ov8lbu.fsf@gnu.org> <877f95uj66.fsf@users.sourceforge.net> <83zim0vn1t.fsf@gnu.org> <874m48v7wj.fsf@users.sourceforge.net> <83insov1zr.fsf@gnu.org> <87zilztzd5.fsf@users.sourceforge.net> <83oa2ftnvp.fsf@gnu.org> <87wph2ts1a.fsf@users.sourceforge.net> <83oa2erx0k.fsf@gnu.org> <87lgxht8hp.fsf@users.sourceforge.net> <871sz8kq2v.fsf@gmail.com> <87shroroh8.fsf@users.sourceforge.net> <838ttfpnxt.fsf@gnu.org> <83vawjo21l.fsf@gnu.org> <83bmybnopx.fsf@gnu.org> <8360ojnk0n.fsf@gnu.org> <83twc3m198.fsf@gnu.org> <83pomrlz27.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1477246647 8144 195.159.176.226 (23 Oct 2016 18:17:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Oct 2016 18:17:27 +0000 (UTC) Cc: 24358@debbugs.gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 23 20:17:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byNKa-0000If-Iz for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 20:17:12 +0200 Original-Received: from localhost ([::1]:41971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byNKc-0003YZ-T1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 14:17:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byNKT-0003XG-GD for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byNKQ-0008M7-Bw for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34254) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1byNKQ-0008M1-86 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1byNKQ-0006Oy-07 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 14:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sam Halliday Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2016 18:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 24358-submit@debbugs.gnu.org id=B24358.147724658624560 (code B ref 24358); Sun, 23 Oct 2016 18:17:01 +0000 Original-Received: (at 24358) by debbugs.gnu.org; 23 Oct 2016 18:16:26 +0000 Original-Received: from localhost ([127.0.0.1]:49650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byNJq-0006O4-KT for submit@debbugs.gnu.org; Sun, 23 Oct 2016 14:16:26 -0400 Original-Received: from mail-yw0-f178.google.com ([209.85.161.178]:36281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byNJo-0006Nq-JV for 24358@debbugs.gnu.org; Sun, 23 Oct 2016 14:16:24 -0400 Original-Received: by mail-yw0-f178.google.com with SMTP id u124so140602010ywg.3 for <24358@debbugs.gnu.org>; Sun, 23 Oct 2016 11:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=26z8dXQBB+tzdpre+/z/4ph7eENfBIyKo/uUGvDAC5k=; b=VZ8ub7qylo8XCHvZBNP3+fx62aN69xnUVT0OxcZW5ZtcKdPqqj7/lse4D7FPWsOVkI NUUVxBYj1COxqrnUQ32q9LKdbEFgna8ddDFdZTwi8ctoqOQEctHxvOJJebAAK0+kqz79 uSYOWAMpz0mdnz+bx9qItEnL8nKib2zFaCP+bFAp9F09mNgOey/opZVD5MYOY3wbQq56 6KrGTPOPKsZdHFtjA3RsLDaykv5GF6bVM1min2n0QjU5+XVPfjX/SxxkIuvA/snuL9wo a8pRsFQ8AWdl0Ac5zSIS5cVq43f+hHLLYw20NMqYJawQWJZtmWbtCAAj2yzsnJ3AyQNy fniw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=26z8dXQBB+tzdpre+/z/4ph7eENfBIyKo/uUGvDAC5k=; b=Hv6eP0fDWruz2n18DC5UXc0RiDSNupwpmMKEJKo3qDaiUUJ+0eSMC8lxZvGD5gRzp1 XZSWbEr41XBFQRbnvJTy3jtoNoTdPb6tSvQs/5ZS0h1SpNorNNLgM+ZTYku237ond+m5 jsEoagNveiqZZQRzh9nwJncpFgPxAUWWm/0dZixwe3c943rPs6D25HkKz4Yy8WZJfdDA 7wxf8n01qfvt7QkMBAZBz+9I5RStdBUBHvs+oAHfrxzPzVnEnS7u4OZ7384vkiV9v7BU vNbFYmc8+GBrCRBGNSMwyUQQBWg571jfuhXPIj+HqXrP2xij6KOA1qigZ7V72QfGSRy5 v5Lg== X-Gm-Message-State: ABUngvd2sy8rRNeHyPSDB270LMxpJiMtaaDN3qUShg7+rVDAyPzyhZjnXETOz2z2jqsNbhpZtWtX/M1kYx/qPQ== X-Received: by 10.107.3.78 with SMTP id 75mr9881722iod.75.1477246579074; Sun, 23 Oct 2016 11:16:19 -0700 (PDT) Original-Received: by 10.50.40.3 with HTTP; Sun, 23 Oct 2016 11:16:18 -0700 (PDT) In-Reply-To: <83pomrlz27.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124924 Archived-At: Your patch suggestion results in a failure at 20% in the test for me. I wish we knew what was causing this to fail on my OS but not yours. Do you have docker? You could perhaps try with an recent archlinux image. On 23 October 2016 at 19:06, Eli Zaretskii wrote: > Noam, I think we need these two changes, because otherwise looping > more than once in search_buffer will fail to update the pointers > passed to re_search_2, if buffer text was relocated inside > re_search_2. > > Do you agree? > > diff --git a/src/search.c b/src/search.c > index ec5a1d7..5c04916 100644 > --- a/src/search.c > +++ b/src/search.c > @@ -1233,6 +1233,8 @@ search_buffer (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, > ? &search_regs : &search_regs_1), > /* Don't allow match past current point */ > pos_byte - BEGV_BYTE); > + /* Update 'base' due to possible relocation inside re_search_2. */ > + base = current_buffer->text->beg; > if (val == -2) > { > matcher_overflow (); > @@ -1279,6 +1281,8 @@ search_buffer (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, > (NILP (Vinhibit_changing_match_data) > ? &search_regs : &search_regs_1), > lim_byte - BEGV_BYTE); > + /* Update 'base' due to possible relocation inside re_search_2. */ > + base = current_buffer->text->beg; > if (val == -2) > { > matcher_overflow ();