From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Prateek Sharma Newsgroups: gmane.emacs.bugs Subject: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. Date: Sun, 21 Apr 2024 10:46:44 +0530 Message-ID: References: <86le58a7dv.fsf@gnu.org> <86edb0a3bq.fsf@gnu.org> <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000f708750616946d3f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30507"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 70478@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 21 07:18:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryPal-0007lL-2W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Apr 2024 07:18:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryPaV-0003GV-BU; Sun, 21 Apr 2024 01:18:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryPaG-0003G0-Q6 for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 01:17:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ryPaG-0007V7-0M for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 01:17:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ryPaU-0005S1-Qu for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 01:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Prateek Sharma Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Apr 2024 05:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70478-submit@debbugs.gnu.org id=B70478.171367663820583 (code B ref 70478); Sun, 21 Apr 2024 05:18:02 +0000 Original-Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 05:17:18 +0000 Original-Received: from localhost ([127.0.0.1]:40649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryPZl-0005Lu-Pl for submit@debbugs.gnu.org; Sun, 21 Apr 2024 01:17:18 -0400 Original-Received: from mail-vs1-xe29.google.com ([2607:f8b0:4864:20::e29]:56351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryPZk-0005Li-RL for 70478@debbugs.gnu.org; Sun, 21 Apr 2024 01:17:17 -0400 Original-Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-479e857876fso1173408137.0 for <70478@debbugs.gnu.org>; Sat, 20 Apr 2024 22:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713676616; x=1714281416; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rfudxBnkpkSJtUHBS99x+ydjMV4nMhfb8cGlOrF7gpk=; b=EV+uQOOa/N/eGOu1Q6KjpSFSfhWnVm7b+ZbRbl09P8tzqO+LdJsTWpFrfqm8OvL6bW Cp3fcUCbvJyLiO6jbWIbZsglsafm0ygpSH+OEOSP8YhFtvssEN08z8AWHfw+HcfndOwH WwhwVhdYfquB0AmERUhFgeJzXij6KQTdlNJnvgfiZ4tYQpA+GKAj5gZLrQbfbQCdilNu I8GDvaD+LoPH8X9LmD9n2pfRGzXPS4ikjnlPGskj00QDOn4BZnBJY3nImqMu82q61aak 6gNmKkLl6kkfjPTjPYOos3Imn7ejgkn1FesRy2g6549DptpoXZIdr1/afJ94mnjhf1jb KXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713676616; x=1714281416; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rfudxBnkpkSJtUHBS99x+ydjMV4nMhfb8cGlOrF7gpk=; b=q2eQufHSqusmQ2v9XnxLffGb6jUrG5xrGpwUMQfSx60P72B2y0OAajaRCYqzqncMhw i3kDvcBSAVH91uh2DM5pjxduE5B9Hixt46IAvXgKXHRWRvfT8qBuBFuVWtZW3SkeQtB+ hQtgcK/ytc7XysDHGeVlNUtYUHFI1OO/woNpc8RwDI/qWauRBaI1GOIrVeu8KIx38ZZz TW3Sms250ROWqYlvKMexqIEf4GDTgCTViXpdWxw+9FEh4xVCqLNE3rR3aNSSJ7q8KrVV LcTWseiy5qgYRTFeXNizZBJgSLPfF9oH4hhSA3I84NErIX/rCYl13Zcx7GBy6Q7qhDLe n1jw== X-Forwarded-Encrypted: i=1; AJvYcCUs2/kgyO30yqjyjLOTFoVeWgv0XFENT0L9k1eqc071pbvaFIniC6VSGWID6jDn6WorWweXSf3Yb7pphKHE98UGfMEg2FY= X-Gm-Message-State: AOJu0YyBI7PojbRsu+8vofukEVw8cNEG4WhqbI4iqycdK41/ZS9/wbpL CBbHQs1vjiseF9ZBkOpjWo7ZGZAVEPEyfTL1JZmt/INyXxSWKFcatlAMcCfcKiE30vVLbYY9uEp k+VsPactWvbKn29AFEh5ZpApUO7Y= X-Google-Smtp-Source: AGHT+IHkfM+Pl8Uq5FiojunD7KCPRIncnLMdhzVoCZzBzVruTNRO3x6Da2vR/5TexmpBaNJx5RHm6GnrDnTglRABzAk= X-Received: by 2002:a67:bb08:0:b0:47a:31f9:163b with SMTP id m8-20020a67bb08000000b0047a31f9163bmr7494018vsn.13.1713676616138; Sat, 20 Apr 2024 22:16:56 -0700 (PDT) In-Reply-To: <7587CCB2-559E-46D7-B497-668477F41CF4@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283757 Archived-At: --000000000000f708750616946d3f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well, I think emacs-29 also needs this fix. There is one other fix with indentation in python-ts-mode that is needed in emacs-29. But it's already fixed in emacs-30 as I've tested. On Sun, Apr 21, 2024 at 9:17=E2=80=AFAM Yuan Fu wrote: > > > > On Apr 20, 2024, at 12:53 AM, Prateek Sharma < > ps.prateek.sharma143@gmail.com> wrote: > > > > Here is the patch for the squashed commit and updated code. Thanks for > helping me out! > > > > > > On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii wr= ote: > > > From: Prateek Sharma > > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > > Cc: Yuan Fu , 70478@debbugs.gnu.org > > > > > > Also should I squash the changes of both the above commits into one > and then create a patch file? > > > > You should squash, yes. Other than that, attaching the patches as you > > did is fine. > > > > Thanks. > > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> > > Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so = I think > emacs-29? > > Yuan --000000000000f708750616946d3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Well, I think emacs-29 also needs this fix.

=
There is one other fix with indentation in python-ts-mode that is need= ed in emacs-29. But it's already fixed in emacs-30 as I've tested.<= /div>

On Sun, Apr 21, 2024 at 9:17=E2=80=AFAM Yuan Fu <casouri@gmail.com> wrote:


> On Apr 20, 2024, at 12:53 AM, Prateek Sharma <ps.prateek.sharma143@gmail.c= om> wrote:
>
> Here is the patch for the squashed commit and updated code. Thanks for= helping me out!
>
>
> On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Prateek Sharma <ps.prateek.sharma143@gmail.com>
> > Date: Sat, 20 Apr 2024 12:25:24 +0530
> > Cc: Yuan Fu <casouri@gmail.com>, 70478@debbugs.gnu.org
> >
> > Also should I squash the changes of both the above commits into o= ne and then create a patch file?
>
> You should squash, yes.=C2=A0 Other than that, attaching the patches a= s you
> did is fine.
>
> Thanks.
> <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch>= ;

Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so I = think emacs-29?

Yuan
--000000000000f708750616946d3f--