bug#67682: 30.0.50; M-u M-x eglot localhost:4567 doesn't connect

bug#67682: 30.0.50; M-u M-x eglot localhost:4567 doesn't connect

[Helmut Eller]

When I try:

  M-u M-x eglot localhost:4567

then I get:

  No such file or directory, localhost:4567

ISTR, that this worked in the past.



In GNU Emacs 30.0.50 (build 196, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2023-12-07 built on caladan
Repository revision: e4e1e268c8e9f7de6fe5d4b05beb595a1781c02c
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --enable-checking=yes --with-xpm=ifavailable
 --with-gif=ifavailable 'CFLAGS=-g -O1''

Configured features:
CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX
LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 GTK3
ZLIB

bug#67682: 30.0.50; M-u M-x eglot localhost:4567 doesn't connect

[João Távora]

On Thu, Dec 7, 2023 at 9:28 AM Helmut Eller <eller.helmut@gmail.com> wrote:
>
> When I try:
>
>   M-u M-x eglot localhost:4567
>
> then I get:
>
>   No such file or directory, localhost:4567
>
> ISTR, that this worked in the past.

Confirm.  Broken in

commit 523547321e4caca6fc966bd71ecd7b60a6e98f73
Author: João Távora <joaotavora@gmail.com>
Date:   Sat Sep 17 21:40:34 2022 +0100

    Allow :initializationoptions in eglot-server-programs

...for more than one year, probably means very few people
are using this.  May I ask what your LS is? .  Please try
the untested patch after my sig.

João

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index d410367f902..248199641e3 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1280,14 +1280,21 @@ eglot--guess-contact
                          (concat "`%s' not found in PATH, but can't form"
                                  " an interactive prompt for to fix %s!")
                          program guess))))))
+         (user-input (and prompt
+                          (read-shell-command
+                           prompt
+                           full-program-invocation
+                           'eglot-command-history)))
          (contact
-          (or (and prompt
-                   (split-string-and-unquote
-                    (read-shell-command
-                     prompt
-                     full-program-invocation
-                     'eglot-command-history)))
-              guess)))
+          (cond ((and user-input
+                      (string-match
"^[\s\t]*\\(.*\\):\\([[:digit:]]+\\)[\s\t]*$"
+                                    user-input))
+                 (list (match-string 1 user-input)
+                       (string-to-number (match-string 2 user-input))))
+                (user-input
+                 (split-string-and-unquote user-input))
+                (t
+                 guess))))
     (list managed-modes (eglot--current-project) class contact language-ids)))

 (defvar eglot-lsp-context)

bug#67682: 30.0.50; M-u M-x eglot localhost:4567 doesn't connect

[Helmut Eller]

On Fri, Dec 08 2023, João Távora wrote:

> ...for more than one year, probably means very few people
> are using this.  May I ask what your LS is? .

I'm writing my own server.

> Please try the untested patch after my sig.

Yes, works.

Helmut

bug#67682: 30.0.50; M-u M-x eglot localhost:4567 doesn't connect

[João Távora]

On Fri, Dec 8, 2023 at 1:31 PM Helmut Eller <eller.helmut@gmail.com> wrote:

> > Please try the untested patch after my sig.
>
> Yes, works.

Pushed a variant of this patch to master in
50bab2a9f7a3a07c0aa24355e1d3cde547be90b9.

Could probably be backported to emacs-29.

Closing.

bug#67682: 30.0.50; M-u M-x eglot localhost:4567 doesn't connect

[Eli Zaretskii]

> Resent-To: bug-gnu-emacs@gnu.org
> From: João Távora <joaotavora@gmail.com>
> Date: Fri, 8 Dec 2023 19:17:56 +0000
> 
> On Fri, Dec 8, 2023 at 1:31 PM Helmut Eller <eller.helmut@gmail.com> wrote:
> 
> > > Please try the untested patch after my sig.
> >
> > Yes, works.
> 
> Pushed a variant of this patch to master in
> 50bab2a9f7a3a07c0aa24355e1d3cde547be90b9.
> 
> Could probably be backported to emacs-29.

It's okay to backport this to emacs-29, but "git cherry-pick" failed
when I tried it.  Feel free to backport manually, and thanks.