From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 8 Feb 2022 09:20:07 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d51f5a05d77e3910" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19775"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 10:50:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHN9E-0004xk-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 10:50:56 +0100 Original-Received: from localhost ([::1]:50352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHN9D-00069E-6d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 04:50:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHMgI-0007i2-9k for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHMgH-000377-SW for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHMgH-0001vp-QD for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 04:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 09:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.16443120277354 (code B ref 53853); Tue, 08 Feb 2022 09:21:01 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 09:20:27 +0000 Original-Received: from localhost ([127.0.0.1]:45278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHMfj-0001uX-CP for submit@debbugs.gnu.org; Tue, 08 Feb 2022 04:20:27 -0500 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:38401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHMfh-0001uK-6v for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 04:20:25 -0500 Original-Received: by mail-oi1-f177.google.com with SMTP id u13so19886409oie.5 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 01:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g+X/yG4E4Q+f5QZjFoExCt+RemKhfVZab1RBC1CSpuE=; b=BmwnFFEuDACQJ9vYbEiOSYlEGFCjnmfZ/VbOBnTT+mrRltqWilS2RnkSx+kUUAZgr8 J/+ao/ZjPvAeEY0PYbnkpT9JRm7nn//KmJxggL+Sj7YJm75c3JHodeH85oNTHxa6HpFH 4LWM67iJS9GiqzpfqCtHIiyJL7jgELJ/XdFd9dsEdg1j2figAo1vMzerzSlksggVPHQd 3NevuAHjRy1zmpmD2TKvxYZytmJRzNnrErACgaSu6mnrl5tERCW93DEF746AX91Zx7gW zPU4lg+B/qQPBXbXGMZGpbI7tysSJ/eZ+KPQaDc6kXnraJUdFygR+q+sGXVpawVXlPN3 rf7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+X/yG4E4Q+f5QZjFoExCt+RemKhfVZab1RBC1CSpuE=; b=pqOv6G5VbhQMed5tDTtDSTkSwvCk0whVLce9/cNc7mIW1ps1xPhyw9swX6jsAGYn0o 7K75tDvEaCpRvBwJskiYBN7dBy+YGCHqeJwYSWHDAaWbybqTiKt6yVu1/s8f/g9mpoT7 ZuBmBELasteKVNPPBNMLs2Id8Igs1TdJhSrJJBYkT0Lp/Pwyq7kwYAX33Bz47iFaXyra bXrmxmG04fBz2T+uaTEjgqb8gG54ueI4sgXG4aPKuL8dea+Zbs812DhMYBUop5PMKJZZ HGH/JeNoLrSm9lhPX00KOEhXs/YBcU5FUDMCcNqjzSm1YUHGYl1AKFxLPfGTDcb7iuK5 uLdA== X-Gm-Message-State: AOAM531wczrdvipoOLHtJefEx38RSnCEjDkLz49aOGWAplZDlNnHN5PX KAOgltcXvOpLJooTczs9adVXbQG9NqTrlJ7s5ys= X-Google-Smtp-Source: ABdhPJwJvRuhCEri8YiSl1r3eNXTSOf81YzGmyS4gg/q+BgI1vs0a169xZ2kEItTK83/X+RLL7uI4RYtuTIx9vrJBjw= X-Received: by 2002:a05:6808:2016:: with SMTP id q22mr89571oiw.249.1644312019671; Tue, 08 Feb 2022 01:20:19 -0800 (PST) In-Reply-To: <87ee4d7o3f.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226341 Archived-At: --000000000000d51f5a05d77e3910 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I'm not in front of my computer right now, but as far as I recall, there is a note in the preamble of flymake.el asking maintainers not to use functionality incompatible with the given emacs dependency. The solution is either to abide or to create a new package that houses said functionality and then make that a dependency. Jo=C3=A3o On Tue, Feb 8, 2022, 08:35 Robert Pluim wrote: > >>>>> On Tue, 08 Feb 2022 08:28:21 +0000, Brian Leung > said: > > Brian> I'm not sure how this kind of thing is usually handled, but fo= r > this > Brian> specific fix, I think it's worth bumping the version since > there are > Brian> probably a decent chunk of people on Emacs <=3D 27 who will > otherwise > Brian> encounter an issue with Eglot (one guy reported this yesterday > on the > Brian> mailing list). > > If that=CA=BCs the case we should change Package-Requires as well. And > someone=E2=84=A2 should test with emacs-2{6,7}. > > Robert > -- > --000000000000d51f5a05d77e3910 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm not in front of my=C2=A0computer right now, but a= s far as I recall, there is a note in the preamble of flymake.el asking mai= ntainers not to use functionality incompatible with the given emacs depende= ncy.

The solution is either to= abide or to create a new package that houses said functionality and then m= ake that a dependency.

J= o=C3=A3o

On Tue, Feb 8, 2022, 08:35 Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Tue, 08 Feb 2022 08:28:21 +0000, = Brian Leung <leungbk@posteo.net> said:

=C2=A0 =C2=A0 Brian> I'm not sure how this kind of thing is usually = handled, but for this
=C2=A0 =C2=A0 Brian> specific fix, I think it's worth bumping the ve= rsion since there are
=C2=A0 =C2=A0 Brian> probably a decent chunk of people on Emacs <=3D = 27 who will otherwise
=C2=A0 =C2=A0 Brian> encounter an issue with Eglot (one guy reported thi= s yesterday on the
=C2=A0 =C2=A0 Brian> mailing list).

If that=CA=BCs the case we should change Package-Requires as well. And
someone=E2=84=A2 should test with emacs-2{6,7}.

Robert
--
--000000000000d51f5a05d77e3910--