From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Wed, 4 Mar 2020 22:44:08 +0000 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000386da905a00f2991" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="5025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 04 23:45:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9clQ-0001Dh-LS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Mar 2020 23:45:16 +0100 Original-Received: from localhost ([::1]:40730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9clP-0005rj-KG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Mar 2020 17:45:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9clD-0005m8-Fb for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:45:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9clC-0004Ez-Cw for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9clC-0004ES-7Q for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9clC-0003BQ-3j for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Mar 2020 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158336186812181 (code B ref 38992); Wed, 04 Mar 2020 22:45:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 4 Mar 2020 22:44:28 +0000 Original-Received: from localhost ([127.0.0.1]:41939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9cke-0003AP-7a for submit@debbugs.gnu.org; Wed, 04 Mar 2020 17:44:28 -0500 Original-Received: from mail-io1-f54.google.com ([209.85.166.54]:38254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9ckb-0003AB-Ny for 38992@debbugs.gnu.org; Wed, 04 Mar 2020 17:44:26 -0500 Original-Received: by mail-io1-f54.google.com with SMTP id s24so4289568iog.5 for <38992@debbugs.gnu.org>; Wed, 04 Mar 2020 14:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R3DfrIJSOfDUSjbFBxlkgeOM+Lo7/EFG5oYJqY/+Y+M=; b=pspXLXhYJd/DxF54B5nr/PVpMA5naA5tASec29A1PmySci2BecCbQV/GqtnOjV05Hq uuyGZLIL1QOAEuYyixld3A7Gg3Lu+U1q6sBqn7+HQG9bKtNl7FS/RLREbtGHDySZJ/Yi 9gxpmzZGXllcGamV945MaREeEqVzu9kjAjdyOzE5w8GrNpQksHIIOioUfrQKLzOarET2 4s6tIG8ONSZDhIyb0LhJsGSrw6tJlf0wamhsisz9vvACbeQPD7gfJlquIbdhmFL2CroO YipHGkQeF6y566IuUjD2ElU1f3+w7FMc3YF3j69xWd6r5avO5zpRUxJ0TTygaWba7jJF H+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R3DfrIJSOfDUSjbFBxlkgeOM+Lo7/EFG5oYJqY/+Y+M=; b=X+JraHqVIx9RIMNqTd5RF8ayneYlNKywwsXreMdTlaY9u7HAssvj0OmVhi3FcGJkgz NWAMpCfiYqgErNXXfEp2a5mdnQSjvrv6yPnd5pMufXBjyagJD+QEhhcodPkRtAgIBGay I9nIUpp277BPhj27NLg8/F5+4/jB9L0Ca7g1ZRixHKKh3Ds1/aYw1tXB6VP/3jSfl/ch Q6qvxkKnlzKKFGocEizxN+wqSh9Wa7F2rugrSFTGAVJjiyKqbH8+cypr14W6gnjSpHsn YhvjwmGvwUI1N0FycwQAOFFEW6+8n7hrRCCwvh4QTbmHlAoHnafdNL2uOJ1eydT5Ynwv nqBA== X-Gm-Message-State: ANhLgQ06iikTbnZdhLyJvcu841EWeDSVc9IIL/MTTYmHjVknpVjXNhMV hI9r3vROgRVy/JSrKK5em0eD58rjkNQoTex7PW4= X-Google-Smtp-Source: ADFU+vs60iZ+SzMV2vHbryf3W0h/r/2eyMzBndjOll2pXmLcwCvjuLoKF8B9tF5gYpduQm7CfcReMJPKt3EQFdU/FTk= X-Received: by 2002:a02:70cc:: with SMTP id f195mr1549528jac.78.1583361860069; Wed, 04 Mar 2020 14:44:20 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176862 Archived-At: --000000000000386da905a00f2991 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 4, 2020 at 10:07 PM Dmitry Gutov wrote: > It's a bug because it changes icomplete-mode in a way that makes > completing-read fail its contract (which is to demand matching input > when require-match is non-nil) in certain situations. fido-mode doesn't change icomplete-mode. It shouldn't, at least. It just uses it as a library. And surely if it's a bug in fido-mode, surely it needs fixing _there_ and not elsewhere. But it seems not be the case (at least with your latest proposal), so you have me confused. > > Great! Disregard the previous discussion if you want, just do this, > > and move on. > > Yup. So much time has passed that I don't remember what the fix was anymore. Have you pushed it? I don't see it in emacs-27 Jo=C3=A3o --000000000000386da905a00f2991 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 4, 2020 at 10:07 PM Dmitry Gutov <dgutov@yandex.ru> wro= te:
> It's a bug because it changes icomplete-mode in a way that = makes
> completing-read fail its contract (which is to demand matchin= g input
> when require-match is non-nil) in certain situations.<= /div>

fido-mode doesn't change icomplete-mode. It sh= ouldn't, at least.
It just uses it as a library.=C2=A0 And su= rely if it's a bug in fido-mode,
surely it needs fixing = _there_=C2=A0 and not elsewhere.=C2=A0 But it seems
not be t= he case (at least with your latest proposal), so you have
me= confused.

> > Great! =C2=A0 Disregard the previo= us discussion if you want, just do this,
> > and move on.
><= br>> Yup.

So much time has passed that I don'= t remember what the fix was anymore.
Have you pushed it?=C2=A0 I = don't see it in emacs-27

Jo=C3=A3o
--000000000000386da905a00f2991--