From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Fri, 24 Feb 2023 12:09:14 +0000 Message-ID: References: <87a614g628.fsf@gmail.com> <83cz60r7hu.fsf@gnu.org> <875ybsfvtj.fsf@gmail.com> <831qmgr17p.fsf@gnu.org> <87wn48ecdz.fsf@gmail.com> <83v8jspgnr.fsf@gnu.org> <87lekodxja.fsf@gmail.com> <83a614p4sh.fsf@gnu.org> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <83pm9znw0i.fsf@gnu.org> <83ilfrnum2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19824"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61726@debbugs.gnu.org, arstoffel@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 24 13:10:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVWu2-0004wc-Ig for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Feb 2023 13:10:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVWtq-0007xW-HN; Fri, 24 Feb 2023 07:10:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVWtn-0007x6-ED for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVWtn-00037A-4q for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVWtm-0007Rs-VE for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2023 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.167724057328568 (code B ref 61726); Fri, 24 Feb 2023 12:10:02 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 24 Feb 2023 12:09:33 +0000 Original-Received: from localhost ([127.0.0.1]:36185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVWtI-0007Qi-QB for submit@debbugs.gnu.org; Fri, 24 Feb 2023 07:09:33 -0500 Original-Received: from mail-oa1-f48.google.com ([209.85.160.48]:34780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVWtG-0007QT-Kt for 61726@debbugs.gnu.org; Fri, 24 Feb 2023 07:09:30 -0500 Original-Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-1723ab0375eso14982581fac.1 for <61726@debbugs.gnu.org>; Fri, 24 Feb 2023 04:09:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677240565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bsWUUvBAAqZ5GfnQFqzsk7lUx/E1+rz6tKQK5Ggf3+4=; b=QpOIHyJB9I+ZV87WhMvknYfQVLK5ZenjwOeERsCar4LYjkQyduW2nJ7e4BMtAPHTaV uL3xqogiCjGcaWxUQV9itFEccrzW0MFgLU6cdJXKZ9cg9hU66OxpanPOIylMkYwnaVnx gHnaKSwzgxhRq6/gwp/3JykmN93RR+ZnCapxdXaOmaqSD17Uwc5oykXElP3IPnUIaO4d ++32WYIeAnmYTnVZpeRqPRFZ1mtpLA9V2kMQStDQFaiRcMPbsmIDNm1b9DWvC6v+vBo5 N6J9qnUWBuViGu+XKiHTcFGgGLVNvigSg5k5yNOW+ua6cj7tXTV3LOexxLIQTvKDxMWD EQFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677240565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bsWUUvBAAqZ5GfnQFqzsk7lUx/E1+rz6tKQK5Ggf3+4=; b=mLjh5VHBu1rdj6Q5FvBuMGUseoP2QHHDanPFbFxzYAZy0cQN+9Qyxvh0Q+gRdqUvb2 z325PlY7TujObPzpVU0QIO5VhpPbM4D/8YKfgnSLzb3wHS2b9aII7Ta2ylBFVMH3CR2b naDFwes2/Lv/arGj5wLENasPAlGxD6MuXW3VOQLbp6P1Zzi9XWgHpZmMbgj8pun/P+gW dOFs2QPLN7pbbEnYfpbbrsCNyy38knOOlhvCrKFIqlwam3lR7JWTA+DsBVM9vu92XlZl fA9541iONs/IDcO/HiUjTjxrhMCfr6QxgSazb61BSxywcV9peDF+CEhk1hBl5pEfRAHB UXFA== X-Gm-Message-State: AO0yUKUMJo9swZLSaU1h8ieADGa3z3pAuFdE71MR3xWQcvSy43FJ1gQy IgqCH4zD2r0bjMa5KSm63S9XO5l3qx145r3T075QSf3X X-Google-Smtp-Source: AK7set99EqBsotscguQWq/APGVy8uwjMXaOz196TE6cHl2TcNDPETRGVtRFK3YnKPFl5QBF4wnSf8IjAyi+A8T0ko2o= X-Received: by 2002:a05:6870:954f:b0:16a:6ab4:e878 with SMTP id v15-20020a056870954f00b0016a6ab4e878mr970587oal.8.1677240565112; Fri, 24 Feb 2023 04:09:25 -0800 (PST) In-Reply-To: <83ilfrnum2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256578 Archived-At: On Fri, Feb 24, 2023 at 11:57 AM Eli Zaretskii wrote: > > eglot-current-column is a user-visible function. would need > > obsoletion aliases. > > Yes. But that is not a problem, from my POV. True. > > Are you sure it isn't better just to add some clarifying comments? > > I'm okay with that as well, but the clarifications should be in doc > strings of public functions as well, if we go that way. Yes, makes sense. I'll let you decide what is cleaner: sweeping renames or docstrings. And thanks in advance. > > And, as far as I remember, at the time we were indeed using move-to-col= umn and > > current-column. But now we aren't anymore. > > > > So maybe, just maybe, this can be removed. And the full test suite mus= t > > run afterwards. And then probably more tests should be added. > > How about removing it on master? Doesn't make much of a difference because ELPA :core package. If the change is harmful, that harm will be visible "soon". I think we can just add some tests to eglot-tests.el and test the problematic case collected from the old bug tracker, if it's not being tested already. Jo=C3=A3o