From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'? Date: Mon, 18 Sep 2023 13:52:06 +0100 Message-ID: References: <1f9e98be-3248-56cf-b7fd-8301666675c6@gmail.com> <1e19cc18-9942-aa51-c49e-9441e873f037@gmail.com> <83edivg3rg.fsf@gnu.org> <83zg1jemi8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36046"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 66041@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 14:53:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiDkP-0008yB-89 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 14:53:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiDkE-00087L-Oz; Mon, 18 Sep 2023 08:52:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiDkD-000873-SZ for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 08:52:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiDkD-00042W-KH for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 08:52:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiDkL-00036N-Pf for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 08:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 12:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66041 X-GNU-PR-Package: emacs Original-Received: via spool by 66041-submit@debbugs.gnu.org id=B66041.169504155611878 (code B ref 66041); Mon, 18 Sep 2023 12:53:01 +0000 Original-Received: (at 66041) by debbugs.gnu.org; 18 Sep 2023 12:52:36 +0000 Original-Received: from localhost ([127.0.0.1]:52388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiDjw-00035V-98 for submit@debbugs.gnu.org; Mon, 18 Sep 2023 08:52:36 -0400 Original-Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:61647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiDjt-00035B-G1 for 66041@debbugs.gnu.org; Mon, 18 Sep 2023 08:52:35 -0400 Original-Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50305abe5f0so2735204e87.2 for <66041@debbugs.gnu.org>; Mon, 18 Sep 2023 05:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695041538; x=1695646338; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zk3y/CWlUTghhTXesB+DukG0b4USwZlihYR6rZSp61I=; b=aCaiElIbNxZOI1ykh+uxNDqXUvXnjSjI/O/Ul6VzVOkX4btOo62D1q6nOLTqQz8Xr3 KbaGikjCuNzaqMuFUJKNMg9gaZ7pwQ7YYmKW8pozA/+m4nDTA7o4t/nE5Kskxglpv10S HLV6W/JBP9/N+Bzgw/vK5oVhUk6/CHCcIx9JLvUfu3ePjwX2U2YJD8OP/U5KUhR1kux2 leqv8jXYvhe1TcUX74bU6paftvMDkpPX//RM/af1uV0axFocsczscGTvWBLatppN46uc BmOA+4IN5U4uOShL4c4qd+p8ZESpA3qmhGijau+5urP0A8Zy5VteXCLMN6pEAdsQKVDk 4+0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695041538; x=1695646338; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zk3y/CWlUTghhTXesB+DukG0b4USwZlihYR6rZSp61I=; b=HMgH5ELuxiLXB7jaKw2+Ad3PeKtHiNvaLPH9sU8J1PHwdhG6jfB3LgqgHWmfeMpy7y 6edLf+Az1YEZYy5JbpmbgiAalf0cDPHpRFd4m7QdmbFIA1VZq6Dch2MRpJjstFZslyEh HOYbT1FCtTvzkxoNizK2gn3orAQOcMAtp//TPsGj53pVCSyDRgYL4u6BL4vZ03S65DTA M6BYATo944pRgJdHTbuMcaEiJ8fBs2nTSySFDovO2kOvubwBF4NiGquaDkJOnFGTIRYE a0PsNFHiD48rSFXd5yq56ibm5G0689XO2PRqeSpZYpONVNHgOlR5+LMf7TvXGTJZtFLk uGiw== X-Gm-Message-State: AOJu0YxJvSh14ZbNCWZDHXLwvvXal/wy6NGDw4flnWUn/yiI51SF74FV CHUFd47iAu4ymCfo/lCQtd7HdV/KvzpLH/dAysk= X-Google-Smtp-Source: AGHT+IFhRr33RWjtHD/h76cMJ3Si7l3iKksib7qlCdGxqPAizOW70pGwfXJ22vmUXcG1glSz/MINYNymXDC0e7OVWu8= X-Received: by 2002:a05:6512:2207:b0:503:985:92c9 with SMTP id h7-20020a056512220700b00503098592c9mr4630011lfu.22.1695041538300; Mon, 18 Sep 2023 05:52:18 -0700 (PDT) In-Reply-To: <83zg1jemi8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270791 Archived-At: On Mon, Sep 18, 2023 at 12:42=E2=80=AFPM Eli Zaretskii wrote= : > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Mon, 18 Sep 2023 11:46:55 +0100 > > Cc: Jim Porter , 66041@debbugs.gnu.org > > > > On Mon, Sep 18, 2023, 11:44 Eli Zaretskii wrote: > > > > > Cc: 66041@debbugs.gnu.org > > > From: Jo=C3=A3o T=C3=A1vora > > > Date: Sun, 17 Sep 2023 23:15:31 +0100 > > > > > > emacs -Q > > > M-x flymake-mode RET > > > M-: (setq flymake-show-diagnostics-at-end-of-line t) RET > > > M-x erase-buffer RET > > > h e l l o > > > > > > The first bug I find is that the exclamation mark on the fringe is > > > green, but it should be yellow, since, presumably a warning is > > > more important than a note. > > > > > > The second bug has to do with the placement of the cursor when > > > two "eol overlays" are present. The cursor shouldn't be placed > > > in the middle of them, since they represent unreachable areas of > > > the buffer. > > > > When I try the above, the cursor is at the end of "hello", and the > > overlay with the warning is displayed after it. So I don't think I > > understand what you mean by "in the middle of them". > > > > Sorry. The recipe is missing a single SPC character after the hello, so= that the style warning is > > triggered. > > You have there two overlays, each one with a before-string, and each > string has its first character propertized with (cursor t). So Emacs > picks up one of the two overlay strings to place the cursor, and it > just happens to be not the one you wanted. Yes, something like that. Skimming the code, I think I meant for only one overlay, not two, to be the end-of-line overlay containing the two strings. But this was tricky to implement and I probably missed an edge case. There is a FIXME there, have to investigate. Anyway, since I have your interest, any suggestions on how you would implement this? Knowing that this feature is upposed to display multiple pieces of relatively short cursor-unreachable text visually after the end -of-line (the text being the diagnostic text, naturally). Currently I'm placing them exactly between (line-end-position) and the character after that. There is a link between this eol overlay and the origin diagnostic. If you delete the latter, the former should be recalculated asap, i.e. it should ideally not wait another 1s or two before Flymake re-contacts the backend for up-to-date info. Jo=C3=A3o