From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#72824: Eglot highlights matches incorrectly wrt case sensitivity Date: Tue, 27 Aug 2024 15:38:37 +0100 Message-ID: References: <05924929-997f-4d37-ba3b-a4620a687c03@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7786"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72824@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 27 16:39:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sixLy-0001oM-Qi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Aug 2024 16:39:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sixLj-0004lW-B0; Tue, 27 Aug 2024 10:39:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sixLh-0004lM-RY for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 10:39:09 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sixLh-0005XP-FR for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 10:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=Su7ngObOPH8sDdbHVe07sqzBRx6hXl9njfsIhJVmC80=; b=E+3FgGaxi9x53oMc/7aTkeTSlKC0BQH8o1jrOdGkzjSmGzEsXr7dW03Kokf1A/Ftjp3qtit4o17jT9B/6s1ozkVpN/tdBLHwercFqPEt9DiiaEJCRnUF6jhuzOEEozF5QZjI5UoQlkSXCAubIvRZfaqk0D4hKOe020Yg+O9obv3kW/Pd9dvgzKqPMCdGcGJ8+qXGec1+lCd5VuWGv0FIUGBXn4ThQnEakBW0sndxgnRRbH1ckTgojBshPDL6V5W/w96yjI53k50YZO7xDk7I4WQNpmKQUWknkhUw4gNsIzaVuff0rNZvsI7eBWu4nOY5Xob63YE3iMrNioEE7s6kaQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sixMY-0006X5-4x for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 10:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2024 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72824 X-GNU-PR-Package: emacs Original-Received: via spool by 72824-submit@debbugs.gnu.org id=B72824.172476956125048 (code B ref 72824); Tue, 27 Aug 2024 14:40:02 +0000 Original-Received: (at 72824) by debbugs.gnu.org; 27 Aug 2024 14:39:21 +0000 Original-Received: from localhost ([127.0.0.1]:47152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sixLt-0006Vv-FJ for submit@debbugs.gnu.org; Tue, 27 Aug 2024 10:39:21 -0400 Original-Received: from mail-oi1-f179.google.com ([209.85.167.179]:55542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sixLr-0006Vg-Q2 for 72824@debbugs.gnu.org; Tue, 27 Aug 2024 10:39:20 -0400 Original-Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3db157d3bb9so453542b6e.2 for <72824@debbugs.gnu.org>; Tue, 27 Aug 2024 07:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724769441; x=1725374241; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Su7ngObOPH8sDdbHVe07sqzBRx6hXl9njfsIhJVmC80=; b=V1FgfjJqeHUUYGVZE6RF7bN9P9j3SB98CQrWCvc70HvbkkuNVMrPLi4Ld6jISmhQhQ HBiZ/pjQ8Z4VRMn8mUBCVSwkpD9qSDb/UrthNpJsUCsaDvnQ9VlTUMt6eObGjql2pCyV KNRFxyAjDE/O64816sn3IPISkxvlWJuZNFdxdl5T02shPzUSIJF03j/aYsrhduwjToTn qE6sM0FNe+LEclEjHOHY3ewCF6gtG3x0m9OP/7tyCtt4gDj/ZOVIZyd1sQsIKOeXNazO Gk5ElAst+uTeSde8b0jM6R3/Djyiv3Y+FRcY6jGnliDtQ08hsAsKw8SnOp1Je7KqXNh+ /PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724769441; x=1725374241; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Su7ngObOPH8sDdbHVe07sqzBRx6hXl9njfsIhJVmC80=; b=P8e/gvBeT2PDFqsTn7J1GqBmh/Om8sjdlemCIvxS+z3Mi8PVBZpgTipTPUuTET8lz0 p9O68kSy3fuE/Ey58XZbaTgl8uNlQZJoCxBLOZH5XMsVCm85BGeMrTss+BalFRYZKviO 1Jr0ja7FudbOSWVhBW88NVN1sT87XDHCUUeN9H2wWRa/FJdN/Jy4UBkCsoGJO8pf0i3P sPvMcEFq9G2cgG/dpo315Dt7qapIMPLfqF1U9JI2gFk8EZsRHmHG/GTI1R8Oxs3qPc3G jv51mkyBq5aX1R+QUtUrN0+q4uC3gePgkWltEsKY9Ilom+J1fRJBRrroCAzadnzMiR10 hY/Q== X-Gm-Message-State: AOJu0Yz2NBVedVvSRl5N9D7fgzWdvBjjoishlv0eQyMOsHu+VhjjIqiv ji7A0K930WDNRu1Km4eGeQzQMKjWCqm8p4HeTGSL1NHo0uw6wfE8+zcSNYVz3kHOpSmYteI7c7W RtTbXnjVNOwnRLqkTWS0dyqTsYz8= X-Google-Smtp-Source: AGHT+IGKsUyHl3Cnlnl72xWmDBE6QAEPOCi/uLPz+xEW9Q5jQP/gaVesfPIH1BZ/54HJSz4MpN1lHmp62qhwXAyybIU= X-Received: by 2002:a05:6808:1914:b0:3d5:65d5:edae with SMTP id 5614622812f47-3de2a8a0828mr14971170b6e.27.1724769441453; Tue, 27 Aug 2024 07:37:21 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290828 Archived-At: Also, btw, completion highlighting is naturally borked too. There is no guarantee that that naive flex algorithm is what the server used to select those completions. On Tue, Aug 27, 2024 at 3:36=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > I think the fix makes sense. Please push it to Emacs 30, and thanks > in advance. > > If you can please use this format for the commit message subject, > which is my more or less usual practice. > > Eglot: fix the frobnication (bug#12345) > > * lisp/progmodes/eglot.el (eglot-foo): pass foo to eglot-bar. > > On Tue, Aug 27, 2024 at 2:41=E2=80=AFAM Dmitry Gutov w= rote: > > > > X-Debbugs-Cc: joaotavora@gmail.com > > > > 1. Server gopls, for example. > > 2. completion-ignore-case=3Dnil, its default value. > > 3. Input "clCe" and completions for it like > > > > clockCenterX > > clockCenterY > > > > Completions are case-sensitive, but completions' highlighting works as > > if it's insensitive - highlights are on "cl", second "c" and "e", > > whereas the capital "C" is not highlighted. > > > > This fixes it for me: > > > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > > index 844fc634be9..acc197754db 100644 > > --- a/lisp/progmodes/eglot.el > > +++ b/lisp/progmodes/eglot.el > > @@ -3260,7 +3260,7 @@ eglot-completion-at-point > > (try-completion pattern (funcall proxies))) > > ((eq action t) ; all-comple= tions > > (let ((comps (funcall proxies))) > > - (dolist (c comps) (eglot--dumb-flex pattern c t)) > > + (dolist (c comps) (eglot--dumb-flex pattern c > > completion-ignore-case)) > > (all-completions > > "" > > comps > > > > > > > > > -- > Jo=C3=A3o T=C3=A1vora --=20 Jo=C3=A3o T=C3=A1vora