bug#72824: Eglot highlights matches incorrectly wrt case sensitivity

["João Távora" <joaotavora@gmail.com>]

Also, btw, completion highlighting is naturally borked too.  There is
no guarantee that that naive flex algorithm is what the server used
to select those completions.

On Tue, Aug 27, 2024 at 3:36 PM João Távora <joaotavora@gmail.com> wrote:
>
> I think the fix makes sense.  Please push it to Emacs 30, and thanks
> in advance.
>
> If you can please use this format for the commit message subject,
> which is my more or less usual practice.
>
> Eglot: fix the frobnication (bug#12345)
>
> * lisp/progmodes/eglot.el (eglot-foo): pass foo to eglot-bar.
>
> On Tue, Aug 27, 2024 at 2:41 AM Dmitry Gutov <dmitry@gutov.dev> wrote:
> >
> > X-Debbugs-Cc: joaotavora@gmail.com
> >
> > 1. Server gopls, for example.
> > 2. completion-ignore-case=nil, its default value.
> > 3. Input "clCe" and completions for it like
> >
> >    clockCenterX
> >    clockCenterY
> >
> > Completions are case-sensitive, but completions' highlighting works as
> > if it's insensitive - highlights are on "cl", second "c" and "e",
> > whereas the capital "C" is not highlighted.
> >
> > This fixes it for me:
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 844fc634be9..acc197754db 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -3260,7 +3260,7 @@ eglot-completion-at-point
> >              (try-completion pattern (funcall proxies)))
> >             ((eq action t)                                 ; all-completions
> >              (let ((comps (funcall proxies)))
> > -             (dolist (c comps) (eglot--dumb-flex pattern c t))
> > +             (dolist (c comps) (eglot--dumb-flex pattern c
> > completion-ignore-case))
> >                (all-completions
> >                 ""
> >                 comps
> >
> >
> >
>
>
> --
> João Távora



-- 
João Távora