From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Tue, 7 Mar 2023 14:03:34 +0000 Message-ID: References: <87y1ootw2t.fsf@gmail.com> <878rglxrzm.fsf@gmail.com> <87cz5wmjbx.fsf@gmx.de> <87h6v8f7u9.fsf@gmail.com> <87o7pflfcd.fsf@gmx.de> <87wn43e9ht.fsf@gmail.com> <874jr6oont.fsf@gmx.de> <87sfeqd4zi.fsf@gmail.com> <877cw1swjm.fsf@gmx.de> <87k0016dgo.fsf@gmx.de> <1458446553.50372.1677606917251@office.mailbox.org> <87ilfkh89k.fsf@gmail.com> <87y1ofct83.fsf@gmx.de> <87356n8kja.fsf@gmail.com> <877cvvfnp6.fsf@gmx.de> <54377687.213790.1678016749459@office.mailbox.org> <87356jfktc.fsf@gmx.de> <87a60ovi90.fsf@gmx.de> <31964054.380679.1678194256931@office.mailbox.org> <87r0u0u0rl.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thomas Koch , 61350@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 15:05:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZXwM-0004Fl-QP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 15:05:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZXvI-0006fZ-1Y; Tue, 07 Mar 2023 09:04:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZXvA-0006bN-1P for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 09:04:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZXv8-0001oQ-H6 for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 09:04:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZXv8-0004OU-BG for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 09:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167819783516875 (code B ref 61350); Tue, 07 Mar 2023 14:04:02 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 7 Mar 2023 14:03:55 +0000 Original-Received: from localhost ([127.0.0.1]:44896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZXv1-0004O7-1q for submit@debbugs.gnu.org; Tue, 07 Mar 2023 09:03:55 -0500 Original-Received: from mail-ot1-f41.google.com ([209.85.210.41]:40525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZXuy-0004Nq-KJ for 61350@debbugs.gnu.org; Tue, 07 Mar 2023 09:03:53 -0500 Original-Received: by mail-ot1-f41.google.com with SMTP id m25-20020a05683026d900b006941a2838caso7187828otu.7 for <61350@debbugs.gnu.org>; Tue, 07 Mar 2023 06:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678197827; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zy3Dot4NNlRZIxKRLUljvXRkDUb2In3oXpKNF6D6ZnQ=; b=dBIxDzrxS7A4hrJLniPD4L5SiBwdGteFjmAv/Z8KPSdxhXWhtQ0sDUT5QPtAsYAT7W UutbGMZeNc2SGqYeYCCBKyRdAYsFONQ6vbfnnIAOIrAfKQfHtuX00+HNNju5Va7i1pn5 YYq+gwUWJhDjI6SqaVot3B6Kv6J19LOJrXJhLIGhgynMazUNVL48sMJFfLqNpXVHfAE1 n2nLe/6EEXc9qf4gE2DchKYn+C3uiYlCMd8wlXzcw7yaOd4fkEkAQ8EKggbQ5TNj9cBh hVHUxJcI63irVVfJDECszkMbQWmdk2cJ7pZGWqW23ojJmVYPIsadTQ8r4BRc8cLbOef7 TykA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678197827; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zy3Dot4NNlRZIxKRLUljvXRkDUb2In3oXpKNF6D6ZnQ=; b=k/KysQVrpMb9ULCsjshRFU3nrjoQnsFRlQQZ/fX6XZSr5XEeGWo0XHq1sRFA29yR7H qYYFXSD/KLtPGx8gsTaD/KM0IytxuQkxIWDLuHlFpTEHVW716MaGjnIAbINNTU9ylwaB avvjNajIqXceH/GYLHyG83ie6GSlpOkOnVGtRJf28QGHX6lm7eU3Xt/nvKOoRIJqj/dq OAwXF43rKVTt9WDvY95nTWSP3KMAu5Ub3DH5yfXEzc+YD/Hn4qF3z9zTrLWnZ1xEE6mm d2fRNq1roVmbSv3N2rzE1jvkkXMzw8xfgaJ1nGEhIIck4qqqmcK7VDyfKyLxU7zZgJVX g5Dw== X-Gm-Message-State: AO0yUKXI927xdcXSpNHyxWQCjE6NMcDrxccmzp/gwMe5wXNFFq4ulfk2 0TPVJOkGeYK3YrInJzMF2wJUPZulChRv4kiNwLc= X-Google-Smtp-Source: AK7set/oxEOME3stzabEuaJxC6gt7TWckXnz1IsqLIVQi0WAu8oEG8Zp/kblvtYHVYfLrWqngqK2Lm0NdjBEXnMhKgk= X-Received: by 2002:a9d:6112:0:b0:68d:4b7f:e993 with SMTP id i18-20020a9d6112000000b0068d4b7fe993mr5070639otj.3.1678197826115; Tue, 07 Mar 2023 06:03:46 -0800 (PST) In-Reply-To: <87r0u0u0rl.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257461 Archived-At: On Tue, Mar 7, 2023 at 1:52=E2=80=AFPM Michael Albinus wrote: > > [In accept-process-output, ] If PROCESS is > > non-=E2=80=98nil=E2=80=99 then this function does not return until= some output has > > [^^^^^^^^^^^^^^^^^] > > been received from PROCESS or PROCESS has closed the connection. > > > > > > Note "some", not "all". So while less common, I think the hang > > can still happen. > > > > So maybe you meant: > > > > (while (accept-process-output p 0 nil t)) > > > > as suggested in that section? > > That was my first idea as well. But tramp-accept-process-output itself is > called in a loop, so there's no difference in practice[1]. Hmmm, I still don't think they are equivalent. In tramp-a-p-o with TIMEOUT set to nil is where it normally hangs, right? Well then, if it does hang it will _not_ be called in a loop, by definition. So the prior "hang removal" a-p-o call that you added must _still_ be made in a loop itself to ensure that the outher existing inner call: (accept-process-output tprocess nil nil t) will not block due to the conditions you described. Regardless, if this were my code. I'd put a big fat FIXME there explaining that I want to remove the JUST-THIS-ONE, but I'm afraid to :-) > [1]: In theory, there's no difference between theory and practice. In > practice, there is. :-) hehe :-) > Pls give my patch testing, in order to see whether Tramp still blocks. I will do that later. But 10 out of 10 successes in your testing is a pretty solid indication that this is on the right track. Jo=C3=A3o