From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#54488: 29.0.50; move-to-column/overlay-related regression in latest master, perhaps 28? Date: Mon, 21 Mar 2022 16:37:18 +0000 Message-ID: References: <87bkxzdccp.fsf@gmail.com> <831qyvfpv4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000c48b305dabd1943" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54488@debbugs.gnu.org, Dmitry Gutov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 21 17:37:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWL1q-0001ds-K4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Mar 2022 17:37:10 +0100 Original-Received: from localhost ([::1]:44428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWL1p-0004Sp-8k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Mar 2022 12:37:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWL1i-0004Sf-Nn for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 12:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWL1i-0006dl-Er for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 12:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWL1i-0006OD-Cj for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2022 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54488 X-GNU-PR-Package: emacs Original-Received: via spool by 54488-submit@debbugs.gnu.org id=B54488.164788059424526 (code B ref 54488); Mon, 21 Mar 2022 16:37:02 +0000 Original-Received: (at 54488) by debbugs.gnu.org; 21 Mar 2022 16:36:34 +0000 Original-Received: from localhost ([127.0.0.1]:37963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWL1G-0006NV-E2 for submit@debbugs.gnu.org; Mon, 21 Mar 2022 12:36:34 -0400 Original-Received: from mail-oi1-f178.google.com ([209.85.167.178]:38433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWL1F-0006NJ-73 for 54488@debbugs.gnu.org; Mon, 21 Mar 2022 12:36:33 -0400 Original-Received: by mail-oi1-f178.google.com with SMTP id n7so16775230oif.5 for <54488@debbugs.gnu.org>; Mon, 21 Mar 2022 09:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fE1FU9qU9KEmAFYGgQTXLYefM/ZN9Gqs1ZK0CEMvnGM=; b=cZSmNsdYwkj0ryW6AupUPLc5r5bjE7JpiUX0Kf2sy5OayLPquoOiNy5sPSMdLivOn/ 0ZhF4SU4toIUfXVGNox7H/LxzmsNzsXD5YYQ6GghkGGYb9V1kdaM7wGNkN9ckHpdlh7J sQ9O9GdapiIQAwSvE6L2U28x6rF4g6tgy0nqcpE3IR3r9W1pyTQW3pbB0hrpuGt3K/fm 8pKGE6nhq5lCT4lp+Wq9jQe3vgWrHPnDIHxm5AlWPc7+XzAxodqN5WuboDfekjIZVOcM DAOv53XL44+4MuKI7HjdDX0kYWoGPM2t0albDgMFW0EtsHSbpARH2jn8ly/AG6O8fft5 OUyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fE1FU9qU9KEmAFYGgQTXLYefM/ZN9Gqs1ZK0CEMvnGM=; b=fvBlefZXwJ7fB20reqgVefR6aii9eDOsXMxXZCkjVDbP1CxkhEPuKvt7T7AR2hlBdS b42j/QwkqH75hHjK4JwT3/UOD8JdkHAIT/6D+YUgRkcum7d6CQALJoGljsnVJ7mMAY19 mawo7TUKB4LYpqxkyq2vfJMjLIq4Vt4Gs7hAWoa/6v2jiF3e2VCkNGx1bY7Pmvh2urGp DpWQ7lDeJGmzmxx7396raW5yYFNi/eTCxTQDFl4gW0vCi0f9DrKLjs1aptzXtnZ4J2c3 JNExB1VZZu+g+bzL43UfK/aix2S2AH00iy7cauSZZJP/tLw8xYPXfv0Mhbp/DYev5Q3k T+Sg== X-Gm-Message-State: AOAM5332HHI8MXS93zggOpddKxwc03eGOOOaRVlcVd2M6Y2zSt2biQc3 XiPfGVzKMOrkqZn4lYQJjOTxtNDXnVL8A5c/m8Q= X-Google-Smtp-Source: ABdhPJzySp4gNNdMJsdAC0/w3+AGBnTlGhmk9JD1gsQm3jjeecnl0CuVoKy1zvgG408p+cU3qOO5rt7xpLQhLVmaDfM= X-Received: by 2002:aca:2b0d:0:b0:2d9:dc99:3898 with SMTP id i13-20020aca2b0d000000b002d9dc993898mr13659414oik.209.1647880587461; Mon, 21 Mar 2022 09:36:27 -0700 (PDT) In-Reply-To: <831qyvfpv4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228690 Archived-At: --0000000000000c48b305dabd1943 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 21, 2022 at 12:32 PM Eli Zaretskii wrote: > Emacs 29 has a fix for an old bug, whereby current-column etc. didn't > take display strings and overlays into account; now they do. > > Of course, it could be that this fix introduced a bug in some > not-so-simple situations, so I'd appreciate if you could show a simple > recipe to reproduce the problem without the need of firing up > company-mode and/or Eglot. > The only pathological problem -- that I know of -- is the "not-so-simple" example/situation I described. But it's pretty real and easy trigger if you happen to use those two extensions which are both reasonably popular. If you are aware of the behaviour change , then I don't see the point with coming up with a simpler repro: I'd just be showing what you confirmed: that move-to-column now is affected by overlays such as company's whereas before (emacs 27.2/28) it didn't. If this is a bugfix in Emacs, then the logical conclusion is that the problem should be fixed in company-mode. It should somehow (tm) find a way to create a visual popup that works in terminals for which move-to-column behaves as before. Alternatively, some variation of move-to-column that retains the old behaviour could be invented to give the old behaviour. Both these solutions would be better than the current defensive one in Eglot, which makes Eglot LSP-abiding column-finding less performant than it used to be. Jo=C3=A3o --0000000000000c48b305dabd1943 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Mar 21, 2022 at 12:32 PM Eli Zare= tskii <eliz@gnu.org> wrote:
Emacs 29 has a fix for an old bug, whereby current-column etc. didn't take display strings and overlays into account; now they do.

Of course, it could be that this fix introduced a bug in some
not-so-simple situations, so I'd appreciate if you could show a simple<= br> recipe to reproduce the problem without the need of firing up
company-mode and/or Eglot.

The only pat= hological problem -- that I know of -- is the "not-so-simple"
example/situation I described.=C2=A0 But it's pretty real and ea= sy trigger
if you happen to use those two extensions which a= re both reasonably
popular.

If you = are aware of the behaviour change , then I don't see the point
with coming up with a simpler repro: I'd just be showing what yo= u
confirmed: that move-to-column now is affected by overlays= such
as company's whereas before (emacs 27.2/28) it didn'= ;t.

If this is a bugfix in Emacs, then the logical= conclusion is that the
problem should be fixed in company-mode.= =C2=A0 It should somehow (tm)
find a way to create a visual popup= that works in terminals for which
move-to-column behaves as= before. Alternatively, some variation of
move-to-column tha= t retains the old behaviour could be invented to
give the ol= d behaviour.

Both these solutions would be better = than the current defensive
one in Eglot, which makes Eglot LSP-ab= iding column-finding
less performant than it used to be.

Jo=C3=A3o
--0000000000000c48b305dabd1943--