From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master Date: Mon, 10 Apr 2023 10:51:08 +0100 Message-ID: References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> <87zg7ggkzo.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36066"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 62741-done@debbugs.gnu.org To: Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 10 11:52:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ploCH-0009AE-Pi for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Apr 2023 11:52:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ploBx-0001SC-Qy; Mon, 10 Apr 2023 05:52:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ploBv-0001Rc-HL for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 05:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ploBv-0006cu-9S for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 05:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ploBu-00070G-Ir for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 05:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Apr 2023 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62741 X-GNU-PR-Package: emacs Original-Received: via spool by 62741-done@debbugs.gnu.org id=D62741.168112028826877 (code D ref 62741); Mon, 10 Apr 2023 09:52:02 +0000 Original-Received: (at 62741-done) by debbugs.gnu.org; 10 Apr 2023 09:51:28 +0000 Original-Received: from localhost ([127.0.0.1]:34354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ploBL-0006zQ-NJ for submit@debbugs.gnu.org; Mon, 10 Apr 2023 05:51:28 -0400 Original-Received: from mail-oo1-f48.google.com ([209.85.161.48]:34565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ploBI-0006yp-UG for 62741-done@debbugs.gnu.org; Mon, 10 Apr 2023 05:51:26 -0400 Original-Received: by mail-oo1-f48.google.com with SMTP id m20-20020a4ae3d4000000b00538c0ec9567so635596oov.1 for <62741-done@debbugs.gnu.org>; Mon, 10 Apr 2023 02:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681120279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k/S73ZHW9ma2AVueYEn4DBNCSmceVVrVobkAitwZnME=; b=e22tUCVDDXGHXfrHlCRcZkfmDqcPJ0L2t4GAftbqVvCtR9p7vQ4mcUk/ZSgGKRjOvI Mz6fw9gacTnaV0660QXCVLpXFo0/Nm2UZ+X27Oy97APwJiNJGPtYebvx5MVsaKAZr1NM Zx6WgDHRaRN4lUJ68RYFDXl/JANqje4Nn1kp7/LNmDQ8RuMeNmHGCa/Hh3TClztr8elA jOqNwQ7yW6x756RU/3+KEDT64kq9X0LmiLEGAkGZcebb4wLqBIyWeA6S8FFmWDugXPeU XYGS6nVkcuz2Hu18llDXynnf2EzYkrf3Z/E+YR2CzM97TZMBNLZFMsajuIkmlG3dbDQE 7KhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681120279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k/S73ZHW9ma2AVueYEn4DBNCSmceVVrVobkAitwZnME=; b=n1CRWD/FFK9lBb6/kuQCxV4yoyuVZFC9GmQKagCG0vfc7/gw3tyL9JdXgsbb6bEjwq DMTDWCGhMe4gPvnyynVOXmcdLsmldRQ5/QWP2dukcfEHkLy56JSk2t5lhLhlZZd5Gu1D iLkobIWnRyAIZ3RH06bTOB6Y+I2OHO3Vz5Qsp25gZkPqI0s7IX71d0t8CIwVeGvBkV8h UBwZrBYq+2vazcmTR8DgoLddhzMz86kPWf4r5Pin/3Jo5IsEtnJJYeLwvavODGeTBFOS /C3t0alpS8FcL3Z5VX1FSKUxoHEVY9NXkWO5MK0RsIt5u0vCqNcZUTvUXxMh988iDNV+ +itQ== X-Gm-Message-State: AAQBX9cvGm7oCjSd+dqI7PqkdtPsuY5oN5lVCiD2YeP4A9aPDxNyLR+O A3Tqzfpf+/eyb+QjdQTk2ZNt2qZt1pSYax07DKQ= X-Google-Smtp-Source: AKy350YGhAK55IH9m3HRLIULLX6nXbdjEI4ZPXu3dFtUowTXi1t0ZVUuRy8i+sI/1QKJ1Bv4FX+PSmBkJCxrn4/j+ZU= X-Received: by 2002:a4a:a584:0:b0:538:d154:cbc2 with SMTP id d4-20020a4aa584000000b00538d154cbc2mr3402728oom.1.1681120279011; Mon, 10 Apr 2023 02:51:19 -0700 (PDT) In-Reply-To: <87zg7ggkzo.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259558 Archived-At: On Mon, Apr 10, 2023 at 10:11=E2=80=AFAM Basil Contovounesios wrote: > > close 62741 30.1 > severity 62741 minor > quit > > Jo=C3=A3o T=C3=A1vora [2023-04-10 09:17 +0100] wrote: > > > Pasting the backtrace here for Dmitry to have a look. > > > > Test eglot-test-eclipse-connect backtrace: > > string-match("\0" nil 0) > > split-string(nil "\0" t) > > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > > #f(compiled-function (dir) #)("/tmp/eglo= t--fixturernYTOR/project/") > > mapcan(#f(compiled-function (dir) #) ("/= tmp/eglot--fixturernYTOR/project/")) > > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > > > It would seem that the problem here is there are no files versioned yet= , > > so this expression in project--vc-list-files > > > > (apply #'vc-git--run-command-string nil "ls-files" args) > > > > Returns nil. > > > > But I cannot reproduce this locally. > > It's easy to reproduce the backtrace without Eglot, and it happens both > on master and emacs-29. From emacs -Q: > > (let ((dir (make-nearby-temp-file "my-" t))) > (unwind-protect > (let ((default-directory (file-name-as-directory dir))) > (make-directory ".git") > (make-empty-file "file") ; Optional. > (require 'project) > (project-files (project-current))) > (delete-directory dir t))) > > C-x C-e This indeed breaks, but it doesn't break if you replace the 'make-directory' with '(shell-command "git init")'. And yet, when you tried that in Eglot's CI, it seem it _did_ break with the same error. So I don't know what's going on. Jo=C3=A3o