From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#71282: 30.0.50; hl-line overlay priority has no affect Date: Sun, 30 Jun 2024 16:50:32 +0100 Message-ID: References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <865xtqh2b7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mohkale@kisara.moe, 71282@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 30 17:51:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNwpm-0006nX-80 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jun 2024 17:51:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNwpU-0007nR-7P; Sun, 30 Jun 2024 11:51:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNwpS-0007lK-74 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 11:51:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNwpR-0008DW-VO for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 11:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNwpR-00084y-OH for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 11:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2024 15:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71282 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 71282-submit@debbugs.gnu.org id=B71282.171976263331022 (code B ref 71282); Sun, 30 Jun 2024 15:51:01 +0000 Original-Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:50:33 +0000 Original-Received: from localhost ([127.0.0.1]:58759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwoz-00084I-9z for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:50:33 -0400 Original-Received: from mail-lf1-f49.google.com ([209.85.167.49]:47575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwox-000849-Bj for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:50:32 -0400 Original-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52cf4ca8904so3403698e87.3 for <71282@debbugs.gnu.org>; Sun, 30 Jun 2024 08:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719762570; x=1720367370; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UFST5wIdkZ9O+PXWhQc15/FnyEwEN/GrB6WmHAFGMNw=; b=jINQSuJrSJX+LdhVTA3exMjlpd3LxG8k2mO05Xv/eHBBteYsFgTdIBvHTm//TjU5cC sxYegiLtrBu0aHdE6/0Q4Hg/u1v29oAUtxMVVsRbtxTThRpTf89VkRfnp8S1GmUaOvjF WozVFZ/mh4aSn/GMv+jV3Oi0Ft8ASz+Iiz6xRchS+Eb2Cf17UHGIQKsUVlFqo5H/mtQS oBwW576LxMNQDHxBNzs2Ti/yZGcr/ya6k0J7qm4ypBXacRumrSt3zCd6u5AXWfkBjqrr Bp4ixqVwRY/h/Asxo51+BaVtY4Bf9NkbBsrf5QJkPEc5B0go5Eiz64ycZJwmgbbgxdsM bIBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719762570; x=1720367370; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UFST5wIdkZ9O+PXWhQc15/FnyEwEN/GrB6WmHAFGMNw=; b=PkaAd5Om6oxKV+QL73rqUfLipuVt/T2MFf8wcpjzaE3GHdubEi52Drh1eDQ+p4gTZk xp4skoKvYb1p6o1Kw+lBcSvK4Tuo0V+du7Twf8d7xicTBi4R+P5wTCkF4HTLJDRu3qUC jV9DwO0oclqJr4ZslQwGFqP01qqHiHT7raLqUmPZOpeanb0AvY9jy9sVMAd/nBCQnyBz WDwltsM1sBtjjl/UcMtosZ4LBJTrEh7jaCQ8cJLpGEQ+GO+Kt8yfUup2T7hI3ua6EGO6 BBP2/uIlQ8fTWK4FAduEUMG1xb4Xm47Bh/WsA1rfFNMOiiskz54/P6UjZO/wcs9C0+JX jVng== X-Forwarded-Encrypted: i=1; AJvYcCUrdA73UOQTflR0H+9hKi1Mc/cRmBxow9lKuGpOmUaFHZtS3trJSaI4pK1jDbPl8ESSg7OtvmL9GzFQ2MykJ+bpOvCAi+U= X-Gm-Message-State: AOJu0YxfeaXU2tP7qvMH3v4pq10l8VvUwjd9HMGJhijJ0u4Qe3olD5+d 7z6XL7v5NK7MS/A8xcmmA5xJiFvc2LjhVND4HnLjhWPlbrJxDDBL7gpFx05cE2V454OAsEl1Q/w PQlKR84I3YYeZa/Um28fSK8aRqmQ= X-Google-Smtp-Source: AGHT+IGKQrGa2USTuq0jBejC5qXZr6l7CMh3Hd6gYN1N2THkuyWAUPxCHqsndcUrsndpcbPmB0lkc/U+kRuCspOETh8= X-Received: by 2002:ac2:46c4:0:b0:52c:dfa2:5ac1 with SMTP id 2adb3069b0e04-52e8266ebddmr1720171e87.24.1719762570076; Sun, 30 Jun 2024 08:49:30 -0700 (PDT) In-Reply-To: <865xtqh2b7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288206 Archived-At: On Sun, Jun 30, 2024 at 4:34=E2=80=AFPM Eli Zaretskii wrote: > The mechanism exists: find the face of the buffer text, and use it (or > some of its attributes, like background color) in determining the face > of the overlay string. Then if that mechanism doesn't require anything specific of package X or Y, it should be possible to condense in a function (that shouldn't live in Eglot, but OK it it starts life there, I guess) that takes a face with a number of attributes,merges with whatever is "the face of the buffer text" and return an (anonymous) face. If so, then that "mistery" function is the fix to this issue. (overlay-put ov (if peg-after-p 'before-string 'after-string) (propertize text - 'face (pcase kind - (1 'eglot-type-hint-face) - (2 'eglot-parameter-hint-face= ) - (_ 'eglot-inlay-hint-face)))) + 'face + (mistery (pcase kind + (1 'eglot-type-hint-face) + (2 'eglot-parameter-hint-f= ace) + (_ 'eglot-inlay-hint-face)= )))) Else, your earlier suggestion proposing "Eglot to be sensitive to hl-line" -- which I understood as creating an explicit dependency between Eglot and hl-line -- is not a good one, and this is where I agree with Moshin. Jo=C3=A3o