unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mohkale@kisara.moe, 71282@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#71282: 30.0.50; hl-line overlay priority has no affect
Date: Sun, 30 Jun 2024 16:50:32 +0100	[thread overview]
Message-ID: <CALDnm53SGyY5TkhZvAeyNpgzbv_9zjZEuqs_p6s3vv516RDfCA@mail.gmail.com> (raw)
In-Reply-To: <865xtqh2b7.fsf@gnu.org>

On Sun, Jun 30, 2024 at 4:34 PM Eli Zaretskii <eliz@gnu.org> wrote:

> The mechanism exists: find the face of the buffer text, and use it (or
> some of its attributes, like background color) in determining the face
> of the overlay string.

Then if that mechanism doesn't require anything specific of package X or
Y, it should be possible to condense in a function (that shouldn't live in
Eglot, but OK it it starts life there, I guess) that takes a face with
a number of
attributes,merges with whatever is "the face of the buffer text" and return
an (anonymous) face.  If so, then that "mistery" function is the fix
to this issue.

                        (overlay-put ov (if peg-after-p 'before-string
'after-string)
                                     (propertize
                                      text
-                                     'face (pcase kind
-                                             (1 'eglot-type-hint-face)
-                                             (2 'eglot-parameter-hint-face)
-                                             (_ 'eglot-inlay-hint-face))))
+                                     'face
+                                     (mistery (pcase kind
+                                                (1 'eglot-type-hint-face)
+                                                (2 'eglot-parameter-hint-face)
+                                                (_ 'eglot-inlay-hint-face)))))


Else, your earlier suggestion proposing "Eglot to be sensitive
to hl-line" -- which I understood as creating an explicit dependency
between Eglot and hl-line -- is not a good one, and this is where I
agree with Moshin.

João





  reply	other threads:[~2024-06-30 15:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 22:27 bug#71282: 30.0.50; hl-line overlay priority has no affect Mohsin Kaleem
2024-05-31  5:44 ` Eli Zaretskii
2024-06-30  6:10   ` Stefan Kangas
2024-06-30 11:42     ` Mohsin Kaleem
2024-06-30 12:23       ` Eli Zaretskii
2024-06-30 13:41         ` Mohsin Kaleem
2024-06-30 14:46           ` Eli Zaretskii
2024-06-30 15:12             ` João Távora
2024-06-30 15:21               ` Mohsin Kaleem
2024-06-30 15:37                 ` Eli Zaretskii
2024-06-30 15:34               ` Eli Zaretskii
2024-06-30 15:50                 ` João Távora [this message]
2024-06-30 16:37                   ` João Távora
2024-06-30 17:36                   ` Eli Zaretskii
2024-06-30 18:09                     ` João Távora
2024-07-01 12:35                     ` Mohsin Kaleem
2024-07-01 13:50                       ` João Távora
2024-06-30 15:18             ` Mohsin Kaleem
2024-06-30 17:28               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm53SGyY5TkhZvAeyNpgzbv_9zjZEuqs_p6s3vv516RDfCA@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=71282@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mohkale@kisara.moe \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).