From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic' Date: Thu, 23 Feb 2023 19:10:08 +0000 Message-ID: References: <87pmffd8ya.fsf@gmail.com> <874jrjf276.fsf@gmail.com> <87h6vcdxev.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58141@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 23 20:11:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVGzz-0004d7-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Feb 2023 20:11:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVGzg-0007QW-Oj; Thu, 23 Feb 2023 14:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVGze-0007Q0-A8 for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 14:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVGze-0008To-2K for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 14:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVGzd-0000Ny-U2 for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 14:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Feb 2023 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58141 X-GNU-PR-Package: emacs Original-Received: via spool by 58141-submit@debbugs.gnu.org id=B58141.16771794271427 (code B ref 58141); Thu, 23 Feb 2023 19:11:01 +0000 Original-Received: (at 58141) by debbugs.gnu.org; 23 Feb 2023 19:10:27 +0000 Original-Received: from localhost ([127.0.0.1]:35367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVGz4-0000Mx-UE for submit@debbugs.gnu.org; Thu, 23 Feb 2023 14:10:27 -0500 Original-Received: from mail-oa1-f49.google.com ([209.85.160.49]:44863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVGz3-0000Md-Ad for 58141@debbugs.gnu.org; Thu, 23 Feb 2023 14:10:25 -0500 Original-Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-1720600a5f0so16807977fac.11 for <58141@debbugs.gnu.org>; Thu, 23 Feb 2023 11:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QHVvwPvBGvNAupu2VwXn842y97/1VJcQ+tqLKSU28Ag=; b=mjs6PE1YrjWXvOCOf9etRaSmCvk9LVq87wYc+02v/vdE/dD/g6t2YgWQ0LN9w8Trky acYwad70oymbns8u71IeDonImWF82OtNQlDRqiTxUlQ3VMofyzkvsykRlqf57Y1ReTwR GJTy2I1JJUdsvPzPFqq05jclwEAeQdgdwMKX1zlnOC6mfd/DB6/yFzS6VOhOT+1AMpVg OdbDhQZt4iPMR0CwQWfHqazXbPR1CZL52G+h4o4eaHE4oC3/quL9Zu6QwsPAl3Pdsnhw nyVi8waelGOU7FgJGEHBNSJIWulfmNXlKecFH5TUuTU57ZyKsTPgbIyZR0d4Qh1XLQ20 HBrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QHVvwPvBGvNAupu2VwXn842y97/1VJcQ+tqLKSU28Ag=; b=gVUZ7plBnDWcdyiWYchMFk6SUYbexyEuFtZ4Fb31zGACxqFBqD2+rWwYpmswR38fwN YcSKdgzmO5UgWDtyMjrcrBh/rRgfk6xxrjHPx3qS26KDcoUhIgY/zklXQMBND8x7GVzj AMwW3xFHVkm/I+IroMxOCibu1qHR/j1Po4sjDuIgw603YgxsAt8gSRj3ZQvLeiGzS1Jd UA66NUKa+SayHpVqOTiNRkd/1RJinu3uXdPHmil7WPVol+aC64s+3f8NgHdqcICoQ+r1 ++tgiGZUvzNmdYtLTNBbNvL1OSdIGTT27T03CrSDrYqyDpQJnLwIZhZRvb4HavkB2NHS PjoQ== X-Gm-Message-State: AO0yUKU5rCHxVxY/hasdisVSd/xeKXk4kRKCRSMf9VdWW9TD9p3vKkMT 6AiGF7TsxAzWwxCrpwpHNdPRZmGdNrhnGdY4y5s= X-Google-Smtp-Source: AK7set/22kS2wZk6U3/9ARIt/mJdoDDNB2zDOkWSnjH/ekIZGY2wHvi6Sn+FsBghK0yV6fYqQRUiX8TR/Kmic6m9ihA= X-Received: by 2002:a05:6870:c7ab:b0:172:3d66:734b with SMTP id dy43-20020a056870c7ab00b001723d66734bmr305676oab.8.1677179419525; Thu, 23 Feb 2023 11:10:19 -0800 (PST) In-Reply-To: <87h6vcdxev.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256516 Archived-At: On Thu, Feb 23, 2023 at 6:55 PM Augusto Stoffel wrote= : > > On Thu, 23 Feb 2023 at 11:59, Jo=C3=A3o T=C3=A1vora wrote: > > > I'm not a fan of hardcoding colors in Eglot, since that needs themes > > to update for the new face. Supporting the optional underline is > > probably fine, though. > > Okay, but the current choice (inherit from shadow) is also not a safe > one with respect to themes. That's a problem with theme. The default theme has a good setting for "shadow", in my opinion. Jo=C3=A3o