From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#49005: 28.0.50; Not possible to jump to first or last completions entry in fido-vertical-mode Date: Wed, 30 Jun 2021 21:08:55 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3239"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49005@debbugs.gnu.org To: Simon Lang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 30 22:10:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lygXV-0000Sg-8m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Jun 2021 22:10:29 +0200 Original-Received: from localhost ([::1]:40798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lygXS-0006Qe-Cu for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Jun 2021 16:10:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lygX4-0006Og-6z for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 16:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lygX3-0001h0-VK for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 16:10:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lygX3-0003xa-Qp for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 16:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49005 X-GNU-PR-Package: emacs Original-Received: via spool by 49005-submit@debbugs.gnu.org id=B49005.162508375415160 (code B ref 49005); Wed, 30 Jun 2021 20:10:01 +0000 Original-Received: (at 49005) by debbugs.gnu.org; 30 Jun 2021 20:09:14 +0000 Original-Received: from localhost ([127.0.0.1]:58834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lygWH-0003wR-QE for submit@debbugs.gnu.org; Wed, 30 Jun 2021 16:09:14 -0400 Original-Received: from mail-pj1-f43.google.com ([209.85.216.43]:53141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lygWG-0003wE-0x for 49005@debbugs.gnu.org; Wed, 30 Jun 2021 16:09:12 -0400 Original-Received: by mail-pj1-f43.google.com with SMTP id kt19so2579769pjb.2 for <49005@debbugs.gnu.org>; Wed, 30 Jun 2021 13:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=u65bakHPYTgLy5rdhoFJqVRL8P70tT73xjrwY3O3urE=; b=oEPe1I7c2FSxAJK9eaTO0H0xrBoTogDrM8hQpA19KUPbohr2p0q4PvstS6uoYxvxLI i2UqJdN7q4MnlyrSW7hpx4D9YKytAAdYWf25XE7HQiS4AJjfVaKG6aXbgWmGSMkK9Ee3 SmjJGsm+CoM45jyUyg+zsUF6uW1Y6H4T/ixf+xidT+dG/ppS808cSVX9RHjl8oIxZcGK Lv4p7rRJPtaFzrN1W2W4/AwZ+Ry7LRDHnbYHe00kgv9VhbIYt+BSjs4D4s6jTgJgCoz/ FOtNUdYNByjApBil/j6Avgcs+ewT3i9rYN8qeWlS1R30A5xCKpwIyCtyxZpK1uRNJzaq V7bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=u65bakHPYTgLy5rdhoFJqVRL8P70tT73xjrwY3O3urE=; b=NcnWnr9yJkJ1sSnYZ4TiMbkEB7DQDQY5PpZi5QMNxEgtXIWdchRjJRhul9ILnUMS5X SJnBX+boTYrd5gEylbw/vMJvmUUrDDrFPRynCCGwiEAUVrJtG5avs+W/8Uzum6rv2Ejm Oy0EtNjmI5u0CoBkB7VpTExaILEXqv7xD6NcbOwNubvizt7qs9bfrQ+y0fvoVdaF2NBN H6A/I18tScpjhGO1XUbAakRJxMjmqH8T1KZvlJDggk5MUu6xLDuGJnInrA+6QChIIehV pfR5In42JirkddKoQHGbDVsV5enpQPJG1XGc+RketNQ1heplLfog0dqR6Y4zVJH1GgTi OtmA== X-Gm-Message-State: AOAM533MdmDHQi1kh928oySn+UcXgL9cpk7AtaWI78zgcJxrxoFmAJSL mmt8tYpWX3TBRDvXV4XvNA9O4d4qcmncdVzen10= X-Google-Smtp-Source: ABdhPJzcjfl2CXM85nCDFp1bINf13k9993vhlfLfqzk9KOrrFM5dWfvdTNnZkjQzI93sYttTG7dHtVY6B99YL4EgkTo= X-Received: by 2002:a17:902:a981:b029:116:a139:6054 with SMTP id bh1-20020a170902a981b0290116a1396054mr33564500plb.60.1625083746282; Wed, 30 Jun 2021 13:09:06 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209239 Archived-At: No, no, makes a lot of sense. I just haven't looked at your code yet in depth. Your implementation seems to repeat some logic, and I'd rather reuse paging code, so maybe you can work on that: reducing code duplication. But as soon as I have time I'll look at this and offer some suggestions. Sorry for the delay, and keep bumping this if I forget. Jo=C3=A3o On Wed, Jun 30, 2021 at 8:27 PM Simon Lang wrote: > > doesn=E2=80=99t make sense? > > > On 13 Jun 2021, at 16:27, Simon Lang wrote: > > > > > > In the brand new fido-vertical mode, completions are not cycled in cont= rast to icomplete-vertical-mode. > > There is not yet a function to jump to the first or last completions en= try, which sometimes can be helpful. > > This patch would proposes two simple helper functions for doing that. > > > > Thank you! > > > > > > > > > > > > In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.5.0, NS appkit-202= 2.50 Version 11.4 (Build 20F71)) > > of 2021-06-06 built on Zwei.local > > Windowing system distributor 'Apple', version 10.3.2022 > > System Description: macOS 11.4 > > > > Configured using: > > 'configure --disable-dependency-tracking --disable-silent-rules > > --enable-locallisppath=3D/usr/local/share/emacs/site-lisp > > --infodir=3D/usr/local/Cellar/emacs-plus@28/28.0.50/share/info/emacs > > --prefix=3D/usr/local/Cellar/emacs-plus@28/28.0.50 --with-xml2 > > --with-gnutls --with-native-compilation --without-dbus > > --with-imagemagick --with-modules --with-rsvg --with-ns > > --disable-ns-self-contained 'CFLAGS=3D-I/usr/local/opt/gcc/include > > -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include > > -I/usr/local/opt/jpeg/include' 'LDFLAGS=3D-L/usr/local/lib/gcc/11 > > -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include > > -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include'' > > > > Configured features: > > ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES > > NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF > > TOOLKIT_SCROLL_BARS XIM ZLIB > > > > Important settings: > > value of $LANG: en_GB.UTF-8 > > locale-coding-system: utf-8-unix > > > > Major mode: Lisp Interaction > > > > Minor modes in effect: > > tooltip-mode: t > > global-eldoc-mode: t > > eldoc-mode: t > > electric-indent-mode: t > > mouse-wheel-mode: t > > tool-bar-mode: t > > menu-bar-mode: t > > file-name-shadow-mode: t > > global-font-lock-mode: t > > font-lock-mode: t > > blink-cursor-mode: t > > auto-composition-mode: t > > auto-encryption-mode: t > > auto-compression-mode: t > > line-number-mode: t > > transient-mark-mode: t > > > > Load-path shadows: > > None found. > > > > Features: > > (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs > > rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail > > rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs > > eieio-loaddefs password-cache json map text-property-search time-date > > subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies > > mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddef= s > > cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-util= s > > iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks > > lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util > > term/common-win tool-bar dnd fontset image regexp-opt fringe > > tabulated-list replace newcomment text-mode elisp-mode lisp-mode > > prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu > > timer select scroll-bar mouse jit-lock font-lock syntax font-core > > term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang > > misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms > > cp51932 hebrew greek romanian slovak czech european ethiopic indian > > cyrillic chinese composite charscript charprop case-table epa-hook > > jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button > > loaddefs faces cus-face macroexp files window text-properties overlay > > sha1 md5 base64 format env code-pages mule custom widget > > hashtable-print-readable backquote threads kqueue cocoa ns lcms2 > > multi-tty make-network-process native-compile emacs) > > > > Memory information: > > ((conses 16 67367 8465) > > (symbols 48 6527 0) > > (strings 32 18695 2230) > > (string-bytes 1 645512) > > (vectors 16 13390) > > (vector-slots 8 280721 11188) > > (floats 8 22 39) > > (intervals 56 226 0) > > (buffers 992 10)) > > > > <0001-icomplete-vertical-functions-to-go-to-first-or-last-.patch> > --=20 Jo=C3=A3o T=C3=A1vora