From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Thu, 18 Apr 2024 17:15:52 +0100 Message-ID: References: <86y19ad61t.fsf@gnu.org> <43de4151-ab68-4214-8691-33f3554feba1@email.android.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8719"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 70036@debbugs.gnu.org, felician.nemeth@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 18 18:17:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxURm-0001gS-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Apr 2024 18:17:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxURb-0006TD-UU; Thu, 18 Apr 2024 12:17:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxURP-0006Rd-8n for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:16:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxURO-0007kU-D6 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:16:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxURb-0005GL-SF for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:17:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2024 16:17:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171345698820008 (code B ref 70036); Thu, 18 Apr 2024 16:17:03 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 18 Apr 2024 16:16:28 +0000 Original-Received: from localhost ([127.0.0.1]:53281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxUR0-0005CS-Mj for submit@debbugs.gnu.org; Thu, 18 Apr 2024 12:16:28 -0400 Original-Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:42246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxUQx-0005BC-H4 for 70036@debbugs.gnu.org; Thu, 18 Apr 2024 12:16:25 -0400 Original-Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2da0f8f7b24so12655901fa.1 for <70036@debbugs.gnu.org>; Thu, 18 Apr 2024 09:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713456964; x=1714061764; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yOGwPyChjevDXlISv2VPiy2juIj6ZB7GJnB0csU1E6Y=; b=i+VY8VXTubCTjV6vSysUXkJf/+MZi5ur0s2ox09PUfxrK0AAbmK7J2k2SFdn1Uwk8r 4N8ibd7vo3R6t2N7Bd/vDPGF5nrrEzBb2emGo4aKli3/2cmwwULO16+gvpomfg1kcPlB eIK4MSXgpyIvppOImbYmyjnU69AdUDiTxFMaWtxU1Xu3Wl7xf/WMFkEiMkOPWLMkY1Dz FiW2aMlRJ1Z3jXhKyuja4WCH0Yj9Gf/3fFFyLgchNgB2etYA4f+D/RnN5Ii+Bxjg9r8f T7C58u9OfQ2M5JaMZb/hFyuNJ1/AfV47UYEY3YN1JLedJBHhd9zkv3xFRB2jgo/lAfNm OCrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713456964; x=1714061764; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yOGwPyChjevDXlISv2VPiy2juIj6ZB7GJnB0csU1E6Y=; b=WbuhDYNq1bJ6JI8FxZfi4yCexm80g5xl8shJY7CoeWNV42Vda3ET4jxHMOmcaKmaYp us4RXQ/Eo8pUMrehYDosoRT8grnJXcCVYy/9O2vJXlfHatT7wwrVWNmM0JjHhu8x72FG fqCzwYrkhVTZYny1MKFM1CUIWWmbblgbgNjhT67bup8/Vn2rvc6Nt+k5M0sY9GrQHyYk XbPB54+9g4EcmUopkd7tf74jyHIQIes5hpMJXCxgNj3iuN9PCiHSXENonWPFB5zK+qkZ C+tkAvXtAk9B/ybgG/KLnMFoHyfVSHwccKIf4qVhOb/MGjuU2Ja3iQRHV0futGvo7oII MZ1A== X-Forwarded-Encrypted: i=1; AJvYcCV7ySZM8um3eb8+Kqbeq1vH8hPItRS16AN2m8AFFwNXOEnZJZOYiKpBuYTToagCF96fXnMj6k+wK9eGHKbNnkUtDjbLLtQ= X-Gm-Message-State: AOJu0Yxz9PXFwLknPZzBiBX/8pWNVOgHoxZLebfYEYBpsdUkirEZwVGI 6IVTZ0gBWQM5kafuIcCnDVaHPxqtBrljywQaz1YeBL73tn75/BIsErbSeZJesV4FKevpTuJMsr8 QGDRpzEkx/YrxFPBgy4cbWC3zHUc= X-Google-Smtp-Source: AGHT+IEBOOTbd7lnzSb8KBRCh6CKcxZTZ8bq8UlXFyg7jmOgw18d5eqmHaznxYHkCrP9zDv2IatZDx502Zrjg4NOXbA= X-Received: by 2002:a2e:b0d0:0:b0:2d6:f8d7:ab95 with SMTP id g16-20020a2eb0d0000000b002d6f8d7ab95mr773666ljl.21.1713456963735; Thu, 18 Apr 2024 09:16:03 -0700 (PDT) In-Reply-To: <43de4151-ab68-4214-8691-33f3554feba1@email.android.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283584 Archived-At: On Thu, Apr 18, 2024 at 5:11=E2=80=AFPM Theodor Thornhill wrote: > > Profiles can mislead and they can lie. It is much easier to time the > > old and the new code doing the same jobs, and compare the times. > > > >> If so, I think this simpler patch after my sig is all we need, as it > >> completely clears the profile of any "file-truename". I have reverte= d > >> the earlier patch and pushed a patch very similar to the one after my= sig. > > That's unfortunate. For you maybe. From my standpoint noone else besides you has complained about these problems, and I am still Eglot maintainer and must protect against regressions. > > This new code should also be timed and compared to the other two > > versions, before we make the final decision on this. > > This is a very unfortunate change. This completely misses the point and > reverts any perf gains from my previous patch... I think your > conclusions are too quick, and actions likewise. > > I'd argue that long paths are a way more common occurrence than > symlinking, and the places you touched in your "better way" ignores the > performance critical parts. > > The function you are suggesting isn't the hotspot. Most notable > publishDiagnostics is, which now is killed again. Then you should publish details for a reproducible experiment and we can take it from there. The experiments I ran were the ones I could gather from a reading of your profiles. The patch I used was very effective in solving the performance effects. Jo=C3=A3o